Page MenuHomePhabricator
Create Task
Maniphest T194178

Make WDQS UI page title configurable
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Problem:
copyright.html, embed.html and index.html contain a hardcoded <title>Wikidata Query Service</title> element, which is not suitable for all installations. It should be configurable.

Acceptance criteria:

  • the name of the query service can be adapted for a project in one single place

Approach

  • Have a JS script that runs on page load for all of the pages referenced that replaces the titles with other configured titles

Patch-For-Review

Details

SubjectRepoBranchLines +/-
Set title from config in copyright.htmlwikidata/query/guimaster+16 -0
Set title from config in embed.htmlwikidata/query/guimaster+1 -0
Merging from 0b6e4cb55e254379d0c58527355bba654dc61b92:wikidata/query/gui-deployproduction+4 -4
Change “Wikidata Query” to “Wikidata Query Service”wikidata/query/guimaster+6 -6
Set document title without jQuerywikidata/query/guimaster+1 -1
Change title of page to config.brand.titlewikidata/query/guimaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 8 2018, 4:28 PM
• Vvjjkkii renamed this task from Make WDQS UI page title configurable to hddaaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot updated the task description. (Show Details)Jul 1 2018, 3:26 PM
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Vachovec1 renamed this task from hddaaaaaaa to Make WDQS UI page title configurable.Jul 1 2018, 4:32 PM
Vachovec1 raised the priority of this task from High to Needs Triage.
Vachovec1 added a subscriber: Aklapper.
Addshore mentioned this in T205025: Remove references to Wikidata from Wikidata Query Service UI.Sep 20 2018, 10:06 PM
Lydia_Pintscher updated the task description. (Show Details)Dec 3 2018, 9:35 PM
Lydia_Pintscher added a project: Wikidata-Campsite.Dec 3 2018, 9:42 PM
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Addshore triaged this task as Medium priority.Dec 4 2018, 9:21 AM
Addshore set the point value for this task to 5.Dec 4 2018, 2:14 PM
Addshore moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Dec 4 2018, 2:49 PM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore updated the task description. (Show Details)Dec 4 2018, 2:53 PM
gerritbot subscribed.Dec 4 2018, 8:04 PM

Change 477627 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[wikidata/query/gui@master] Change title of page to config.brand.title

https://gerrit.wikimedia.org/r/477627

gerritbot added a project: Patch-For-Review.Dec 4 2018, 8:04 PM
Ladsgroup claimed this task.Dec 4 2018, 8:06 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 4 2018, 8:06 PM
Ladsgroup mentioned this in rWDQGe333fc57b83c: Change title of page to config.brand.title.Dec 4 2018, 8:07 PM
gerritbot added a comment.Dec 5 2018, 1:25 PM

Change 477774 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Set document title without jQuery

https://gerrit.wikimedia.org/r/477774

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 5 2018, 1:26 PM
gerritbot added a comment.Dec 5 2018, 1:26 PM

Change 477627 merged by jenkins-bot:
[wikidata/query/gui@master] Change title of page to config.brand.title

https://gerrit.wikimedia.org/r/477627

Lucas_Werkmeister_WMDE mentioned this in rWDQG6317a8c530f2: Set document title without jQuery.Dec 5 2018, 1:27 PM
gerritbot added a comment.Dec 5 2018, 1:32 PM

Change 477774 merged by jenkins-bot:
[wikidata/query/gui@master] Set document title without jQuery

https://gerrit.wikimedia.org/r/477774

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 5 2018, 1:33 PM
Lucas_Werkmeister_WMDE added a comment.Dec 5 2018, 1:37 PM

Note: as currently implemented, this will change the title on query.wikidata.org from “Wikidata Query Service” to “Wikidata Query”, without the “Service” (because that’s the name that’s displayed in the upper left corner, between the logo and the “examples” button). We may need to split the “brand” into two different strings to preserve the current WDQS behavior.

Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 5 2018, 4:09 PM
gerritbot added a comment.Dec 5 2018, 7:08 PM

Change 477836 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Change “Wikidata Query” to “Wikidata Query Service”

https://gerrit.wikimedia.org/r/477836

Lucas_Werkmeister_WMDE mentioned this in rWDQG0b6e4cb55e25: Change “Wikidata Query” to “Wikidata Query Service”.Dec 5 2018, 7:09 PM
Lucas_Werkmeister_WMDE added a comment.Dec 5 2018, 7:09 PM

Lydia says we can just change the brand to include the word “service” – see the above change.

gerritbot added a comment.Dec 5 2018, 7:50 PM

Change 477836 merged by jenkins-bot:
[wikidata/query/gui@master] Change “Wikidata Query” to “Wikidata Query Service”

https://gerrit.wikimedia.org/r/477836

gerritbot added a comment.Dec 5 2018, 7:53 PM

Change 477842 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from 0b6e4cb55e254379d0c58527355bba654dc61b92:

https://gerrit.wikimedia.org/r/477842

gerritbot added a comment.Dec 5 2018, 10:00 PM

Change 477842 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 0b6e4cb55e254379d0c58527355bba654dc61b92:

https://gerrit.wikimedia.org/r/477842

gerritbot added a comment.Dec 18 2018, 8:18 PM

Change 480583 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[wikidata/query/gui@master] Set title from config in embed.html

https://gerrit.wikimedia.org/r/480583

Ladsgroup mentioned this in rWDQG90681e002eeb: Set title from config in embed.html.Dec 18 2018, 8:19 PM
gerritbot added a comment.Dec 18 2018, 10:32 PM

Change 480660 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[wikidata/query/gui@master] Set title from config in copyright.html

https://gerrit.wikimedia.org/r/480660

Ladsgroup mentioned this in rWDQG085ca98e7124: Set title from config in copyright.html.Dec 18 2018, 10:34 PM
Ladsgroup updated the task description. (Show Details)Dec 18 2018, 10:47 PM
Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Ladsgroup mentioned this in rWDQG17b7ddc19482: Set title from config in copyright.html.Dec 18 2018, 11:24 PM
gerritbot added a comment.Dec 18 2018, 11:36 PM

Change 480583 merged by jenkins-bot:
[wikidata/query/gui@master] Set title from config in embed.html

https://gerrit.wikimedia.org/r/480583

gerritbot added a comment.Dec 19 2018, 12:50 AM

Change 480660 abandoned by Ladsgroup:
Set title from config in copyright.html

Reason:
In favor of I39e16dff1e4d98a165acf14848c2dca3cb668a1b

https://gerrit.wikimedia.org/r/480660

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 19 2018, 1:20 AM
Addshore moved this task from incoming to in progress on the Wikidata board.Dec 19 2018, 12:47 PM
Addshore closed this task as Resolved.Jan 7 2019, 6:12 PM
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore subscribed.

I updated the wikibase-registry query service UI and this can be seen working there: https://wikibase-registry-query.wmflabs.org

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL