Page MenuHomePhabricator
Create Task
Maniphest T194270

Drop 'tmp1' index from wb_terms table in production
Closed, ResolvedPublic
Actions

Description

While checking indexes of wb_terms I realized the index schema is completely different between production and the codebase. The thing that makes the fix complicated is that we need to drop some indexes in the code base as well but the first step towards this action is to drop tmp1 index from wb_terms in production which obviously is not in the codebase, serves no use cases at the moment and supposed to be there temporary but someone probably forgot to drop it.

Details

SubjectRepoBranchLines +/-
db-eqiad.php: Depool db1109operations/mediawiki-configmaster+1 -1
db-eqiad.php: Depool db1104operations/mediawiki-configmaster+2 -2
db-eqiad.php: Depool db1087operations/mediawiki-configmaster+5 -5
db-eqiad.php: Depool db1101:3318operations/mediawiki-configmaster+6 -6
db-eqiad.php: Depool db1099:3318operations/mediawiki-configmaster+6 -6
db-eqiad.php: Depool db1104operations/mediawiki-configmaster+2 -2
db-eqiad.php: Depool db1092operations/mediawiki-configmaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.May 9 2018, 1:56 PM
Ladsgroup mentioned this in T188992: Make wb_terms table fancy.May 9 2018, 2:01 PM
Marostegui triaged this task as Medium priority.May 9 2018, 3:14 PM
Marostegui moved this task from Triage to Backlog on the DBA board.
Marostegui subscribed.

As I have to do a schema change on s8 soonish I wanted to include this one too.

But I wanted to make sure I understood this issue correctly. There is no code referencing this index so it can be dropped anytime? This index doesn't exist anywhere on code (or tables definition), right?

It is 'just' something that was added ad-hoc on production without referencing it in tables definitions or anything?

Thank you!

Lucas_Werkmeister_WMDE added a comment.May 9 2018, 3:21 PM

As far as I can tell, the index is not referenced anywhere (code search only turns up a few unrelated results), and it was never introduced into the Wikibase repository itself (git log -S tmp1 is empty).

jcrespo added a comment.May 9 2018, 3:23 PM

This would have been very useful in this case https://dev.mysql.com/doc/refman/8.0/en/invisible-indexes.html

Marostegui moved this task from Backlog to Pending comment on the DBA board.May 16 2018, 10:27 AM
Marostegui claimed this task.May 22 2018, 5:38 AM
Marostegui moved this task from Pending comment to In progress on the DBA board.

I need to deploy other schema changes on s8, so I will include this as it is a pretty straightforward one.

Stashbot subscribed.May 22 2018, 5:03 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-22T17:03:36Z] <marostegui> Deploy schema change on s8 codfw primary master (db2045), this will generate lag on codfw - T194270

Marostegui added a comment.EditedMay 22 2018, 5:10 PM

Deletion progress:

  • codfw

eqiad:

  • dbstore1002
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • db1095
  • db1109
  • db1104
  • db1116
  • db1101
  • db1099
  • db1092
  • db1087
  • db1071
Stashbot mentioned this in T191519: Schema change for rc_namespace_title_timestamp index.May 23 2018, 5:21 AM
Stashbot mentioned this in T188299: Schema change for refactored actor storage.
Stashbot mentioned this in T190148: Change DEFAULT 0 for rev_text_id on production DBs.
Stashbot mentioned this in T194273: Clean up indexes of wb_terms table.

Mentioned in SAL (#wikimedia-operations) [2018-05-23T05:21:48Z] <marostegui> Deploy schema change on dbstore1002:s8 - T191519 T188299 T190148 T194273 T194270

gerritbot subscribed.May 23 2018, 5:34 AM

Change 434624 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/mediawiki-config@master] db-eqiad.php: Depool db1092

https://gerrit.wikimedia.org/r/434624

gerritbot added a project: Patch-For-Review.May 23 2018, 5:34 AM
gerritbot added a comment.May 23 2018, 5:40 AM

Change 434624 merged by jenkins-bot:
[operations/mediawiki-config@master] db-eqiad.php: Depool db1092

https://gerrit.wikimedia.org/r/434624

Stashbot added a comment.May 23 2018, 5:43 AM

Mentioned in SAL (#wikimedia-operations) [2018-05-23T05:43:48Z] <marostegui> Deploy schema change on db1092 - T191519 T188299 T190148 T194273 T194270

gerritbot added a comment.May 23 2018, 6:22 AM

Change 434631 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/mediawiki-config@master] db-eqiad.php: Depool db1104

https://gerrit.wikimedia.org/r/434631

gerritbot added a comment.May 23 2018, 6:36 AM

Change 434631 abandoned by Marostegui:
db-eqiad.php: Depool db1104

https://gerrit.wikimedia.org/r/434631

gerritbot added a comment.May 23 2018, 8:14 AM

Change 434640 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/mediawiki-config@master] db-eqiad.php: Depool db1099:3318

https://gerrit.wikimedia.org/r/434640

gerritbot added a comment.May 23 2018, 8:19 AM

Change 434640 merged by jenkins-bot:
[operations/mediawiki-config@master] db-eqiad.php: Depool db1099:3318

https://gerrit.wikimedia.org/r/434640

Stashbot added a comment.May 23 2018, 8:21 AM

Mentioned in SAL (#wikimedia-operations) [2018-05-23T08:21:11Z] <marostegui> Deploy schema change on db1099:3318 - T191519 T188299 T190148 T194270

gerritbot added a comment.May 23 2018, 9:24 AM

Change 434648 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/mediawiki-config@master] db-eqiad.php: Depool db1101:3318

https://gerrit.wikimedia.org/r/434648

gerritbot added a comment.May 23 2018, 9:28 AM

Change 434648 merged by jenkins-bot:
[operations/mediawiki-config@master] db-eqiad.php: Depool db1101:3318

https://gerrit.wikimedia.org/r/434648

Stashbot added a comment.May 23 2018, 9:30 AM

Mentioned in SAL (#wikimedia-operations) [2018-05-23T09:30:36Z] <marostegui> Deploy schema change on db1101:3318 - T191519 T188299 T190148 T194270

gerritbot added a comment.May 24 2018, 6:12 AM

Change 434868 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/mediawiki-config@master] db-eqiad.php: Depool db1087

https://gerrit.wikimedia.org/r/434868

gerritbot added a comment.May 24 2018, 6:16 AM

Change 434868 merged by jenkins-bot:
[operations/mediawiki-config@master] db-eqiad.php: Depool db1087

https://gerrit.wikimedia.org/r/434868

Stashbot added a comment.May 24 2018, 6:17 AM

Mentioned in SAL (#wikimedia-operations) [2018-05-24T06:17:40Z] <marostegui> Deploy schema change on db1087, this will generate lag on labs on s8 - T191519 T188299 T190148 T194270

gerritbot added a comment.May 24 2018, 6:41 AM

Change 434872 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/mediawiki-config@master] db-eqiad.php: Depool db1104

https://gerrit.wikimedia.org/r/434872

gerritbot added a comment.May 24 2018, 6:45 AM

Change 434872 merged by jenkins-bot:
[operations/mediawiki-config@master] db-eqiad.php: Depool db1104

https://gerrit.wikimedia.org/r/434872

Stashbot added a comment.May 24 2018, 6:47 AM

Mentioned in SAL (#wikimedia-operations) [2018-05-24T06:47:02Z] <marostegui> Deploy schema change on db1104 - T191519 T188299 T190148 T194270

gerritbot added a comment.May 24 2018, 7:30 AM

Change 434875 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/mediawiki-config@master] db-eqiad.php: Depool db1109

https://gerrit.wikimedia.org/r/434875

gerritbot added a comment.May 24 2018, 7:34 AM

Change 434875 merged by jenkins-bot:
[operations/mediawiki-config@master] db-eqiad.php: Depool db1109

https://gerrit.wikimedia.org/r/434875

Stashbot added a comment.May 24 2018, 7:36 AM

Mentioned in SAL (#wikimedia-operations) [2018-05-24T07:36:27Z] <marostegui> Deploy schema change on db1109 - T191519 T188299 T190148 T194270

Stashbot added a comment.May 24 2018, 8:05 AM

Mentioned in SAL (#wikimedia-operations) [2018-05-24T08:05:15Z] <marostegui> Deploy schema change on s8 primary master (db1071) - T191519 T188299 T190148 T194270

Marostegui closed this task as Resolved.May 24 2018, 8:42 AM

This index has been dropped everywhere in s8

WMDE-leszek mentioned this in T197854: Rename tmp1 index on wb_terms databases to something more meaningful.Jun 21 2018, 10:21 AM
• Vvjjkkii renamed this task from Drop 'tmp1' index from wb_terms table in production to xadaaaaaaa.Jul 1 2018, 1:10 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Marostegui as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Marostegui renamed this task from xadaaaaaaa to Drop 'tmp1' index from wb_terms table in production.Jul 1 2018, 6:36 PM
Marostegui closed this task as Resolved.
Marostegui claimed this task.
Marostegui lowered the priority of this task from High to Medium.
Marostegui removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Marostegui updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL