Page MenuHomePhabricator

[[MediaWiki:Undo-summary]] i18n issue
Closed, ResolvedPublic

Description

Message should be updated to use Special:Redirect/revision/1234567.

Change from

Undo revision $1 by [[Special:Contributions/$2|$2]] ([[User talk:$2|talk]])

into

Undo revision [[Special:Redirect/revision/$1|$1]] by [[Special:Contributions/$2|$2]] ([[User talk:$2|talk]])

Note that the only visible change would be for the oldid ($1) to be linked and go to the undone revision.

See also w:no:Wikipedia:Tinget/Arkiv/2018/mai#Klikkbare lenker i redigeringssammendrag.


URL: https://translatewiki.net/wiki/MediaWiki:Undo-summary

Event Timeline

Aklapper added a subscriber: Liuxinyu970226.

@Liuxinyu970226: This is unrelated to MediaWiki's Internationalization code infrastructure but only a request to change a string. :)

eh, but title seems still i18n related, isn't that?

I don't see any i18n problem in this task (someone correct me if I'm wrong!). It's just the default task title that always includes "i18n" (see also T188379)...

It is a change request to clean up message from the time before links in the summary. I even believe I wrote something similar in Bugzilla… ;)

The title can be changed if anyone has a serious problem with it.

CommunityTechBot renamed this task from b7caaaaaaa to [[MediaWiki:Undo-summary]] i18n issue.Jul 2 2018, 4:19 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.

Do we need this? Or mark it as stalled for the moment until we find a use-case? :)

Is this still not fixed? Even something as trivial as this?

@jeblad: Your trivial patch in Gerrit is still welcome to fix this.

Is this still not fixed? Even something as trivial as this?

I'm asking per discussion above, and yes it's trivial but do we need it? Maybe people specialized in this domain would give a signal? :)

In T194400#4719898, @D3r1ck01 wrote:

Is this still not fixed? Even something as trivial as this?

I'm asking per discussion above, and yes it's trivial but do we need it? Maybe people specialized in this domain would give a signal? :)

The link to the revision will give a quick access to the revisions we are reverting, so we can lookup edit summaries? (the metadata about the editor is on undoing edit summary, so unnecessary.)

@jeblad: Your trivial patch in Gerrit is still welcome to fix this.

Argh! But it is way more fun to point out the obvious bugs!

Perhaps I'll make a patch.

Change 471788 had a related patch set uploaded (by John Erling Blad; owner: John Erling Blad):
[mediawiki/core@master] Core: Changed undo messages

https://gerrit.wikimedia.org/r/471788

Change 471788 abandoned by John Erling Blad:
Core: Changed undo messages

Reason:
Never mind.

https://gerrit.wikimedia.org/r/471788

@jeblad: Please stop spamming tickets with rhetorical questions that you can answer yourself.

This process is completely and utterly broken.

The edit summary now links to [[Special:Diff/<revid>]] (T333113).

Pppery subscribed.

The edit summary now links to [[Special:Diff/<revid>]] (T333113).

I'm going to call that close enough and close this as resolved.