Fatal error: $this is null in /srv/mediawiki/php-1.32.0-wmf.4/extensions/Echo/includes/model/Event.php on line 345
None available
This started with MediaWiki 1.32.0-wmf.4
I think this is triggered by a static call to a non-static method which was added in rECHObe88fc58c1af: Make NotificationJob json-serializable
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Revert "Make NotificationJob json-serializable" | mediawiki/extensions/Echo | wmf/1.32.0-wmf.4 | +3 -10 |
| rECHO extension-Echo | |||
| rECHObe88fc58c1af Make NotificationJob json-serializable | |||
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Pchelolo | T157088 [EPIC] Develop a JobQueue backend based on EventBus | |||
| Resolved | • Pchelolo | T190327 FY17/18 Q4 Program 8 Services Goal: Complete the JobQueue transition to EventBus | |||
| Resolved | SBisson | T192945 Make EchoNotification job JSON-serializable | |||
| Resolved | Release | • mmodell | T191051 1.32.0-wmf.5 deployment blockers | ||
| Resolved | PRODUCTION ERROR | SBisson | T194848 Fatal error: $this is null in Echo/includes/model/Event.php on line 345 |
Looks like this was introduced in rECHObe88fc58c1af: Make NotificationJob json-serializable
Mentioned in SAL (#wikimedia-operations) [2018-05-16T19:38:50Z] <twentyafterfour> The train for 1.32.0-wmf.4 is blocked by fatals in Echo extension. See T194848
Change 433441 had a related patch set uploaded (by 20after4; owner: 20after4):
[mediawiki/extensions/Echo@wmf/1.32.0-wmf.4] Revert "Make NotificationJob json-serializable"
I'm not seeing any notifications since about 2 days in mediawiki.org from flow posts, even though my watchlist has changes from them. I assume the cause is this task, right? Or do you prefer to open a new task for investigation?
Mentioned in SAL (#wikimedia-operations) [2018-05-17T19:11:28Z] <twentyafterfour> train is still blocked by T194848
Change 433441 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.32.0-wmf.4] Revert "Make NotificationJob json-serializable"
@Ciencia_Al_Poder Indeed that is probably caused by this one, however, I just merged the fix so if your problem persists it must be something else.
Mentioned in SAL (#wikimedia-operations) [2018-05-17T19:28:58Z] <twentyafterfour@tin> Synchronized php-1.32.0-wmf.4/extensions/Echo/: unbreak T194848 (duration: 01m 24s)
@SBisson: I only reverted this on the branch so we need to do something about it on master or we'll be dealing with it again next week.
Of course I'll deal with this. Sorry for the inconvenience.
Lesson for me here: my mw-vagrant setup was NOT appropriate to test this.