Page MenuHomePhabricator
Create Task
Maniphest T196026

Sidebar sections empty in Timeless skin
Closed, ResolvedPublic
Actions

Description

This is not happening on Wikipedia.

Navigation is broken on Timeless. The buttons are blank where there is supposed to be content.

How it appears on Wiktionary:

Screenshot (57).png (1×2 px, 743 KB)

Details

SubjectRepoBranchLines +/-
Fix condition for 'emptyPortlet' classmediawiki/skins/Timelessmaster+1 -1
Fix condition for 'emptyPortlet' classmediawiki/skins/TimelessREL1_31+1 -1
Fix condition for 'emptyPortlet' classmediawiki/skins/Timelesswmf/1.32.0-wmf.6+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasethciprianiT191052 1.32.0-wmf.6 deployment blockers
 ResolvedmatmarexT196026 Sidebar sections empty in Timeless skin

Event Timeline

Awesome_Aasim created this task.May 30 2018, 10:01 PM
Legoktm added a parent task: T191052: 1.32.0-wmf.6 deployment blockers.May 30 2018, 10:07 PM
matmarex claimed this task.May 30 2018, 10:11 PM
gerritbot subscribed.May 30 2018, 10:13 PM

Change 436412 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Timeless@master] Fix condition for 'emptyPortlet' class

https://gerrit.wikimedia.org/r/436412

gerritbot added a project: Patch-For-Review.May 30 2018, 10:13 PM
gerritbot added a comment.May 30 2018, 10:17 PM

Change 436415 had a related patch set uploaded (by Krinkle; owner: Bartosz Dziewoński):
[mediawiki/skins/Timeless@wmf/1.32.0-wmf.6] Fix condition for 'emptyPortlet' class

https://gerrit.wikimedia.org/r/436415

gerritbot added a comment.May 30 2018, 10:21 PM

Change 436412 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Fix condition for 'emptyPortlet' class

https://gerrit.wikimedia.org/r/436412

gerritbot added a comment.May 30 2018, 10:27 PM

Change 436417 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Timeless@REL1_31] Fix condition for 'emptyPortlet' class

https://gerrit.wikimedia.org/r/436417

gerritbot added a comment.May 30 2018, 10:32 PM

Change 436415 merged by jenkins-bot:
[mediawiki/skins/Timeless@wmf/1.32.0-wmf.6] Fix condition for 'emptyPortlet' class

https://gerrit.wikimedia.org/r/436415

Stashbot subscribed.May 30 2018, 10:40 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-30T22:40:42Z] <thcipriani@tin> Synchronized php-1.32.0-wmf.6/skins/Timeless/includes/TimelessTemplate.php: [[gerrit:436415|Fix condition for "emptyPortlet" class]] T196026 (duration: 01m 21s)

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).May 30 2018, 11:00 PM
Krinkle renamed this task from Problem With Timeless Skin to Sidebar sections empty in Timeless skin.May 31 2018, 2:42 AM
Krinkle closed this task as Resolved.
Krinkle edited projects, added Regression; removed Patch-For-Review.
gerritbot added a comment.May 31 2018, 7:39 AM

Change 436417 merged by jenkins-bot:
[mediawiki/skins/Timeless@REL1_31] Fix condition for 'emptyPortlet' class

https://gerrit.wikimedia.org/r/436417

• Vvjjkkii renamed this task from Sidebar sections empty in Timeless skin to 5xbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed matmarex as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: matmarex; removed: gerritbot.
thcipriani renamed this task from 5xbaaaaaaa to Sidebar sections empty in Timeless skin.Jul 1 2018, 7:44 PM
thcipriani closed this task as Resolved.
thcipriani assigned this task to matmarex.
thcipriani updated the task description. (Show Details)
thcipriani removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, CheckUser.
thcipriani raised the priority of this task from High to Needs Triage.Jul 1 2018, 7:44 PM
thcipriani added a subscriber: gerritbot.
Izno removed a project: Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02).Jul 1 2018, 8:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL