Page MenuHomePhabricator
Create Task
Maniphest T196117

[Regression pre-wmf.7] Drop down for template search results appears to go over the dialog when the template description is too long and not wrapping
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Open VE
  2. Go to Insert>Template
  3. In the textfield type "cit.."

The drop down for search results appears to going over the template dialog that contains templates like citation needed/cite web/cite book/cite news/citation and all of them has long description and not wrapping.

Screen Shot 2018-05-31 at 3.03.37 PM.png (481×981 px, 106 KB)

Details

SubjectRepoBranchLines +/-
Match width of template lookupMenu to inputmediawiki/extensions/VisualEditormaster+9 -0
Allow menu config to be passed to LookupElementoojs/uimaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.May 31 2018, 10:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2018, 10:03 PM
gerritbot subscribed.Jun 1 2018, 2:07 PM

Change 436804 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Allow menu config to be passed to LookupElement

https://gerrit.wikimedia.org/r/436804

gerritbot added a project: Patch-For-Review.Jun 1 2018, 2:07 PM
matmarex subscribed.Jun 4 2018, 9:24 PM

This seems to be intentional and a result of T195257: Allow dropdown menus to autosize to larger than their handles.

gerritbot added a comment.Jun 4 2018, 9:31 PM

Change 436804 merged by jenkins-bot:
[oojs/ui@master] Allow menu config to be passed to LookupElement

https://gerrit.wikimedia.org/r/436804

• Deskana added a subscriber: Esanders.Jun 5 2018, 6:48 PM

Does this patch fix the problem? I'm confused why @matmarex said this was intentional then @Esanders fixed it? :-)

matmarex assigned this task to Esanders.Jun 6 2018, 9:23 PM
matmarex edited projects, added VisualEditor (Current work); removed Patch-For-Review, VisualEditor.

It definitely doesn't fix the problem yet, but the fix that Ed presumably wants to write probably involves passing some menu config to LookupElement, which is made possible by that patch.

matmarex moved this task from Incoming to In progress on the VisualEditor (Current work) board.Jun 6 2018, 9:23 PM

(I am guessing that we want to set a max-width or something. But I'm not sure what the desired behavior is exactly.)

Schnark subscribed.Jun 14 2018, 10:05 AM

No matter whether it is intentional or not, it certainly is buggy:

  1. Open the template dialog in de.wikipedia.org
  2. Type "a"

-> Menu larger than dialog (which might be intentional)

  1. Type another "a"

-> Menu smaller than input (which looks ugly)

  1. Type another "a"

-> No menu (which is correct)

  1. Delete the last "a"

-> Menu as large as input (which is inconsistent with 3)

  1. Delete the last "a"

-> Menu again as large as input (which is inconsistent with 2)

• Vvjjkkii renamed this task from [Regression pre-wmf.7] Drop down for template search results appears to go over the dialog when the template description is too long and not wrapping to mvbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii removed Esanders as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from mvbaaaaaaa to [Regression pre-wmf.7] Drop down for template search results appears to go over the dialog when the template description is too long and not wrapping.Jul 2 2018, 2:26 AM
CommunityTechBot assigned this task to Esanders.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
• Deskana triaged this task as Medium priority.Aug 17 2018, 9:29 AM
Esanders added a comment.Aug 24 2018, 12:55 PM

Yeah - this is a more complex fix that I imagined. I may just have to come up with a quick fix for this particular issue.

gerritbot added a comment.Aug 24 2018, 1:23 PM

Change 455163 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Match width of template lookupMenu to input

https://gerrit.wikimedia.org/r/455163

gerritbot added a project: Patch-For-Review.Aug 24 2018, 1:23 PM
Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Aug 24 2018, 1:24 PM
gerritbot added a comment.Sep 3 2018, 3:40 PM

Change 455163 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Match width of template lookupMenu to input

https://gerrit.wikimedia.org/r/455163

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 3 2018, 4:00 PM
Schnark added a comment.Sep 6 2018, 8:46 AM

Note that now the width of the lookupMenu is 2px to small (or something like that), probably the width of the border: The left edge is aligned with the input (both from the outside), but the right isn't.

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Sep 19 2018, 4:28 PM
Ryasmeen added a comment.EditedSep 20 2018, 9:32 PM

@Esanders: The drop down for template search looks perfect now. However, this is also happening for Category search drop down. I was thinking, this is gonna be a generic fix for all dropdown menus but probably not :) Is it possible to apply the same fix for that dropdown as well?

Screen Shot 2018-09-20 at 2.23.15 PM.png (455×765 px, 67 KB)

Ryasmeen moved this task from QA to Stalled/Waiting on the VisualEditor (Current work) board.Sep 20 2018, 9:43 PM
Esanders added a comment.Oct 2 2018, 4:46 PM

@Ryasmeen Can you file that as a separate task?

Ryasmeen added a comment.Oct 3 2018, 10:42 PM

@Esanders: Done! T206184

Ryasmeen added a project: Verified.Oct 3 2018, 10:43 PM
Ryasmeen moved this task from Stalled/Waiting to Product owner review on the VisualEditor (Current work) board.
Schnark mentioned this in T206192: Drop down for template search results too small by a few pixels.Oct 4 2018, 7:16 AM

I, too, filed a separate task for my comment: T206192

• Deskana closed this task as Resolved.Nov 1 2018, 1:41 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 1 2018, 1:41 PM
Schnark mentioned this in T220177: Width of suggestions for edit summaries doesn't match width of input.Apr 5 2019, 7:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits