Maniphest T196185

Drop $wgDBmysql5 from MediaWiki
Closed, ResolvedPublic
Actions

Description

Related to T194125, T196092, and discussion on IRC. This experimental setting controls passing SET NAMES=utf8 on connection, which isn't recommended if you're using the binary charset (what we're standardizing on).

We should remove this option from the installer, and then remove it from MediaWiki core. This has very clearly been marked as experimental, and doesn't need a deprecation period.

Remove from CLI installer for new installs (was never exposed via web installer). – MediaWiki 1.31
Deprecate the configuration variable. – MediaWiki 1.31
Remove the configuration variable. – MediaWiki 1.33
Remove the option from the rdbms library.

Details

Subject	Repo	Branch	Lines +/-
DefaultSettings: Remove deprecated $wgDBmysql5 from core	mediawiki/core	master	+2 -23
Deprecate $wgDBmysql5	mediawiki/core	REL1_31	+4 -0
Deprecate $wgDBmysql5	mediawiki/core	master	+4 -0
installer: Don't allow setting $wgDBmysql5	mediawiki/core	REL1_31	+1 -7
installer: Don't allow setting $wgDBmysql5	mediawiki/core	master	+1 -7

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T196185 Drop $wgDBmysql5 from MediaWiki
		Resolved		Legoktm	T117339 Why is `$wgDBmysql5 = false'` set by the installer?

Event Timeline

Legoktm created this task.Jun 1 2018, 6:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2018, 6:53 PM

Change 436843 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] installer: Don't allow setting $wgDBmysql5

https://gerrit.wikimedia.org/r/436843

gerritbot added a project: Patch-For-Review.Jun 1 2018, 6:57 PM

Krinkle updated the task description. (Show Details)Jun 1 2018, 9:16 PM

Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.

Krinkle edited projects, added Technical-Debt, MediaWiki-Installer; removed MediaWiki-Configuration.

Krinkle moved this task from General to In progress on the MediaWiki-Installer board.

Krinkle moved this task from Unsorted to Needs removal on the Technical-Debt board.

Krinkle triaged this task as Medium priority.Jun 1 2018, 9:18 PM

Krinkle added a project: Performance-Team (Radar).

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.

Change 436843 merged by jenkins-bot:
[mediawiki/core@master] installer: Don't allow setting $wgDBmysql5

https://gerrit.wikimedia.org/r/436843

Change 436909 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@REL1_31] installer: Don't allow setting $wgDBmysql5

https://gerrit.wikimedia.org/r/436909

Change 436909 merged by jenkins-bot:
[mediawiki/core@REL1_31] installer: Don't allow setting $wgDBmysql5

https://gerrit.wikimedia.org/r/436909

ReleaseTaggerBot added projects: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), MW-1.31-release-notes.Jun 1 2018, 10:01 PM

Legoktm updated the task description. (Show Details)Jun 2 2018, 2:20 AM

Krinkle removed a project: Patch-For-Review.Jun 2 2018, 9:29 PM

Krinkle updated the task description. (Show Details)Jun 2 2018, 9:33 PM

Krinkle added projects: MW-1.31-release, MW-1.32-release.

Krinkle removed projects: MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).

Change 437312 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] Deprecate $wgDBmysql5

https://gerrit.wikimedia.org/r/437312

gerritbot added a project: Patch-For-Review.Jun 4 2018, 8:35 PM

Change 437312 merged by jenkins-bot:
[mediawiki/core@master] Deprecate $wgDBmysql5

https://gerrit.wikimedia.org/r/437312

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 4 2018, 9:01 PM

Change 437368 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@REL1_31] Deprecate $wgDBmysql5

https://gerrit.wikimedia.org/r/437368

Change 437368 merged by jenkins-bot:
[mediawiki/core@REL1_31] Deprecate $wgDBmysql5

https://gerrit.wikimedia.org/r/437368

Legoktm removed a project: MW-1.31-release.Jun 4 2018, 10:18 PM

Legoktm updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.31-release-notes.Jun 4 2018, 11:00 PM

I have this option set in my LocalSettings.php. How do I migrate away from it before the setting is removed?

In T196185#4270746, @Prod wrote:

I have this option set in my LocalSettings.php. How do I migrate away from it before the setting is removed?

Most likely, you will not have to do anything. The setting being removed by this task only affects the connection, not the schema. Thus no migration is required.

However, to be sure, let us know, what value do you have for $wgDBTableOptions?

In T196185#4284484, @Krinkle wrote:

In T196185#4270746, @Prod wrote:

I have this option set in my LocalSettings.php. How do I migrate away from it before the setting is removed?

Most likely, you will not have to do anything. The setting being removed by this task only affects the connection, not the schema. Thus no migration is required.

However, to be sure, let us know, what value do you have for $wgDBTableOptions?

Currently set as
$wgDBTableOptions = "ENGINE=InnoDB, DEFAULT CHARSET=binary";

In T196185#4284496, @Prod wrote:

In T196185#4284484, @Krinkle wrote:

Most likely, you will not have to do anything. [..]
However, to be sure, let us know, what value do you have for $wgDBTableOptions?

Currently set as
$wgDBTableOptions = "ENGINE=InnoDB, DEFAULT CHARSET=binary";

Then you'll be fine. It just means that between MediaWiki PHP and MySQL, the connection will internally use a slightly different encoding, but it shouldn't change anything for the wiki or the users.

To confirm this, try disabling your wgDBmysql5 setting (e.g. set $wgDBmysql5 = false;, or comment it out like # $wgDBmysql5 = true;), and verify that no errors appear.

• Vvjjkkii renamed this task from Drop $wgDBmysql5 from MediaWiki to qtbaaaaaaa.Jul 1 2018, 1:06 AM

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from qtbaaaaaaa to Drop $wgDBmysql5 from MediaWiki.Jul 2 2018, 1:44 PM

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

Krinkle edited projects, added Technical-Debt (Deprecation process); removed MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Patch-For-Review, Technical-Debt.Jul 13 2018, 11:09 PM

Krinkle moved this task from Untriaged to 2018 | MW 1.31 / 1.32 on the Technical-Debt (Deprecation process) board.

Legoktm moved this task from Backlog to Deprecations on the MW-1.32-release board.Oct 9 2018, 12:41 AM

Seb35 mentioned this in T117339: Why is `$wgDBmysql5 = false'` set by the installer?.Nov 22 2018, 3:52 PM

Seb35 added a subtask: T117339: Why is `$wgDBmysql5 = false'` set by the installer?.

Bumping to 1.33 since we didn't get this done in time.

Krinkle updated the task description. (Show Details)Dec 20 2018, 10:38 PM

Krinkle moved this task from 2018 | MW 1.31 / 1.32 to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation process) board.

Change 498644 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] DefaultSettings: Remove deprecated $wgDBmysql5 from core

https://gerrit.wikimedia.org/r/498644

gerritbot added a project: Patch-For-Review.Mar 23 2019, 1:44 PM

Change 498644 merged by jenkins-bot:
[mediawiki/core@master] DefaultSettings: Remove deprecated $wgDBmysql5 from core

https://gerrit.wikimedia.org/r/498644

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Mar 25 2019, 3:01 PM

xSavitar updated the task description. (Show Details)Mar 25 2019, 3:19 PM

Krinkle closed this task as Resolved.Mar 28 2019, 7:52 PM

Krinkle removed projects: MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM