Page MenuHomePhabricator
Create Task
Maniphest T196711

Add a Help link to maps tool in Visual Editor
Closed, ResolvedPublic
Actions

Assigned To
SBisson
Authored By
• jmatazzoni
Jun 7 2018, 11:03 PM
Tags
Referenced Files
F22656217: Screen Shot 2018-06-25 at 5.06.19 PM.png
Jun 26 2018, 12:19 AM
F22656226: Screen Shot 2018-06-25 at 5.17.58 PM.png
Jun 26 2018, 12:19 AM
F22143699: Map-editor-help.png
Jun 12 2018, 1:04 PM
F18964057: Screen Shot 2018-06-07 at 3.46.16 PM.png
Jun 7 2018, 11:09 PM
Subscribers
Aklapper
CKoerner_WMF
Etonkovidova
gerritbot
• jmatazzoni
Mooeypoo
Pginer-WMF
View All 10 Subscribers

Description

The maps tools in Visual Editor are somewhat idiosyncratic. Plus, since the VE maps tools offer only limited functions, it's likely that map users will want to edit the code directly in order to customize their VE maps (by, say, changing the color r size of the generic gray marker VE places). To assist them, we will place a Help icon in the maps VE interface that links to the maps Help page.

Screen Shot 2018-06-07 at 3.46.16 PM.png (973×976 px, 289 KB)

Details

SubjectRepoBranchLines +/-
Add help link to VE maps editormediawiki/extensions/Kartographermaster+21 -0
Customize query in gerrit

Related Objects

Event Timeline

• jmatazzoni triaged this task as Low priority.Jun 7 2018, 11:03 PM
• jmatazzoni created this task.
• jmatazzoni added a comment.Jun 7 2018, 11:05 PM

@CKoerner_WMF, Although my intention is actually to expose the full range of maps functions to VE users, I suppose we should link people directly to the part of your Help doc that is about VE. Please sub in that link address above when you have it.

• jmatazzoni updated the task description. (Show Details)Jun 7 2018, 11:09 PM
• jmatazzoni added a subscriber: Pginer-WMF.

@Pginer-WMF, can you please update my mockup above and let people know what the proper position, size, etc. of the help icon should be? Thanks.

• jmatazzoni moved this task from Untriaged to Snack Box on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 7 2018, 11:10 PM
• jmatazzoni mentioned this in Collaboration-Team-Triage (Collab-Team-This-Quarter).
Pginer-WMF added a subscriber: Volker_E.Jun 12 2018, 1:04 PM
In T196711#4266205, @jmatazzoni wrote:

@Pginer-WMF, can you please update my mockup above and let people know what the proper position, size, etc. of the help icon should be? Thanks.

In terms of position we want to communicate the help is related to the whole panel, not about one specific part such as the size fields. Anchoring it to the top-right corner can help with that.

Regarding the icon, we should use the "help" icon from the icon repo which is the standard icon available for this purpose. It is still in the process of getting updated based on my conversations with @Volker_E. So it will look as a simple "?" until it gets updated to look closer to the mockup.

The icon will be applied at the standard size of 20x20px.

Map-editor-help.png (973×976 px, 279 KB)

• jmatazzoni updated the task description. (Show Details)Jun 14 2018, 4:35 PM
SBisson subscribed.Jun 19 2018, 8:51 PM

What should the final URL be?

The link in the description goes to User:CKoerner_(WMF)/Visual_editor_maps. It looks good but maybe incomplete judging by the last sentence on the page.

gerritbot subscribed.Jun 19 2018, 8:53 PM

Change 441136 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Kartographer@master] [WIP] Add help link to VE maps editor

https://gerrit.wikimedia.org/r/441136

gerritbot added a project: Patch-For-Review.Jun 19 2018, 8:53 PM
SBisson claimed this task.Jun 19 2018, 8:53 PM
SBisson moved this task from Snack Box to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Jun 20 2018, 4:08 PM
CKoerner_WMF added a comment.Jun 20 2018, 4:15 PM
In T196711#4300904, @SBisson wrote:

What should the final URL be?

The link in the description goes to User:CKoerner_(WMF)/Visual_editor_maps. It looks good but maybe incomplete judging by the last sentence on the page.

YEs, that is the draft. The eventual home will be a section on this page: https://www.mediawiki.org/wiki/Help:Extension:Kartographer

• jmatazzoni updated the task description. (Show Details)Jun 22 2018, 5:07 PM

@SBisson, I have updated the Help URL above to one that is in Mediawiki, instead of Chris's user space. So you should be able to complete this task now. For your convenience, the URL is:

https://www.mediawiki.org/wiki/Help:VisualEditor/Maps

SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 22 2018, 5:54 PM
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 25 2018, 4:44 PM
gerritbot added a comment.Jun 25 2018, 4:44 PM

Change 441136 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Add help link to VE maps editor

https://gerrit.wikimedia.org/r/441136

Etonkovidova subscribed.Jun 26 2018, 12:19 AM

Checked in betalabs (disregard non-displayed map in the screenshot below)

Screen Shot 2018-06-25 at 5.06.19 PM.png (505×1 px, 50 KB)

Screen Shot 2018-06-25 at 5.17.58 PM.png (223×917 px, 29 KB)

The link will re-direct to https://www.mediawiki.org/wiki/Help:VisualEditor/Maps.

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 26 2018, 12:19 AM
• jmatazzoni closed this task as Resolved.Jun 26 2018, 3:32 PM

Resolving this, but @Volker_E I continue to have a bad reaction to the ? with no circle around it. As previously discussed, it looks too much like a piece of punctuation and not enough like an icon. Is there a plan to revise this (please)?

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 26 2018, 3:32 PM
Volker_E added a comment.Jun 26 2018, 3:37 PM

@jmatazzoni Sorry, didn't mean to take that long to make it into OOUI. As soon as the circled icon is available, I'll pick this up in a follow-up patch.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 4:01 PM
• Vvjjkkii renamed this task from Add a Help link to maps tool in Visual Editor to 4ebaaaaaaa.Jul 1 2018, 1:05 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed SBisson as the assignee of this task.
• Vvjjkkii raised the priority of this task from Low to High.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 4ebaaaaaaa to Add a Help link to maps tool in Visual Editor.Jul 2 2018, 12:53 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to SBisson.
CommunityTechBot lowered the priority of this task from High to Low.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits