Page MenuHomePhabricator
Create Task
Maniphest T196971

ProofreadPage is relying on $wgTitle fallback in EditPage
Closed, ResolvedPublic
Actions

Description

legoktm@mwlog1001:/srv/mw-log/archive$ zgrep "::getContextTitle" GlobalTitleFail.log-20180611.gz 
2018-06-10 07:57:37 [WxzZ8QpAME4AAKaItQ0AAAAO] mw1243 frwikisource 1.32.0-wmf.7 GlobalTitleFail INFO: EditPage::getContextTitle called by EditPage->edit/EditPage->showEditForm/EditPage->showStandardInputs/EditPage->getCancelLink/EditPage->getContextTitle with no title set.  
2018-06-10 11:32:36 [Wx0MVApAICsAAHzyZ@sAAACG] mw1322 enwikisource 1.32.0-wmf.7 GlobalTitleFail INFO: EditPage::getContextTitle called by ProofreadPage\Page\PageEditAction->show/EditPage->edit/EditPage->showEditForm/EditPage->setHeaders/EditPage->getContextTitle with no title set.  
2018-06-10 11:44:06 [Wx0PBgpAIC4AACpNmKwAAACE] mw1325 enwikisource 1.32.0-wmf.7 GlobalTitleFail INFO: EditPage::getContextTitle called by EditPage->edit/EditPage->showEditForm/EditPage->showStandardInputs/EditPage->getCancelLink/EditPage->getContextTitle with no title set.  
2018-06-10 19:02:42 [Wx110QpAAEMAAAGufZIAAAAJ] mw1272 frwikisource 1.32.0-wmf.7 GlobalTitleFail INFO: EditPage::getContextTitle called by EditPage->edit/EditPage->showEditForm/EditPage->showStandardInputs/EditPage->getCancelLink/EditPage->getContextTitle with no title set.

Patch incoming.

Details

SubjectRepoBranchLines +/-
Set EditPage's context Title in Edit/SubmitAction classesmediawiki/extensions/ProofreadPagemaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm triaged this task as Medium priority.Jun 12 2018, 8:39 AM
Legoktm created this task.
gerritbot subscribed.Jun 12 2018, 8:40 AM

Change 439853 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ProofreadPage@master] Set EditPage's context Title in Edit/SubmitAction classes

https://gerrit.wikimedia.org/r/439853

gerritbot added a project: Patch-For-Review.Jun 12 2018, 8:40 AM
gerritbot added a comment.Jun 12 2018, 8:45 AM

Change 439853 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Set EditPage's context Title in Edit/SubmitAction classes

https://gerrit.wikimedia.org/r/439853

Legoktm closed this task as Resolved.Jun 12 2018, 8:48 AM
Legoktm added a subscriber: Tpt.

Thank you for being super fast @Tpt :-)

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 12 2018, 9:00 AM
• Vvjjkkii renamed this task from ProofreadPage is relying on $wgTitle fallback in EditPage to w7aaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Legoktm as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Xiplus renamed this task from w7aaaaaaaa to ProofreadPage is relying on $wgTitle fallback in EditPage.Jul 1 2018, 1:56 AM
Xiplus closed this task as Resolved.Jul 1 2018, 2:01 AM
Xiplus assigned this task to Legoktm.
Xiplus lowered the priority of this task from High to Medium.
Xiplus removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Xiplus updated the task description. (Show Details)
Xiplus added subscribers: Aklapper, gerritbot.
Billinghurst mentioned this in T199288: For anonymous users the Index namespace pages are not displaying "page status" in desktop view ($wgTitle not set in GetLinkColours hook).Jul 17 2018, 9:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits