Page MenuHomePhabricator
Create Task
Maniphest T176526

Remove $wgTitle fallback from EditPage in MW1.36
Closed, ResolvedPublic
Actions

Description

EditPage.php
	public function getContextTitle() {
		if ( is_null( $this->mContextTitle ) ) {
			wfDebugLog(
				'GlobalTitleFail',
				__METHOD__ . ' called by ' . wfGetAllCallers( 5 ) . ' with no title set.'
			);
			global $wgTitle;
			return $wgTitle;
		} else {
			return $this->mContextTitle;
		}
	}
RELEASE-NOTES-1.30
* Creating an EditPage instance without calling EditPage::setContextTitle() should
  be avoided and will be deprecated in a future release.
RELEASE-NOTES-1.32
* (T176526) EditPage::getContextTitle() falling back to $wgTitle when the
  context title is unset is now deprecated; anything creating an EditPage
  instance should set the context title via ::setContextTitle().

rMW5cd20435dc1a: EditPage: Try to avoid using $wgTitle

Once that rolls out, we should check the logs, deprecate and eventually remove the $wgTitle fallback.

Details

SubjectRepoBranchLines +/-
Throw exception if EditPage has no context title setmediawiki/coremaster+5 -6
Ensure we always call EditPage::setContextTitle() when creating a new EditPagemediawiki/extensions/LiquidThreadsmaster+4 -0
Use AlternateEdit hook to override EditPage::$contentFormatmediawiki/extensions/JsonConfigmaster+12 -21
EditPage: Include class name ::getContextTitle() deprecation warningmediawiki/coremaster+1 -1
Directly use $wgTitle instead of relying on getContextTitle fallbackmediawiki/extensions/CodeEditormaster+6 -3
EditPage: Remove $wgTitle global fallback from EditPagemediawiki/coremaster+5 -11
EditPage: Remove $wgTitle fallback from MW 1.33mediawiki/coremaster+2 -10
EditPage::getContextTitle(): Deprecate falling back to $wgTitlemediawiki/coremaster+7 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Sep 22 2017, 9:36 PM
Legoktm mentioned this in T14710: Classes like Parser should use $mTitle member rather than $wgTitle.
Legoktm mentioned this in T144366: De-globalize EditPage.php and use RequestContext instead.
Jdforrester-WMF subscribed.Sep 22 2017, 9:51 PM
Legoktm added a comment.Jun 12 2018, 7:45 AM
legoktm@mwlog1001:/srv/mw-log/archive$ zgrep "::getContextTitle" GlobalTitleFail.log-20180611.gz 
2018-06-10 07:57:37 [WxzZ8QpAME4AAKaItQ0AAAAO] mw1243 frwikisource 1.32.0-wmf.7 GlobalTitleFail INFO: EditPage::getContextTitle called by EditPage->edit/EditPage->showEditForm/EditPage->showStandardInputs/EditPage->getCancelLink/EditPage->getContextTitle with no title set.  
2018-06-10 11:32:36 [Wx0MVApAICsAAHzyZ@sAAACG] mw1322 enwikisource 1.32.0-wmf.7 GlobalTitleFail INFO: EditPage::getContextTitle called by ProofreadPage\Page\PageEditAction->show/EditPage->edit/EditPage->showEditForm/EditPage->setHeaders/EditPage->getContextTitle with no title set.  
2018-06-10 11:44:06 [Wx0PBgpAIC4AACpNmKwAAACE] mw1325 enwikisource 1.32.0-wmf.7 GlobalTitleFail INFO: EditPage::getContextTitle called by EditPage->edit/EditPage->showEditForm/EditPage->showStandardInputs/EditPage->getCancelLink/EditPage->getContextTitle with no title set.  
2018-06-10 19:02:42 [Wx110QpAAEMAAAGufZIAAAAJ] mw1272 frwikisource 1.32.0-wmf.7 GlobalTitleFail INFO: EditPage::getContextTitle called by EditPage->edit/EditPage->showEditForm/EditPage->showStandardInputs/EditPage->getCancelLink/EditPage->getContextTitle with no title set.

This only happens on wikis with ProofreadPage enabled seemingly.

Legoktm closed subtask T196971: ProofreadPage is relying on $wgTitle fallback in EditPage as Resolved.Jun 12 2018, 8:48 AM
gerritbot subscribed.Jun 12 2018, 5:45 PM

Change 439988 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] EditPage::getContextTitle(): Deprecate falling back to $wgTitle

https://gerrit.wikimedia.org/r/439988

gerritbot added a project: Patch-For-Review.Jun 12 2018, 5:45 PM
gerritbot added a comment.Jun 14 2018, 3:39 PM

Change 439988 merged by jenkins-bot:
[mediawiki/core@master] EditPage::getContextTitle(): Deprecate falling back to $wgTitle

https://gerrit.wikimedia.org/r/439988

Legoktm updated the task description. (Show Details)Jun 14 2018, 3:43 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 14 2018, 4:00 PM
Jdforrester-WMF changed the task status from Open to Stalled.Jun 14 2018, 4:59 PM
Jdforrester-WMF removed a project: Patch-For-Review.

Now deprecated; removal is Stalled awaiting MW1.33.

Aklapper renamed this task from Remove $wgTitle fallback from EditPage to Remove $wgTitle fallback from EditPage in MW1.33.Jun 15 2018, 10:35 AM
• Vvjjkkii reopened subtask T196971: ProofreadPage is relying on $wgTitle fallback in EditPage as Open.Jul 1 2018, 1:04 AM
Xiplus closed subtask T196971: ProofreadPage is relying on $wgTitle fallback in EditPage as Resolved.Jul 1 2018, 2:01 AM
BethNaught subscribed.Aug 29 2018, 9:39 AM
Legoktm edited projects, added MW-1.33-release; removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Sep 12 2018, 5:31 AM
Krinkle changed the task status from Stalled to Open.Mar 8 2019, 2:07 AM
Krinkle subscribed.

0 results for +channel:GlobalTitleFail AND "getContextTitle" over the last 30 days in WMF Logstash.

Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Mar 8 2019, 2:09 AM
Krinkle moved this task from Untriaged to 2017 | MW 1.29 / 1.30 on the Technical-Debt (Deprecation process) board.
gerritbot added a comment.Mar 23 2019, 1:16 PM

Change 498640 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] Remove $wgTitle fallback from MW 1.33

https://gerrit.wikimedia.org/r/498640

gerritbot added a project: Patch-For-Review.Mar 23 2019, 1:16 PM
Krinkle moved this task from Backlog to Deprecate/Remove on the MW-1.33-release board.Apr 12 2019, 2:08 AM
xSavitar moved this task from 2017 | MW 1.29 / 1.30 to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation process) board.Apr 26 2019, 3:07 PM
xSavitar edited projects, added MW-1.34-release; removed MW-1.33-release.
xSavitar subscribed.

We missed 1.33, so moved to 1.34 and will fix the patch to conform.

xSavitar renamed this task from Remove $wgTitle fallback from EditPage in MW1.33 to Remove $wgTitle fallback from EditPage in MW1.34.Apr 26 2019, 3:09 PM
gerritbot added a comment.Apr 26 2019, 3:24 PM

Change 498640 abandoned by D3r1ck01:
EditPage: Remove $wgTitle fallback from MW 1.33

Reason:
Made I51e0a4b7f8e2441bdd5f5fe98d20175ea79072dc instead.

https://gerrit.wikimedia.org/r/498640

gerritbot added a comment.Apr 26 2019, 3:25 PM

Change 506695 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] EditPage: Remove $wgTitle global fallback from EditPage

https://gerrit.wikimedia.org/r/506695

xSavitar claimed this task.Apr 26 2019, 3:44 PM
Restricted Application added a project: User-xSavitar. · View Herald TranscriptApr 26 2019, 3:44 PM
xSavitar moved this task from Backlog to Under Review on the User-xSavitar board.Apr 26 2019, 3:45 PM
xSavitar moved this task from Under Review to Doing [WIP] on the User-xSavitar board.Apr 30 2019, 8:27 AM
Krinkle moved this task from Blocker to Deprecate/Remove on the MW-1.34-release board.May 6 2019, 4:56 PM
xSavitar removed xSavitar as the assignee of this task.May 18 2019, 2:56 PM
xSavitar removed a project: User-xSavitar.
gerritbot added a comment.Jun 24 2019, 12:09 PM

Change 506695 abandoned by D3r1ck01:
EditPage: Remove $wgTitle global fallback from EditPage

https://gerrit.wikimedia.org/r/506695

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2019, 12:11 PM
Nikerabbit added a subtask: T227773: [LiquidThreads] Use of EditPage::getContextTitle called with no title set was deprecated in MediaWiki 1.32.Jul 11 2019, 1:25 PM
Jdforrester-WMF added a comment.Sep 5 2019, 9:22 PM

Hey there, should this be moved to 1.35? The cut is a couple of weeks away. If it needs to go out in 1.34, is there anything I can do to help get it out of the door?

Daimona subscribed.Sep 27 2019, 3:04 PM

Apparently, the main source of warnings is CodeEditorHooks::editPageShowEditFormInitial. I wonder if that method should be changed to just use $wgTitle, since that's what it's already doing under the hood.

Jdforrester-WMF added a comment.Sep 30 2019, 5:10 PM
In T176526#5529785, @Daimona wrote:

Apparently, the main source of warnings is CodeEditorHooks::editPageShowEditFormInitial. I wonder if that method should be changed to just use $wgTitle, since that's what it's already doing under the hood.

Lovely. Yes, just kill it in CodeEditor.

gerritbot added a comment.Sep 30 2019, 5:29 PM

Change 539922 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/CodeEditor@master] Directly use $wgTitle instead of relying on getContextTitle fallback

https://gerrit.wikimedia.org/r/539922

gerritbot added a project: Patch-For-Review.Sep 30 2019, 5:29 PM
gerritbot added a comment.Sep 30 2019, 6:48 PM

Change 539922 merged by jenkins-bot:
[mediawiki/extensions/CodeEditor@master] Directly use $wgTitle instead of relying on getContextTitle fallback

https://gerrit.wikimedia.org/r/539922

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 30 2019, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 30 2019, 7:10 PM
Krinkle edited projects, added MW-1.35-release; removed MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.34-release.Nov 6 2019, 12:37 AM

Moving to next milestone. There have been two release candidates for 1.34 already. Seems a bit late to backport removal if and when it gets drafted.

Krinkle moved this task from Blocker to To deprecate or remove on the MW-1.35-release board.Nov 6 2019, 12:55 AM
Daimona added a comment.Jan 1 2020, 1:29 PM

I note that we have many instances of this warning on logstash (500 in the past 24 hours). Unfortunately, wfDeprecated's logging is completely useless. It just says

Called from EditPage::setHeaders

or

Called from EditPage::displayViewSourcePage

but it doesn't say what the actual caller (i.e. outside of EditPage) is.

gerritbot added a comment.Jan 1 2020, 11:21 PM

Change 561386 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] EditPage: Include class name ::getContextTitle() deprecation warning

https://gerrit.wikimedia.org/r/561386

gerritbot added a project: Patch-For-Review.Jan 1 2020, 11:21 PM
gerritbot added a comment.Jan 1 2020, 11:37 PM

Change 561386 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Include class name ::getContextTitle() deprecation warning

https://gerrit.wikimedia.org/r/561386

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Jan 2 2020, 12:00 AM
gerritbot added a comment.Jan 2 2020, 12:05 AM

Change 561392 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/LiquidThreads@master] Ensure we always call EditPage::setContextTitle() when creating a new EditPage

https://gerrit.wikimedia.org/r/561392

gerritbot added a comment.Jan 2 2020, 6:19 AM

Change 561439 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/JsonConfig@master] Use AlternateEdit hook to override EditPage::$contentFormat

https://gerrit.wikimedia.org/r/561439

Legoktm added a comment.Jan 2 2020, 6:29 AM
In T176526#5769217, @Daimona wrote:

I note that we have many instances of this warning on logstash (500 in the past 24 hours). Unfortunately, wfDeprecated's logging is completely useless. It just says

Called from EditPage::setHeaders

or

Called from EditPage::displayViewSourcePage

but it doesn't say what the actual caller (i.e. outside of EditPage) is.

I recommend looking at the URL field too, usually it gives a hint as to what extension or code path is being called to ease searching...which is how I found LQT and JsonConfig.

Based on https://codesearch.wmflabs.org/search/?q=new%20(%5C%5C)%3FEditPage&i=nope&files=&repos= those look like the only remaining Wikimedia-deployed stuff.

Daimona added a comment.Jan 2 2020, 10:20 AM
In T176526#5770074, @Legoktm wrote:

I recommend looking at the URL field too, usually it gives a hint as to what extension or code path is being called to ease searching...which is how I found LQT and JsonConfig.

Thanks. I noted that various requests where on the Data: namespace, but I don't know what it's for...

gerritbot added a comment.Jan 3 2020, 1:29 PM

Change 561439 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Use AlternateEdit hook to override EditPage::$contentFormat

https://gerrit.wikimedia.org/r/561439

Jdforrester-WMF renamed this task from Remove $wgTitle fallback from EditPage in MW1.34 to Remove $wgTitle fallback from EditPage in MW1.35.Jan 6 2020, 6:45 PM
gerritbot added a comment.Jan 8 2020, 12:44 AM

Change 561392 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Ensure we always call EditPage::setContextTitle() when creating a new EditPage

https://gerrit.wikimedia.org/r/561392

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.15; 2020-01-14); removed MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Jan 8 2020, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 8 2020, 1:10 AM
Legoktm closed subtask T227773: [LiquidThreads] Use of EditPage::getContextTitle called with no title set was deprecated in MediaWiki 1.32 as Resolved.Jul 13 2020, 10:08 PM

I think we're set to do this, but this is notoriously hard to debug, so I'd rather push this to 1.36 and merge after the branch cut.

Legoktm renamed this task from Remove $wgTitle fallback from EditPage in MW1.35 to Remove $wgTitle fallback from EditPage in MW1.36.Jul 13 2020, 10:09 PM
Legoktm edited projects, added MW-1.36-release; removed MW-1.35-release.
gerritbot added a comment.Jul 13 2020, 10:12 PM

Change 612428 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] Throw exception if EditPage has no context title set

https://gerrit.wikimedia.org/r/612428

gerritbot added a project: Patch-For-Review.Jul 13 2020, 10:12 PM
Legoktm claimed this task.Jul 15 2020, 4:30 AM
Multichill mentioned this in T259100: test_content_format paraminfo_tests fail at test-wiki.Aug 2 2020, 11:27 AM
gerritbot added a comment.Sep 15 2020, 1:33 PM

Change 612428 merged by jenkins-bot:
[mediawiki/core@master] Throw exception if EditPage has no context title set

https://gerrit.wikimedia.org/r/612428

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 15 2020, 2:00 PM
Jdforrester-WMF closed this task as Resolved.Sep 15 2020, 3:05 PM
Legoktm mentioned this in T277362: Deprecation warning client-repo wikitext link.Mar 16 2021, 9:45 PM
ashley mentioned this in rETMCecf9c2401092: Call EditPage#setContextTitle after constructing a new EditPage instance to….Jun 1 2021, 9:12 AM
Eats_Zaku_Burgers mentioned this in T352623: EditPage does not have a context title set.Dec 3 2023, 9:07 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 3 2023, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL