Page MenuHomePhabricator
Create Task
Maniphest T197064

In mobile skins, Echo callout displays whitespace instead of notifications
Closed, ResolvedPublic
Actions

Description

See screenshot below. This only happens in the mobile view. Reproducible on desktop by making the browser width narrow enough (or using responsive design mode in dev tools).
The problem seems to be that the <div> with classes oo-ui-clippableElement-clippable oo-ui-popupWidget-body has an inline style width: 0px.

timeless empty notifications.png (570×322 px, 4 KB)

Details

SubjectRepoBranchLines +/-
Display notifications in echo callout for mobile viewmediawiki/skins/Timelessmaster+25 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Evad37 created this task.Jun 13 2018, 6:54 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 13 2018, 6:54 AM
gerritbot subscribed.Jun 23 2018, 9:24 AM

Change 441590 had a related patch set uploaded (by Evad37; owner: Evad37):
[mediawiki/skins/Timeless@master] Display notifications in echo callout for mobile view

https://gerrit.wikimedia.org/r/441590

gerritbot added a project: Patch-For-Review.Jun 23 2018, 9:24 AM
Evad37 added a parent task: T173152: Timeless: Usability issues on mobile devices.Jun 23 2018, 10:02 AM
RileyBugz moved this task from Backlog to Bugs on the Timeless board.Jun 23 2018, 4:58 PM
JTannerWMF edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Jun 26 2018, 6:31 PM
JTannerWMF moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Etonkovidova removed a project: Collaboration-Team-Triage (Collab-Team-This-Quarter).Jun 29 2018, 6:45 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 29 2018, 6:45 PM
• Vvjjkkii renamed this task from Timeless: In mobile view, Echo callout displays whitespace instead of notifications to b5aaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: gerritbot.
CommunityTechBot renamed this task from b5aaaaaaaa to Timeless: In mobile view, Echo callout displays whitespace instead of notifications.Jul 2 2018, 1:59 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: gerritbot.
gerritbot added a comment.Jul 18 2018, 5:16 PM

Change 441590 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Display notifications in echo callout for mobile view

https://gerrit.wikimedia.org/r/441590

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 5:16 PM
JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 18 2018, 6:31 PM
SBisson moved this task from Needs Discussion to External on the Growth-Team board.Jul 20 2018, 6:21 PM
Isarra renamed this task from Timeless: In mobile view, Echo callout displays whitespace instead of notifications to In mobile skins, Echo callout displays whitespace instead of notifications.Jul 21 2018, 1:09 PM
Isarra removed a project: Timeless.
Isarra edited projects, added OOUI; removed Growth-Team, Patch-For-Review.
Isarra subscribed.

Fixed for timeless in the above patch.

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 21 2018, 1:10 PM
Volker_E closed this task as Resolved.Aug 21 2018, 9:30 PM
Volker_E assigned this task to Evad37.
Volker_E subscribed.

This is no issue in MinervaNeue due to different notifications handling.

Lens0021 subscribed.Jul 17 2019, 3:52 AM
Lens0021 added a comment.Nov 17 2019, 7:15 AM

I think even though Wikimedia wikis use MinervaNeue, It is still a problem to solve of OOUI or of maybe OO.ui.PopupWidget I think.

Lens0021 added a comment.May 28 2021, 7:18 AM

I think this is solved in T258939.

Lens0021 added a comment.May 28 2021, 7:30 AM
In T197064#7121666, @Lens0021 wrote:

I think this is solved in T258939.

Sorry, it was T241090.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits