Page MenuHomePhabricator
Create Task
Maniphest T241090

Echo rendering issues on desktop Minerva, not usable on mobile
Closed, ResolvedPublic
Actions

Assigned To
Etonkovidova
Authored By
Jdlrobson
Dec 18 2019, 10:47 PM
Tags
Referenced Files
F31499645: Screen Shot 2020-01-03 at 12.10.54 PM.png
Jan 3 2020, 11:33 PM
F31499648: Screen Shot 2020-01-03 at 12.10.32 PM.png
Jan 3 2020, 11:33 PM
F31499652: Screen Shot 2020-01-02 at 4.09.14 PM.png
Jan 3 2020, 11:33 PM
F31499650: Screen Shot 2020-01-02 at 4.15.34 PM.png
Jan 3 2020, 11:33 PM
F31481151: Screen Shot 2019-12-18 at 2.46.31 PM.png
Dec 18 2019, 10:47 PM
F31481148: Screen Shot 2019-12-18 at 2.45.32 PM.png
Dec 18 2019, 10:47 PM
Subscribers
Aklapper
• Esanders
Etonkovidova
Jdlrobson
Masumrezarock100

Description

There are 2 problems with Echo on desktop Minerva (https://www.mediawiki.org/w/index.php?title=Readers&useskin=minerva)

  1. Icon becomes misaligned on click

Screen Shot 2019-12-18 at 2.45.32 PM.png (246×420 px, 8 KB)

  1. On mobile resolution the notifications disappear

Screen Shot 2019-12-18 at 2.46.31 PM.png (944×682 px, 49 KB)

Details

SubjectRepoBranchLines +/-
Properly scoped style improvements to Echo OOUI dialog in desktop Minervamediawiki/extensions/Echomaster+49 -1
Revert "Style improvements to Echo OOUI dialog in desktop Minerva"mediawiki/extensions/Echomaster+1 -47
Style improvements to Echo OOUI dialog in desktop Minervamediawiki/extensions/Echomaster+47 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Dec 18 2019, 10:47 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 18 2019, 10:47 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
gerritbot added a comment.Dec 18 2019, 10:47 PM

Change 541992 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Echo@master] Style improvements to Echo OOUI dialog in desktop Minerva

https://gerrit.wikimedia.org/r/541992

gerritbot added a project: Patch-For-Review.Dec 18 2019, 10:47 PM
gerritbot added a comment.Dec 20 2019, 10:41 PM

Change 541992 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Style improvements to Echo OOUI dialog in desktop Minerva

https://gerrit.wikimedia.org/r/541992

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 20 2019, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 20 2019, 11:10 PM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jan 3 2020, 10:42 AM
kostajh moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh mentioned this in T223609: Notifications load slowly in Firefox when using Vector on an Android phone.
Etonkovidova subscribed.Jan 3 2020, 11:33 PM
  1. The alignment has been improved (due to the nature of the image, the alignment is perceived as a little bit off).

Screen Shot 2020-01-03 at 12.10.54 PM.png (101×441 px, 8 KB)

Screen Shot 2020-01-02 at 4.09.14 PM.png (266×544 px, 36 KB)

Screen Shot 2020-01-03 at 12.10.32 PM.png (243×522 px, 20 KB)
Screen Shot 2020-01-02 at 4.15.34 PM.png (297×551 px, 37 KB)
  1. The notifications are visible now mobile (when the echo notifications flyout is present) - and it seems that T223609 has been fixed with that patch too.

However, during the testing some issues with the notifications counter were found - filed as T241865: Minerva desktop - issues with Echo notifications counter .

Etonkovidova closed this task as Resolved.Jan 3 2020, 11:33 PM
Etonkovidova claimed this task.
• Esanders mentioned this in T242493: [Regression] Tooltip appears misaligned on mobile VE .Feb 8 2020, 12:32 AM
• Esanders subscribed.

This caused a regression in VE: T242493

gerritbot added a comment.Feb 10 2020, 8:23 PM

Change 571351 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Echo@master] Revert "Style improvements to Echo OOUI dialog in desktop Minerva"

https://gerrit.wikimedia.org/r/571351

gerritbot added a project: Patch-For-Review.Feb 10 2020, 8:23 PM
kostajh reopened this task as Open.Feb 10 2020, 8:38 PM
gerritbot added a comment.Feb 10 2020, 8:54 PM

Change 571351 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Revert "Style improvements to Echo OOUI dialog in desktop Minerva"

https://gerrit.wikimedia.org/r/571351

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2020, 9:10 PM
Jdlrobson renamed this task from Echo on desktop Minerva to Echo rendering issues on desktop Minerva, not usable on mobile.Feb 10 2020, 11:17 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Feb 10 2020, 11:41 PM

Change 571389 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Echo@master] Properly scoped style improvements to Echo OOUI dialog in desktop Minerva

https://gerrit.wikimedia.org/r/571389

gerritbot added a project: Patch-For-Review.Feb 10 2020, 11:41 PM
Jdlrobson added a comment.Feb 10 2020, 11:46 PM

I've resubmitted the fix with CSS scoping.

Currently notifications will be unavailable to users of Minerva desktop using mobile site and I'd expect a few bug reports about that since Minerva desktop usage (and associated bug reports) does seem to be growing.

gerritbot added a comment.Feb 11 2020, 9:16 AM

Change 571389 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Properly scoped style improvements to Echo OOUI dialog in desktop Minerva

https://gerrit.wikimedia.org/r/571389

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2020, 10:10 AM
Etonkovidova closed this task as Resolved.Feb 11 2020, 6:50 PM

Checked in betalabs - did not see any problems with Echo UI display with desktop Minerva.

• Esanders added a comment.Feb 12 2020, 5:23 PM

Thanks @Jdlrobson

Lens0021 mentioned this in T197064: In mobile skins, Echo callout displays whitespace instead of notifications.May 28 2021, 7:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits