- shared lexeme vuex store should be created in ControllerViewFactory
- injected into formsview ControllerViewFactory.js#138
- injected into LexemeHeader
- investigate the difficulty of storing lexeme objects in the vuex store
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Tarrow | T195708 Prefill spelling variant of new form representation | |||
| Resolved | Lydia_Pintscher | T197089 Inject shared lexeme store into the vue components that need to access it |
Event Timeline
Comment Actions
Change 441878 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] WIP RepresentationWidget: vuex as data store
Comment Actions
Further reading
- https://vuex.vuejs.org/guide/forms.html
- https://stackoverflow.com/a/46044953 # v-model vs vuex store
- https://itnext.io/anyway-this-is-how-to-use-v-model-with-vuex-computed-setter-in-action-320eb682c976
- https://ypereirareis.github.io/blog/2017/04/25/vuejs-two-way-data-binding-state-management-vuex-strict-mode/
- https://markus.oberlehner.net/blog/form-fields-two-way-data-binding-and-vuex/
- https://markus.oberlehner.net/blog/how-to-handle-multi-row-forms-with-vue-vuex-and-vuex-map-fields/
- https://vuex.vuejs.org/guide/mutations.html#committing-mutations-in-components
- https://vuejs.org/v2/guide/list.html#Caveats
- https://vuex.vuejs.org/guide/testing.html
Comment Actions
Change 441878 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] RepresentationWidget: vuex as data store
Comment Actions
Change 443637 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] lexemeformview: enforce properly injected value
Comment Actions
Change 443637 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] lexemeformview: enforce properly injected value
Comment Actions
If we had such a process I'd mention in this situation that the change as we did it warrants a full regression test. /cc @Lydia_Pintscher @RazShuty
Comment Actions
@Greta_Doci_WMDE: I just talked to Pablo about this. This has the potential to have broken some other things on the Lexeme UI. Could you take some time to do some edits on a Lexeme page and see if you come across anything weird? The code is deployed on https://wikidata.beta.wmflabs.org.
Comment Actions
The only problem that I could notice till now is when you mouseover anywhere in the page but properties, this pop up is shown. If you click "go to this page" it will only reload the page.
Comment Actions
Thanks! That is the page preview feature and isn't live on Wikidata. We have another ticket to fix that.