Maniphest T195708

Prefill spelling variant of new form representation
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

When adding a new form most of the time the spelling variant of the form representation will be the same as the spelling variant of the Lemma. We should pre-fill the spelling variant of a new form's first representation with the spelling variant of the first lemma of the lexeme to make it easier to add a new form and avoid mistakes.

Note: When there is more than one Lemma then we don't pre-fill.

GIVEN I am on a lexeme
AND   I click "add form"
THEN  the spelling variant field of the first (auto-added) form representation is pre-filled with the spelling variant of the first lemma of the lexeme it belongs to

Related Objects
Search...

Status	Assigned	Task
Resolved	Tarrow	T195708 Prefill spelling variant of new form representation
Resolved	Tarrow	T197085 Make Lexeme frontend datamodel have minimum required features
Resolved	Lydia_Pintscher	T197089 Inject shared lexeme store into the vue components that need to access it
Resolved	None	T197092 Adjust RepresentationWidget to prefill spelling variant of new form representation
Resolved	None	T198305 Document architecture decision to go with vuex store over Lexeme model
Resolved	Tarrow	T198379 Remove unneeded code from frontend datamodel
Resolved	Tarrow	T198713 Create browser tests for Statements on Lexeme

Event Timeline

Lydia_Pintscher created this task.May 27 2018, 5:59 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptMay 27 2018, 5:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Lydia_Pintscher triaged this task as High priority.May 27 2018, 5:59 PM

Lydia_Pintscher merged a task: T195462: Prefill the representation and spelling variant when adding a Form.May 30 2018, 1:27 PM

Lydia_Pintscher updated the task description. (Show Details)

Lydia_Pintscher added subscribers: Lea_Lacroix_WMDE, Liuxinyu970226, abian.

Lydia_Pintscher renamed this task from Prefill language of new Form with language of Lexeme to Prefill spelling variant of new Form with spelling variant of Lexeme.Jun 5 2018, 7:43 PM

Lydia_Pintscher updated the task description. (Show Details)

@Lydia_Pintscher Ponder what should happen if there are multiple lemmas. Do we want to add a new (empty) form representation for each lemma a lexeme has?

Let's take the spelling variant for the first Lemma in this case.

• Pablo-WMDE updated the task description. (Show Details)Jun 11 2018, 7:29 AM

• Pablo-WMDE updated the task description. (Show Details)

Tarrow claimed this task.Jun 11 2018, 8:51 AM

Tarrow added a project: Wikidata-Editor-Experience-Improvements-Iteration0.

Tarrow moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration0 board.Jun 11 2018, 3:12 PM

@Lydia_Pintscher Unfortunately it doesn't seem that there is an ordering of lemmas. This means that there isn't a first concept of "first".

Some possible alternatives in the situation where there is more than one lemma are:

Add as many new form representations as there are lemmas
Add no default language and only one new representation to be filled in

After talking with the others in the hike there is a "first" that I missed which is the first in list of lemmas displayed in the header.

This isn't guaranteed to appear in any particular order depending on things like the user's browser but we can still always just use the first one.

• Pablo-WMDE mentioned this in T196980: Lemma order not guaranteed.Jun 12 2018, 10:35 AM

• Pablo-WMDE set the point value for this task to 5.Jun 12 2018, 12:19 PM

We discussed it today and concluded that we don't know enough from the users yet and will therefore only pre-fill it for Lexemes with one Lemma. For the Lexemes with more than one we don't pre-fill.

Lydia_Pintscher updated the task description. (Show Details)Jun 12 2018, 3:33 PM

Jakob_WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration1.Jun 13 2018, 9:20 AM

• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration1 board.Jun 13 2018, 9:25 AM

Lydia_Pintscher added a project: Wikidata-Editor-Experience-Improvements-Iteration2.Jun 27 2018, 9:29 AM

• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration2 board.Jun 27 2018, 9:42 AM

• Vvjjkkii renamed this task from Prefill spelling variant of new form representation to z6baaaaaaa.Jul 1 2018, 1:07 AM

• Vvjjkkii removed Tarrow as the assignee of this task.