Page MenuHomePhabricator
Create Task
Maniphest T197085

Make Lexeme frontend datamodel have minimum required features
Closed, ResolvedPublic
Actions

Description

  • Lexeme.js
    • include lemmas
    • remove fingerprint / labels
    • adjust equals method
  • fix LexemeDeserializer (and serializer?) to not expect labels and instead use lemmas

Details

SubjectRepoBranchLines +/-
Remove Fingerprint from JS Entity datamodelmediawiki/extensions/Wikibasemaster+1 -1
Make Lexeme JS data model better represent backendmediawiki/extensions/WikibaseLexememaster+191 -26
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE triaged this task as High priority.Jun 13 2018, 10:10 AM
Jakob_WMDE created this task.
Tarrow moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration1 board.Jun 13 2018, 12:04 PM
Tarrow claimed this task.Jun 14 2018, 8:07 AM
Tarrow mentioned this in rWBDMJSe8a821a612e0: Introduce FingerprintableEntity in a backwards compatible way.Jun 21 2018, 3:54 PM
Tarrow mentioned this in rWBDMJS06ee2bd91fc2: Introduce FingerprintableEntity in a backwards compatible way.Jun 22 2018, 9:11 AM
Tarrow mentioned this in rWBDMJSa0acfe93d0d0: Introduce FingerprintableEntity in a backwards compatible way.Jun 22 2018, 9:44 AM
gerritbot subscribed.Jun 25 2018, 11:54 AM

Change 441836 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] Make Lexeme JS data model better represent backend

https://gerrit.wikimedia.org/r/441836

gerritbot added a project: Patch-For-Review.Jun 25 2018, 11:54 AM

Change 441837 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Remove Fingerprint from JS Entity datamodel

https://gerrit.wikimedia.org/r/441837

Tarrow mentioned this in rEWLE9427302cbd3a: Make Lexeme JS data model better represent backend.Jun 25 2018, 11:57 AM
Tarrow mentioned this in rWBDMJS2cdb004aa1cb: Introduce FingerprintableEntity in a backwards compatible way.Jun 25 2018, 12:49 PM
Tarrow mentioned this in rWBDMJS7581ce4c6f98: Introduce FingerprintableEntity in a backwards compatible way.Jun 25 2018, 1:12 PM
Tarrow mentioned this in rEWLEe6a4173cb9ac: Make Lexeme JS data model better represent backend.Jun 25 2018, 1:35 PM
Tarrow moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration1 board.Jun 25 2018, 1:43 PM
Jakob_WMDE mentioned this in rWBDMJSeb0b13f48b6e: Introduce FingerprintableEntity in a backwards compatible way.Jun 25 2018, 2:21 PM
Tarrow mentioned this in rEWLEa553d84614d0: Make Lexeme JS data model better represent backend.Jun 26 2018, 10:26 AM
Tarrow mentioned this in rEWLE74d97f38dc5a: Make Lexeme JS data model better represent backend.Jun 27 2018, 7:51 AM
Lydia_Pintscher added a project: Wikidata-Editor-Experience-Improvements-Iteration2.Jun 27 2018, 9:29 AM
• Pablo-WMDE moved this task from To Do to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration2 board.Jun 27 2018, 9:42 AM
Tarrow renamed this task from Make Lexeme frontend datamodel better represent the backend datamodel to Make Lexeme frontend datamodel have minimum required features.Jun 27 2018, 10:11 AM
gerritbot added a comment.Jun 27 2018, 12:24 PM

Change 441836 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make Lexeme JS data model better represent backend

https://gerrit.wikimedia.org/r/441836

Tarrow moved this task from Peer Review to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration2 board.Jun 28 2018, 9:23 AM
Jakob_WMDE moved this task from Test (Product Review) to Needs Announcement on the Wikidata-Editor-Experience-Improvements-Iteration2 board.Jun 28 2018, 11:49 AM
Jakob_WMDE moved this task from Needs Announcement to Done on the Wikidata-Editor-Experience-Improvements-Iteration2 board.
Ladsgroup moved this task from incoming to in progress on the Wikidata board.Jun 28 2018, 3:28 PM
Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Jun 29 2018, 10:20 AM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 6:01 PM
• Vvjjkkii renamed this task from Make Lexeme frontend datamodel have minimum required features to q4aaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii removed Tarrow as the assignee of this task.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: Tarrow; removed: gerritbot.
CommunityTechBot renamed this task from q4aaaaaaaa to Make Lexeme frontend datamodel have minimum required features.Jul 2 2018, 8:07 AM
CommunityTechBot assigned this task to Tarrow.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot edited subscribers, added: gerritbot; removed: Tarrow.
• Pablo-WMDE moved this task from Done to To Do on the Wikidata-Editor-Experience-Improvements-Iteration2 board.Jul 4 2018, 7:48 AM
• Pablo-WMDE moved this task from To Do to Done on the Wikidata-Editor-Experience-Improvements-Iteration2 board.
• Pablo-WMDE subscribed.Jul 4 2018, 7:50 AM

Not to be confused with T198379, though I don't quite know what the differentiation is.

Tarrow added a comment.Jul 4 2018, 9:58 AM

Previously the model was missing the required features (forms and lemmas). Now it has them (and more).

T198379 is ripping out the unused bits.

Jakob_WMDE closed this task as Resolved.Jul 16 2018, 9:07 AM
gerritbot added a comment.Jul 26 2018, 10:06 AM

Change 441837 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove Fingerprint from JS Entity datamodel

https://gerrit.wikimedia.org/r/441837

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 26 2018, 11:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits