Maniphest T198379

Remove unneeded code from frontend datamodel
Closed, ResolvedPublic
Actions

Description

As discussed before we'll us this as an opportunity to actually tidy up and remove the unused bits that have been left behind.

Details

	Subject	Repo	Branch	Lines +/-
	Remove unused code from Lexeme frontend data model	mediawiki/extensions/WikibaseLexeme	master	+7 -107
	Remove unused code from Lexeme frontend data model	mediawiki/extensions/WikibaseLexeme	master	+5 -135

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Tarrow	T195708 Prefill spelling variant of new form representation
Resolved	Tarrow	T198379 Remove unneeded code from frontend datamodel
Resolved	Tarrow	T198713 Create browser tests for Statements on Lexeme

Event Timeline

Tarrow triaged this task as Medium priority.Jun 28 2018, 9:22 AM

Tarrow created this task.

Tarrow moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration2 board.

Change 442826 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] Remove unused code from Lexeme frontend data model

https://gerrit.wikimedia.org/r/442826

gerritbot added a project: Patch-For-Review.Jun 28 2018, 10:57 AM

Tarrow moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration2 board.Jun 28 2018, 10:59 AM

Tarrow mentioned this in rEWLE60bf8428016d: Remove unused code from Lexeme frontend data model.Jun 28 2018, 10:59 AM

Ladsgroup moved this task from incoming to in progress on the Wikidata board.Jun 28 2018, 3:28 PM

Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Jun 29 2018, 8:55 AM

Jakob_WMDE mentioned this in rEWLEfbbd70c358b0: Remove unused code from Lexeme frontend data model.Jul 2 2018, 10:40 AM

Tarrow mentioned this in rEWLEa81cc2b226dd: Remove unused code from Lexeme frontend data model.Jul 2 2018, 11:03 AM

Change 442826 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove unused code from Lexeme frontend data model

https://gerrit.wikimedia.org/r/442826

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 2 2018, 12:01 PM

So this was reverted in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/442826/ Id74b1234548533f4a831020e18ad58687cbb991a

because it turns out statements are actually used somwhere. Whoops.

Tarrow moved this task from Peer Review to Doing on the Wikidata-Editor-Experience-Improvements-Iteration2 board.Jul 3 2018, 1:58 PM

• Pablo-WMDE mentioned this in T197085: Make Lexeme frontend datamodel have minimum required features.Jul 4 2018, 7:50 AM

Change 444201 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] Remove unused code from Lexeme frontend data model

https://gerrit.wikimedia.org/r/444201

Tarrow mentioned this in rEWLE34072ba80ab3: Remove unused code from Lexeme frontend data model.Jul 6 2018, 11:21 AM

Tarrow moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration2 board.Jul 6 2018, 11:25 AM

Change 444201 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove unused code from Lexeme frontend data model

https://gerrit.wikimedia.org/r/444201

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 11 2018, 1:02 AM

• RazShuty moved this task from Peer Review to Done on the Wikidata-Editor-Experience-Improvements-Iteration2 board.Jul 11 2018, 9:29 AM

Jakob_WMDE closed this task as Resolved.Jul 16 2018, 9:07 AM

Jakob_WMDE closed subtask T198713: Create browser tests for Statements on Lexeme as Resolved.