Page MenuHomePhabricator

Make wikibase 1.31 base and bundle image
Closed, ResolvedPublic3 Story Points

Description

Mediawiki version 1.31 (and therefore Wikibase version 1.31) has been released.
We currently do not have a docker image for it, but we should have one https://github.com/wmde/wikibase-docker/tree/master/wikibase

  • The previous image directory can mostly be copied while updating various things.
  • the .travis/build-deploy.sh in the directory should be updated to tag the image correctly with the new tags
  • the .travis/build-deploy.sh for the image currently being built as "latest" should no longer tag that image as the latest (as it is no longer the latest)
  • the new image directory should be added to the main .travis.yml file https://github.com/wmde/wikibase-docker/blob/master/.travis.yml#L6
  • The image tag for mediawiki that is being used should be updated
  • The version of Wikibase that is being fetched should be updated
  • For the bundle image the versions of other extensions loaded should be updated.
  • The readme should be updated to include the details of the new tags https://github.com/wmde/wikibase-docker/blob/master/wikibase/README.md
  • Anything else that might be missing from this list should be picked up in CR. Questions should probably be directed to @Tarrow and @Addshore

Event Timeline

Tarrow created this task.Jun 14 2018, 8:03 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptJun 14 2018, 8:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore renamed this task from Make mediawiki 1.31 base and bundle image to Make wikibase 1.31 base and bundle image.Jun 14 2018, 9:12 AM
Addshore added a subscriber: Addshore.
Addshore triaged this task as High priority.Jun 26 2018, 4:18 PM
dbs added a subscriber: dbs.Jul 18 2018, 3:46 PM
dbs added a comment.Jul 20 2018, 9:31 AM

I experimented with building a 1.31 image in a simplistic fashion (https://github.com/dbs/wikibase-docker/tree/wikibase-1.31-attempt) but that relies on the zipped release from github, and as of 1.31 we're now relying on git submodules to get packages such as https://github.com/wmde/WikibaseSerializationJavaScript and https://github.com/wmde/DataValuesJavascript (thanks to Jakob for the pointer!). Using the github zipped release results in the entity editing interface not giving the ability to add claims, and the browser console reveals JavaScript exceptions because the corresponding JS files can't be found.

We're using composer to install the PHP dependencies, perhaps we could use npm to install the JavaScript dependencies for the docker files?

dbs added a comment.Jul 20 2018, 2:06 PM

Commit aca952fca15220e5bb39bad6fac76ec43c86be2f switches the fetch method to git and uses "git submodule update --init" to populate the required branches. Things seem to be working based on my early investigations!

Thanks for the patches! we will try to get this reviewed asap.

Addshore moved this task from incoming to ready to go on the Wikidata board.Sep 19 2018, 7:28 AM
dbs added a comment.Nov 20 2018, 3:18 AM

At this point I would recommend looking at https://github.com/dbs/wikibase-docker/tree/wikibase-1.31 - I started again from current master. Much cleaner.

cdrini added a subscriber: cdrini.Nov 21 2018, 12:19 AM
Addshore lowered the priority of this task from High to Normal.Dec 18 2018, 2:39 PM

Changing to normal, I don't think this make sense to be high on the campsite.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 18 2018, 10:49 PM

From my side this is fine. @Addshore: I'll let you close it.