Page MenuHomePhabricator
Create Task
Maniphest T197212

Make wikibase 1.31 base and bundle image
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Mediawiki version 1.31 (and therefore Wikibase version 1.31) has been released.
We currently do not have a docker image for it, but we should have one https://github.com/wmde/wikibase-docker/tree/master/wikibase

  • The previous image directory can mostly be copied while updating various things.
  • the .travis/build-deploy.sh in the directory should be updated to tag the image correctly with the new tags
  • the .travis/build-deploy.sh for the image currently being built as "latest" should no longer tag that image as the latest (as it is no longer the latest)
  • the new image directory should be added to the main .travis.yml file https://github.com/wmde/wikibase-docker/blob/master/.travis.yml#L6
  • The image tag for mediawiki that is being used should be updated
  • The version of Wikibase that is being fetched should be updated
  • For the bundle image the versions of other extensions loaded should be updated.
  • The readme should be updated to include the details of the new tags https://github.com/wmde/wikibase-docker/blob/master/wikibase/README.md
  • Anything else that might be missing from this list should be picked up in CR. Questions should probably be directed to @Tarrow and @Addshore

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLadsgroupT197212 Make wikibase 1.31 base and bundle image
 ResolvedMagolT197217 Add MW 1.31 to mediawiki-docker

Event Timeline

Tarrow created this task.Jun 14 2018, 8:03 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptJun 14 2018, 8:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore renamed this task from Make mediawiki 1.31 base and bundle image to Make wikibase 1.31 base and bundle image.Jun 14 2018, 9:12 AM
Addshore merged a task: T197216: wikibase 1.31 docker image.
Addshore added a subtask: T197217: Add MW 1.31 to mediawiki-docker.
Addshore subscribed.
Magol closed subtask T197217: Add MW 1.31 to mediawiki-docker as Resolved.Jun 15 2018, 5:26 PM
Addshore triaged this task as High priority.Jun 26 2018, 4:18 PM
• Vvjjkkii renamed this task from Make wikibase 1.31 base and bundle image to 70aaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii reopened subtask T197217: Add MW 1.31 to mediawiki-docker as Open.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 70aaaaaaaa to Make wikibase 1.31 base and bundle image.Jul 2 2018, 6:56 AM
CommunityTechBot closed subtask T197217: Add MW 1.31 to mediawiki-docker as Resolved.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
dbs subscribed.Jul 18 2018, 3:46 PM
dbs added a comment.Jul 20 2018, 9:31 AM

I experimented with building a 1.31 image in a simplistic fashion (https://github.com/dbs/wikibase-docker/tree/wikibase-1.31-attempt) but that relies on the zipped release from github, and as of 1.31 we're now relying on git submodules to get packages such as https://github.com/wmde/WikibaseSerializationJavaScript and https://github.com/wmde/DataValuesJavascript (thanks to Jakob for the pointer!). Using the github zipped release results in the entity editing interface not giving the ability to add claims, and the browser console reveals JavaScript exceptions because the corresponding JS files can't be found.

We're using composer to install the PHP dependencies, perhaps we could use npm to install the JavaScript dependencies for the docker files?

dbs added a comment.Jul 20 2018, 2:06 PM

Commit aca952fca15220e5bb39bad6fac76ec43c86be2f switches the fetch method to git and uses "git submodule update --init" to populate the required branches. Things seem to be working based on my early investigations!

Addshore added a comment.Jul 26 2018, 11:27 AM

Thanks for the patches! we will try to get this reviewed asap.

Addshore added a project: User-Addshore.Jul 26 2018, 11:27 AM
Addshore moved this task from incoming to ready to go on the Wikidata board.Sep 19 2018, 7:28 AM
dbs added a comment.Nov 20 2018, 3:18 AM

At this point I would recommend looking at https://github.com/dbs/wikibase-docker/tree/wikibase-1.31 - I started again from current master. Much cleaner.

cdrini subscribed.Nov 21 2018, 12:19 AM
Lydia_Pintscher added a project: Wikidata-Campsite.Dec 5 2018, 5:36 PM
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Addshore updated the task description. (Show Details)Dec 6 2018, 10:56 AM
Addshore mentioned this in T211297: Make Wikibase 1.32 base and bundle image.
Lydia_Pintscher added a subscriber: • johl.Dec 6 2018, 10:59 AM
Lucas_Werkmeister_WMDE set the point value for this task to 3.Dec 11 2018, 3:51 PM
Lucas_Werkmeister_WMDE moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore lowered the priority of this task from High to Medium.Dec 18 2018, 2:39 PM

Changing to normal, I don't think this make sense to be high on the campsite.

Ladsgroup claimed this task.Dec 18 2018, 10:49 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Ladsgroup subscribed.

https://github.com/wmde/wikibase-docker/pull/52

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 18 2018, 10:49 PM
Addshore moved this task from ready to go to in progress on the Wikidata board.Dec 19 2018, 12:46 PM
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 19 2018, 3:36 PM
Lydia_Pintscher subscribed.Jan 3 2019, 12:38 PM

From my side this is fine. @Addshore: I'll let you close it.

Addshore closed this task as Resolved.Jan 7 2019, 5:17 PM
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits