Maniphest T197615

2017 wikitext editor does not update the address bar URL after edit save
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jc86035
	Jun 18 2018, 4:20 PM

Description

Reported on English Wikipedia's technical village pump. After save, URL retains ?action=edit, and it shouldn't happen. Apparently sometimes returns article name "undefined" in Edge.

Details

	Subject	Repo	Branch	Lines +/-
	mw.DesktopArticleTarget: remove action=edit when tearing down as single-tab	mediawiki/extensions/VisualEditor	master	+2 -1

Customize query in gerrit

Event Timeline

Jc86035 created this task.Jun 18 2018, 4:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2018, 4:20 PM

This happens in WTE 2017. I haven't looked to see if the same happens in VE.

I can reproduce this – it only happens when you're using one of the single-edit-tab modes.

The 2017WTE is "VE"; it is a mode within Extension:VisualEditor. However, I can only reproduce this with a single edit tab that points to VisualEditor's wikitext mode. I can't reproduce this with an edit in VisualEditor's visual mode.

Change 441914 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] mw.DesktopArticleTarget: remove action=edit when tearing down as single-tab

https://gerrit.wikimedia.org/r/441914

gerritbot added a project: Patch-For-Review.Jun 25 2018, 4:58 PM

Didn't strictly need to save -- any teardown would cause it. It relied on the single-edit-tab behavior of switching from veaction to action in URLs.

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Jun 25 2018, 5:44 PM

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed Patch-For-Review.

Change 441914 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] mw.DesktopArticleTarget: remove action=edit when tearing down as single-tab

https://gerrit.wikimedia.org/r/441914

• Deskana closed this task as Resolved.Jun 26 2018, 2:50 PM

• Deskana triaged this task as Medium priority.

Ryasmeen added a project: Verified.Jun 27 2018, 10:38 PM

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 30 2018, 4:01 PM

• Vvjjkkii renamed this task from 2017 wikitext editor does not update the address bar URL after edit save to 0paaaaaaaa.Jul 1 2018, 1:02 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed DLynch as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii edited subscribers, added: DLynch; removed: gerritbot, Aklapper.

AfroThundr3007730 renamed this task from 0paaaaaaaa to 2017 wikitext editor does not update the address bar URL after edit save.Jul 1 2018, 4:53 AM

AfroThundr3007730 closed this task as Resolved.

AfroThundr3007730 assigned this task to DLynch.

AfroThundr3007730 lowered the priority of this task from High to Medium.

AfroThundr3007730 edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser, Verified, VisualEditor-MediaWiki, VisualEditor (Current work).

AfroThundr3007730 updated the task description. (Show Details)

AfroThundr3007730 edited subscribers, added: GerritBot, Aklapper; removed: DLynch.

Aklapper edited subscribers, added: gerritbot; removed: GerritBot.May 16 2023, 10:18 AM

2017 wikitext editor does not update the address bar URL after edit saveClosed, ResolvedPublicActions

Description

Details

Event Timeline

2017 wikitext editor does not update the address bar URL after edit save
Closed, ResolvedPublic
Actions