Page MenuHomePhabricator
Create Task
Maniphest T197719

Deploy new "PopupsOptInStateForNewAccounts" page previews configuration to all interested projects
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Background:

We spoke to some projects about deploying page previews as enabled to all new logged in users. We would like to continue discussing this change and deploying the feature

Prior to deployment

  • Discuss proposed changes with communities

Acceptance criteria

  • Give a heads up to release engineering before deploying
  • Deploy new configuration (page previews on for new editors) $wgPopupsOptInStateForNewAccounts = '1'

QA steps

  1. Visit any production wiki and create a new account

After registering your account, you should still see page previews.

  1. For an account that previously had page previews enabled, ensure you still have page previews enabled

harder to test

  1. For an account that previously had page previews disabled, ensure you still have page previews disabled

Details

SubjectRepoBranchLines +/-
Enable page previews for all new editorsoperations/mediawiki-configmaster+5 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva triaged this task as High priority.Jun 19 2018, 6:32 PM
ovasileva created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2018, 6:32 PM
ovasileva lowered the priority of this task from High to Medium.Jun 19 2018, 6:32 PM
ovasileva moved this task from Backlog to Needs Analysis on the Page-Previews board.
ovasileva removed a project: Readers-Web-Kanbanana-Board-Old.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Jun 19 2018, 9:28 PM
Jdlrobson subscribed.

Which projects? It will help to know whether there will be any technical changes needed to support enabling - as I'm aware many of the projects we do not run on have technical constraints.

ovasileva added a comment.Jun 20 2018, 10:33 AM

@Jdlrobson - we're most likely looking at all Wikipedias (pending community consultation)

Jdlrobson added a comment.Jun 20 2018, 1:40 PM

Ah got it. I thought this was about enabling on wikivoyage or something:)

Jdlrobson renamed this task from Deploy new page previews configuration to all interested projects to Deploy new "PopupsOptInDefaultState" page previews configuration to all interested projects.Jun 20 2018, 3:00 PM
Jdlrobson renamed this task from Deploy new "PopupsOptInDefaultState" page previews configuration to all interested projects to Deploy new "PopupsOptInStateForNewAccounts" page previews configuration to all interested projects.
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson added a project: Wikimedia-Site-requests.
Jdlrobson updated the task description. (Show Details)
pmiazga subscribed.Jun 20 2018, 4:51 PM

Before enabling that feature it would be wise to ping team responsible for database maintenance. After enabling that there will be an extra entry in user options table for every new account.

ovasileva updated the task description. (Show Details)Jun 20 2018, 4:51 PM
Jdlrobson added a comment.EditedJun 27 2018, 11:43 PM

@ovasileva when do we want to deploy this?

Discuss proposed changes with communities

I thought we had permission to do this? At least for English/German?

ovasileva added a subtask: T197939: Conduct conversations with communities on page previews configuration changes.Jun 28 2018, 10:36 AM
In T197719#4320742, @Jdlrobson wrote:

@ovasileva when do we want to deploy this?

Discuss proposed changes with communities

I thought we had permission to do this? At least for English/German?

We do, but we'd still like to message initially as a reminder. Also, we'd like to ask other communities as well and deploy in one go, if possible. I'm adding the communications task as a subtask here.

Jdlrobson removed a parent task: T192622: [EPIC] Page previews post-deploy cleanup.Jun 28 2018, 4:05 PM
• Vvjjkkii renamed this task from Deploy new "PopupsOptInStateForNewAccounts" page previews configuration to all interested projects to 4maaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptJul 1 2018, 1:03 AM
CommunityTechBot renamed this task from 4maaaaaaaa to Deploy new "PopupsOptInStateForNewAccounts" page previews configuration to all interested projects.Jul 2 2018, 11:42 AM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot edited subscribers, added: Aklapper; removed: Dereckson.
ovasileva updated the task description. (Show Details)Jul 3 2018, 4:49 PM
ovasileva set the point value for this task to 1.Jul 3 2018, 4:53 PM
• Tbayer subscribed.Jul 6 2018, 2:40 AM
• Prtksxna awarded a token.Jul 6 2018, 3:47 AM
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jul 10 2018, 2:06 PM
ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Jul 10 2018, 4:09 PM

deployment scheduled for Wednesday, Jul 11

Jdlrobson moved this task from Upcoming to Current Sprint (and resolved 2018-19 Q1) pre-milestone on the Web-Team-Backlog board.Jul 10 2018, 4:23 PM
pmiazga added a comment.Jul 10 2018, 4:27 PM

@ovasileva just to confirm - do we want to enable that for all projects/all wikis?

gerritbot subscribed.Jul 10 2018, 4:28 PM

Change 444906 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[operations/mediawiki-config@master] Enable page previews for all new editors

https://gerrit.wikimedia.org/r/444906

gerritbot added a project: Patch-For-Review.Jul 10 2018, 4:28 PM
ovasileva raised the priority of this task from Medium to High.Jul 10 2018, 5:03 PM
ovasileva added a comment.Jul 10 2018, 5:47 PM
In T197719#4412560, @pmiazga wrote:

@ovasileva just to confirm - do we want to enable that for all projects/all wikis?

we have not heard any objections so yes, all projects that have page previews on

Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 10 2018, 6:29 PM
gerritbot added a comment.Jul 11 2018, 11:41 AM

Change 444906 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable page previews for all new editors

https://gerrit.wikimedia.org/r/444906

Stashbot subscribed.Jul 11 2018, 11:53 AM

Mentioned in SAL (#wikimedia-operations) [2018-07-11T11:53:10Z] <pmiazga@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:444906|Enable page previews for all new editors (T197719)]] (duration: 00m 56s)

Jdlrobson assigned this task to • alexhollender_WMF.Jul 11 2018, 9:17 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jul 11 2018, 9:26 PM
Jdlrobson updated the task description. (Show Details)
ovasileva added a comment.Jul 12 2018, 8:04 AM

@Jdlrobson, @alexhollender - no UI changes here - should this go straight to QA?

• alexhollender_WMF added a comment.Jul 12 2018, 1:26 PM

@ovasileva ya that sounds reasonable. moving it over and reassigning.

• alexhollender_WMF reassigned this task from • alexhollender_WMF to ABorbaWMF.Jul 12 2018, 1:26 PM
• alexhollender_WMF moved this task from Needs Design Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.
• alexhollender_WMF subscribed.
pmiazga added a comment.Jul 12 2018, 5:09 PM

Do we need that in QA column? logic is fully tested, there are no UI changes, no need to test on different devices.
There are only 3 possible scenarios:

  • you had page previews disabled on wiki before we deployed this change, after the deployment the page previews are still disabled
  • you had page previews enabled on wiki before we deployed this change, you still see page previews
  • you create a new account and page previews are visible
pmiazga closed this task as Resolved.Jul 12 2018, 5:10 PM
pmiazga removed a project: Patch-For-Review.
CKoerner_WMF closed subtask T197939: Conduct conversations with communities on page previews configuration changes as Resolved.Jul 19 2018, 10:05 AM
• Phabricator_maintenance edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog.Sep 13 2018, 6:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL