Page MenuHomePhabricator

[EPIC] Page previews post-deploy cleanup
Closed, ResolvedPublic

Description

Page previews is launched but there is much to clean up as we prepare to embark on future iterations of the tool.

In the aftermath of the launch we are seeing genuine concerns with accessibility and bug reports that we should deal with.

As well as this we have incurred code that we can now get rid of.

Let's make that happen!

What done means

This epic is done when:

  • Actionable bug reports that are high and within the scope of "post-deploy cleanup" are all resolved
  • Accessibility has reached a state we are proud of testing can begin so we can make page previews accessible in a way we can be proud (fixing this will come later).
  • We feel that the codebase has been simplified and we feel comfortable handing this over to Wikimedia Deutschland for them to introduce reference tooltips
  • It is June (i.e. enough time has passed since launch for all bugs to have been bubbled up to us)
  • We are happy that VirtualPageViews is working as expected.
  • @phuedx: See T184793: [EPIC] Instrument page interactions.

Out of scope

  • Feature requests and new functionality

Related Objects

StatusSubtypeAssignedTask
ResolvedDereckson
ResolvedJdlrobson
Resolvedovasileva
DuplicateNone
OpenNone
Resolvedmforns
Resolvedovasileva
ResolvedABorbaWMF
DeclinedNone
ResolvedJdlrobson
DuplicateNone
DuplicateNone
Resolvedovasileva
Resolvedovasileva
Resolvedovasileva
Resolvedphuedx
Resolvedphuedx
DuplicateNone
ResolvedJdlrobson
ResolvedJdlrobson
DuplicateNone
Duplicateovasileva
Resolvedovasileva
DuplicateNone
DeclinedNone
DuplicateJdlrobson
ResolvedMhurd
Declined JMinor
Resolvedphuedx
Resolved Pchelolo
ResolvedJdlrobson
Declined Pchelolo
Resolvedphuedx
DeclinedJdlrobson
DuplicateNone
Resolved Fjalapeno
Resolvedphuedx
Declinedpmiazga
DeclinedNone
Resolvedphuedx
DeclinedNone
Resolved Pchelolo
Resolved bearND
Resolved Mholloway
ResolvedMSantos
Resolved Mholloway
InvalidNone
ResolvedJdlrobson
InvalidNone
DuplicateNone
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
Resolvedphuedx
Resolved bearND
Resolved Mholloway
DuplicateNone
ResolvedJdlrobson
ResolvedJdlrobson
Resolvedphuedx
ResolvedJdlrobson
ResolvedJdlrobson
Resolved bearND
ResolvedJdlrobson
Resolved Mholloway
Resolved Mholloway
ResolvedJdlrobson
ResolvedJdlrobson
Resolved bearND
Resolved Tbayer
ResolvedNone
Resolvedovasileva
Resolved Tbayer
ResolvedNone
Resolvedmforns
Resolvedphuedx
DeclinedNone
Resolvedovasileva
Resolvedovasileva
Resolved Niedzielski
DuplicateJdrewniak
ResolvedABorbaWMF
Resolvedovasileva
ResolvedABorbaWMF
Resolvedphuedx
ResolvedVolker_E
DeclinedNone

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The updated tasks reflect the goals of the epic. All of these are in the current sprint, so hopefully we can close out this epic (and creating a new more scoped one if necessary) by end of the sprint.

@phuedx I'd originally intended this as a short term task (page previews is never going to be completely 100% done) and I'd like to free up the team's focus so it can focus on other things (page issues; MF refactor). In fact I was planning to resolve it as soon as I get confirmation from @Volker_E about a11y and analytics on VirtualPageViews.

I don't see any of the tasks you've added as pressing and all 3 are currently not actionable - needing more input from design or other teams (hence why not originally included as subtasks):

  • T198727: [Bug] Page summary for lead sections without any bold tags returns "standard" and no extract
  • T198708: [Bug] Middle and control clicking popup footer doesn't open new tab
  • T186644: [Bug] Page Previews are not always shown inside the viewable area when space available is constrained

(Side note: I also have a slight suspicion those priorities on those 3 tasks are not correct)

Any objection to removing these from the epic (with @ovasileva blessing) and closing out the work here? It feels like we've reached a good place.

@phuedx I'd originally intended this as a short term task <snip />

There's no such thing 😉

I don't see any of the tasks you've added as pressing and all 3 are currently not actionable - needing more input from design or other teams (hence why not originally included as subtasks):

  • T198727: [Bug] Page summary for lead sections without any bold tags returns "standard" and no extract
  • T198708: [Bug] Middle and control clicking popup footer doesn't open new tab
  • T186644: [Bug] Page Previews are not always shown inside the viewable area when space available is constrained

Those three tasks (and any others that Web resolved prior to my edit) were implied by the AC and my edit only made them visible.

(Side note: I also have a slight suspicion those priorities on those 3 tasks are not correct)

I agree. @ovasileva: When you have time, could you look at those three bugs and see if they really are High? Regardless, perhaps we can remove this task from the board to reflect the current priorities of the team.

Reviewed the tasks. All three are currently normal priority, but I am dropping T186644: [Bug] Page Previews are not always shown inside the viewable area when space available is constrained to low for now. In terms of next steps, I would suggest the following:

Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

When @Volker_E confirms we are ready to do an a11y review we can resolve this/create new tasks.

ovasileva claimed this task.

All tasks are resolved and bullet points in the acceptance criteria are resolved. I think we're ready to resolve this epic. Other tasks related to page previews can be tracked separately using the page previews project tag