Maniphest T197728

Sistersiteboxs are wired up to page issues when they shouldn't be
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 19 2018, 10:52 PM

Description

On category pages a certain template is misidentified as a "page issue"

Screen Shot 2018-06-19 at 3.47.25 PM.png (339×624 px, 47 KB)

http://reading-web-staging.wmflabs.org/w/index.php?title=Category:Beekeeping&mobileaction=toggle_view_mobile

Developer notes

Although the existing CSS selector for categories "mbox-small plainlinks sistersitebox" does not match what we classify an issue, when inserting the learn more and icon to an issue we target the .mbox-text-span - this selector should be localised to only elements that are issues

e.g.

} ).prependTo( '.mbox-text' );

becomes

} ).prependTo( '.mbox-text' );

Details

	Subject	Repo	Branch	Lines +/-
	Localise "learn more" and warning icon to issues	mediawiki/skins/MinervaNeue	master	+4 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T147641 [EPIC] Improve top of the article user experience - mobile
Resolved	Jdlrobson	T143535 [EPIC] Improve article notes
Resolved	ovasileva	T159262 [EPIC] Improve page issues
Resolved	ovasileva	T197728 Sistersiteboxs are wired up to page issues when they shouldn't be

Event Timeline

Jdlrobson triaged this task as Medium priority.Jun 19 2018, 10:52 PM

Jdlrobson created this task.

Change 441142 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Localise "learn more" and warning icon to issues

https://gerrit.wikimedia.org/r/441142

gerritbot added a project: Patch-For-Review.Jun 19 2018, 10:53 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Jun 19 2018, 11:10 PM

Follow up to T191303

Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jun 20 2018, 3:52 PM

Change 441142 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Localise "learn more" and warning icon to issues

https://gerrit.wikimedia.org/r/441142

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jun 20 2018, 4:25 PM

Jdlrobson claimed this task.Jun 20 2018, 4:31 PM

Jdlrobson reassigned this task from Jdlrobson to • alexhollender_WMF.

(on staging)

Confirmed that the sistersitebox on http://reading-web-staging.wmflabs.org/w/index.php?title=Category:Beekeeping&mobileaction=toggle_view_mobile is no longer rendering an icon as if it were a page issue notice.

• alexhollender_WMF reassigned this task from • alexhollender_WMF to ovasileva.Jun 22 2018, 4:09 PM

• alexhollender_WMF moved this task from Needs Design Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.

All done!

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 2:01 PM

• Vvjjkkii renamed this task from Sistersiteboxs are wired up to page issues when they shouldn't be to vmaaaaaaaa.Jul 1 2018, 1:03 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed ovasileva as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii edited subscribers, added: ovasileva; removed: gerritbot, Aklapper.

CommunityTechBot renamed this task from vmaaaaaaaa to Sistersiteboxs are wired up to page issues when they shouldn't be.Jul 2 2018, 11:41 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to ovasileva.

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: ovasileva.

	F22380011: Screen Shot 2018-06-19 at 3.47.25 PM.png
	Jun 19 2018, 10:52 PM

Sistersiteboxs are wired up to page issues when they shouldn't beClosed, ResolvedPublicActions