Maniphest T198088

Regression: Edit buttons appear for non-editable sections
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Mholloway
	Jun 25 2018, 12:12 PM

Description

As reported by @Kaartic in T187384#4311431, edit buttons are being shown in the app once again for non-editable sections.

Example: https://en.wikipedia.org/api/rest_v1/page/mobile-sections/Wikipedia:WikiProject_Deletion_sorting%2FIndia

Details

	Subject	Repo	Branch	Lines +/-
	Don't show edit pencil for non-editable sections.	apps/android/wikipedia	master	+8 -8

Customize query in gerrit

Related Objects

Mentioned In: T187384: How should the apps handle Parsoid non-editable and pseudo-sections (section IDs -1 and -2)?
Mentioned Here: T187384: How should the apps handle Parsoid non-editable and pseudo-sections (section IDs -1 and -2)?

Event Timeline

• Mholloway created this task.Jun 25 2018, 12:12 PM

Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptJun 25 2018, 12:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 442117 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Don't show edit pencil for non-editable sections.

https://gerrit.wikimedia.org/r/442117

gerritbot added a project: Patch-For-Review.Jun 26 2018, 2:43 PM

Change 442117 merged by jenkins-bot:
[apps/android/wikipedia@master] Don't show edit pencil for non-editable sections.

https://gerrit.wikimedia.org/r/442117

• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly); removed Wikipedia-Android-App-Backlog.Jun 26 2018, 4:08 PM

• Charlotte moved this task from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.Jun 26 2018, 7:48 PM

cooltey moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.Jun 26 2018, 8:17 PM

Hi, @Charlotte , I've moved this ticket to QA signoff since it has been merged.

@ABorbaWMF Please take a look at this patch, thanks.

• Charlotte edited projects, added Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake); removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly).Jun 26 2018, 9:23 PM

• Charlotte moved this task from Backlog to QA signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.

I apologize for the delay. This appears to be fixed, but I don't have much to go on other than the lack of edit icons. I am seeing two in this article:
https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Deletion_sorting/India

Screenshot_20180628-095555.png (1×1 px, 215 KB)

Screenshot_20180628-095607.png (1×1 px, 197 KB)

Assuming they are correct, this one can move to signoff.

In T198088#4322651, @ABorbaWMF wrote:

Assuming they are correct, this one can move to signoff.

Just for the sake of confirmation, this is correct indeed. Actually, the "Dunlop English Medium School" subsection incorrectly had an edit button before this patch. It doesn't have it anymore.

• Jhernandez mentioned this in T187384: How should the apps handle Parsoid non-editable and pseudo-sections (section IDs -1 and -2)?.Jun 29 2018, 5:04 PM

• Vvjjkkii renamed this task from Regression: Edit buttons appear for non-editable sections to vcaaaaaaaa.Jul 1 2018, 1:03 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

Kaartic renamed this task from vcaaaaaaaa to Regression: Edit buttons appear for non-editable sections.Jul 1 2018, 3:54 PM

Kaartic raised the priority of this task from High to Needs Triage.

Kaartic removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Kaartic updated the task description. (Show Details)

Kaartic added subscribers: gerritbot, Aklapper.

• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme); removed Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake).Aug 13 2018, 5:18 PM

Dbrant closed this task as Resolved.Aug 20 2018, 9:23 PM

Dbrant claimed this task.

	F23059246: Screenshot_20180628-095555.png
	Jun 28 2018, 5:09 PM

	F23059248: Screenshot_20180628-095607.png
	Jun 28 2018, 5:09 PM

Regression: Edit buttons appear for non-editable sectionsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Regression: Edit buttons appear for non-editable sections
Closed, ResolvedPublic
Actions