Page MenuHomePhabricator

[BUG] Onboarding language add/edit button hidden on 4" devices
Closed, ResolvedPublic1 Estimated Story Points

Description

As reported in T195911, the "Add/Edit" languages button is hidden on 4" devices in both portrait and landscape modes when the screen text overflows the box.

The contents should be scrollable when the screen height is too small.

Event Timeline

Change 449522 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] - Fix: Onboarding screen rendering on 4" devices

https://gerrit.wikimedia.org/r/449522

Change 449522 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Onboarding screen rendering on 4" devices

https://gerrit.wikimedia.org/r/449522

Has this really been fixed in the latest alpha 2.7.239-alpha-2018-07-31?

Has this really been fixed in the latest alpha 2.7.239-alpha-2018-07-31?

I'm asking this because I only see the Onboarding screen looking a little bad for other languages. And I'm still unable to access the add/edit button. See the linked screencast.

Testing with BLU Dash L2 (Android 6) and Wikipedia app build version 2.7.239-alpha-2018-08-06. @ABorbaWMF in the screencaps below I added 8 languages and it scrolls all of them. This looks fixed.

Testing with BLU Dash L2 (Android 6) and Wikipedia app build version 2.7.239-alpha-2018-08-16. @ABorbaWMF in the screencaps below I added 8 languages and it scrolls all of them. This looks fixed.

It seems the issue was misunderstood. Some points:

  • The actual issue is that the "Add/Edit languages button is not accessible on smaller screens (especially in landscape mode and for non-Englush languages with a long translation). I'm not sure whether the language list wasn't scrollable in smaller screens, though.
  • I tested in the latest alpha (2.7.239-alpha-2018-08-07) and the button is still inaccessible.
  • BTW, @Nicholas.tsg how did you test in a future version dated 2028-08-16? (I suppose it's 2018-08-06)

@Kaartic @ABorbaWMF that was a typo I had been using the app 2018-08-06. I tried to test again today with BLU Dash L2 (Android 6) and Wikipedia app build version 2.7.239-alpha-2018-08-13. Even though Andy of TSG and I had Googled information from this link to try to get BLU Dash L2 to auto rotate to landscape we had no luck. So the best I can provide is updated portrait screencaps below, which show on the device I'm using that the "Add/Edit" language was accessible for this orientation/device. For non-English languages, I'm not very good at reading the non-Latin alphabets so I'll allow others to test that area.

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptNov 1 2018, 5:21 PM

I'm not sure this has been resolved yet. See screen shot below

Note that the 'Add OR Edit languages' button is not visible in landscape mode. I suspect might not be visible in portrait mode too if my screen was a little smaller. The issue is even more worse in landscape for non-English device language


Note: The text not visible in landscape mode is another issue: T209764

Forgot to mention the app version. It's 2.7.264-alpha-2018-11-15.

Testing Samsung Galaxy S9 (SM-G960x) and app version 2.7.264-alpha-2018-11-19. On this device/app configuration at least, "Add or Edit Languages" is visible in both Portrait and Landscape, and languages can be scrolled when many of them are added.


Landscape mode does still have the T209764 issue as you notice "The Free Encyclopedia..." is not visible.

Actually I forgot mention again that the size of the screen in my screen shots is around 4.3" (Samsung Galaxy j1 Ace). I'm not sire what's so special on my device but I see the issue consistently. OK, I didn't re-iterate it's running Android 5.1.1, did I? May be that's the issue?