Maniphest T198701

Create RevisionStoreFactory [MCR]
Closed, ResolvedPublic
Actions

Description

A first version of RevisionStoreFactory was introduced in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/442285/ and will be reverted in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/443593/ due to some issues.

RevisionStoreFactory needs to be re implemented.

Considerations missed in the first patch:

BlobStore is per wiki, so BlobStoreFactory must be used
Both NameTableStores are per wiki, so some factory may be needed
ActorMigration is per wiki, as different wikis may have different migration configuration
CommentStore is per wiki, as different wikis may have different migration configuration
MCR itself may be at different migration stages on different wikis

Perhaps we could use SiteConfiguration to gain access to the various migration stages on the different wikis: If a SiteConfiguration is injected, the local values of the migrations tage for MCR, CommentStore and Actor are overwritten by the value for the target wiki retrieved from SiteConfiguration.

Details

	Subject	Repo	Branch	Lines +/-
	Introduce RevisionStoreFactory & Tests	mediawiki/core	master	+364 -23

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Addshore	T194729 Allow Wikibase Entities to be stored in alternative slots [MCR]
Resolved	daniel	T198701 Create RevisionStoreFactory [MCR]
		· · ·

Event Timeline

Addshore triaged this task as Medium priority.Jul 3 2018, 12:02 PM

Addshore created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2018, 12:02 PM

Addshore mentioned this in T194729: Allow Wikibase Entities to be stored in alternative slots [MCR].Jul 3 2018, 12:03 PM

Addshore added a project: User-Addshore.

Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.

Addshore mentioned this in T198704: Use a consistent caching strategy within Revision storage classes.Jul 3 2018, 12:18 PM

daniel updated the task description. (Show Details)Jul 5 2018, 2:26 PM

daniel updated the task description. (Show Details)Jul 5 2018, 2:28 PM

Change 443985 had a related patch set uploaded (by Daniel Kinzler; owner: Addshore):
[mediawiki/core@master] Introduce RevisionStoreFactory & Tests

https://gerrit.wikimedia.org/r/443985

gerritbot added a project: Patch-For-Review.Jul 5 2018, 2:55 PM

daniel updated the task description. (Show Details)Jul 5 2018, 2:59 PM

daniel claimed this task.Jul 5 2018, 3:38 PM

daniel moved this task from Backlog to In Progress on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.

In T198701#4399880, @daniel wrote:

Perhaps we could use SiteConfiguration to gain access to the various migration stages on the different wikis: If a SiteConfiguration is injected, the local values of the migrations tage for MCR, CommentStore and Actor are overwritten by the value for the target wiki retrieved from SiteConfiguration.

The method you'd use to do that is SiteConfiguration::getConfig(). Note its documentation: "For foreign wikis, this is expensive, and only works if maintenance scripts are setup to handle the --wiki parameter such as in wiki farms."

While you could in theory get most of the way there by passing the correct $wiki, $suffix, $params, and $wikiTags to SiteConfiguration::get(), determining the correct values for those variables for an arbitrary other wiki is non-trivial. On WMF sites, you'd basically need to duplicate lines 176 and 199-227 of CommonSettings.php and you'd still be out of luck if that wiki uses the value from DefaultSettings.php or overrides it in LocalSettings.php (e.g. everything in WMF's config that uses a "$wmgFoo" variable).