Description

This is a method that needs to be run before calling searchText/Title.
This method is meant to detect if a namespace is present as a prefix of the query.
This should be the responsibility of the query parser to handle this.

Details

Subject	Repo	Branch	Lines +/-
Remove CirrusSearch::replacePrefixes	mediawiki/extensions/CirrusSearch	master	+0 -9
Move parseNamespacePrefixes into CirrusSearch::searchTextReal	mediawiki/extensions/CirrusSearch	master	+49 -22
Deprecate SearchEngine::replacePrefixes	mediawiki/core	master	+76 -22
Unify SearchEngine normalizeNamespace and parseNamespacePrefixes	mediawiki/core	master	+162 -90

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Invalid		None	T235826 Introduce more complex and updated search syntax to allow power users and tools to do advanced searches
Open		None	T235827 [EPIC] new query parser is used in production
Open	PRODUCTION ERROR	None	T94814 Fix: "Warning: Search backend error during .. took .." (tracking)
Open		None	T185108 Refactor query parsing logic
Resolved		dcausse	T189880 Introduce SearchQuery
Resolved		dcausse	T198860 Deprecate SearchEngine::replacePrefixes

Event Timeline

dcausse triaged this task as Medium priority.Jul 5 2018, 1:51 PM

dcausse created this task.

Restricted Application edited projects, added Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptJul 5 2018, 1:51 PM

dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.Jul 5 2018, 1:51 PM

dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.

Change 444864 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/core@master] Unify SearchEngine normalizeNamespace and parseNamespacePrefixes

https://gerrit.wikimedia.org/r/444864

gerritbot added a project: Patch-For-Review.Jul 10 2018, 12:14 PM

Change 444865 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/core@master] Deprecate SearchEngine::replacePrefixes

https://gerrit.wikimedia.org/r/444865

Change 444866 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Move parseNamespagePrefixes into CirrusSearch::searchTextReal

https://gerrit.wikimedia.org/r/444866

Change 444867 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Remove CirrusSearch::replicePrefixes

https://gerrit.wikimedia.org/r/444867

dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Jul 10 2018, 1:35 PM

Change 444864 merged by jenkins-bot:
[mediawiki/core@master] Unify SearchEngine normalizeNamespace and parseNamespacePrefixes

https://gerrit.wikimedia.org/r/444864

Change 444866 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Move parseNamespacePrefixes into CirrusSearch::searchTextReal

https://gerrit.wikimedia.org/r/444866

Change 444865 merged by jenkins-bot:
[mediawiki/core@master] Deprecate SearchEngine::replacePrefixes

https://gerrit.wikimedia.org/r/444865

Change 444867 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Remove CirrusSearch::replacePrefixes

https://gerrit.wikimedia.org/r/444867

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 18 2018, 5:01 AM

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jul 23 2018, 5:16 PM