Page MenuHomePhabricator
Create Task
Maniphest T199097

Make SenseId a subclass of EntityId
Closed, ResolvedPublic
Actions

Description

There is already a rudimentary SenseId class, but it’s not a subclass of EntityId yet.

Details

SubjectRepoBranchLines +/-
Make SenseId a subclass of EntityIdmediawiki/extensions/WikibaseLexememaster+98 -10
Always construct SenseId including lexeme IDmediawiki/extensions/WikibaseLexememaster+21 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 9 2018, 11:22 AM
Lucas_Werkmeister_WMDE claimed this task.Jul 9 2018, 3:13 PM
Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the Wikidata-Senses-Iteration1 board.
gerritbot subscribed.Jul 9 2018, 3:49 PM

Change 444607 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Always construct SenseId including lexeme ID

https://gerrit.wikimedia.org/r/444607

gerritbot added a project: Patch-For-Review.Jul 9 2018, 3:49 PM

Change 444608 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make SenseId a subclass of EntityId

https://gerrit.wikimedia.org/r/444608

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration1 board.Jul 9 2018, 3:49 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEb8d6efa9d9a9: Always construct SenseId including lexeme ID.Jul 9 2018, 3:52 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE06db26612474: Make SenseId a subclass of EntityId.
Lucas_Werkmeister_WMDE mentioned this in rEWLEfeca2bc0c2bb: Make SenseId a subclass of EntityId.Jul 9 2018, 4:07 PM
Addshore closed this task as Resolved.Jul 10 2018, 10:09 AM
Addshore moved this task from Peer Review to Test (Product Review) on the Wikidata-Senses-Iteration1 board.
Addshore moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration1 board.
gerritbot added a comment.Jul 10 2018, 10:22 AM

Change 444607 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Always construct SenseId including lexeme ID

https://gerrit.wikimedia.org/r/444607

gerritbot added a comment.Jul 10 2018, 10:22 AM

Change 444608 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make SenseId a subclass of EntityId

https://gerrit.wikimedia.org/r/444608

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 11 2018, 2:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits