Page MenuHomePhabricator

Investigate possible issues with PostgreSQL
Closed, ResolvedPublic

Description

At the top of the file, there is a note in abusefilter.tables.pg.sql.

abusefilter.tables.pg.sql
-- Note: This does not currently work, as the extension generates queries
-- like this: SELECT af_hidden FROM abuse_filter WHERE af_id = 'new' LIMIT 1
-- Which makes no sense as af_id is a BIGINT in the MySQL version of the schema

Investigate if this is still truth, and if so, fix it.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2018, 7:36 AM

Change 445961 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/AbuseFilter@master] Remove obsolete comment from abusefilter.tables.pg.sql

https://gerrit.wikimedia.org/r/445961

Change 445961 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove obsolete comment from abusefilter.tables.pg.sql

https://gerrit.wikimedia.org/r/445961

Daimona closed this task as Resolved.Jul 16 2018, 10:07 PM
Huji added a subscriber: Huji.

@Daimona you should also remove this tag.

Yay, thanks. I usually do, but it's quite easy to forget :-)