Page MenuHomePhabricator
Create Task
Maniphest T199544

Make AbuseFilter work on PostgreSQL and SQLite (epic)
Closed, ResolvedPublic
Actions

Description

Collection of tasks for known AbuseFilter problems with SQLite and Postgres.

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT254646 Reconsidering how we name things
 OpenNoneT281536 Schema:EditAttemptStep uses non-inclusive language.
 OpenNoneT279275 Move all the functionality of {Spam,Title}Blacklist extensions into AbuseFilter and retire them
 ResolvedNoneT290934 Expand the set of bundled extensions and skins in MediaWiki 1.38
 ResolvedDaimonaT191740 Bundle AbuseFilter extension with MediaWiki
 ResolvedDaimonaT199544 Make AbuseFilter work on PostgreSQL and SQLite (epic)
 Resolvedmatej_suchanekT62639 Database: SQLite and PG are missing columns
 ResolvedDaimonaT42757 Joins on INTEGER and TEXT fail with PostgreSQL
 ResolvedDaimonaT193068 Add support for SQLite and postgre when searching patterns
 Resolvedmatej_suchanekT199506 Investigate possible issues with PostgreSQL
 Resolvedmatej_suchanekT199507 Investigate possible issues with SQLite
 ResolvedPRODUCTION ERRORDaimonaT221357 Read timeout reached while viewing AbuseLog
 ResolvedDaimonaT251967 quibble-vendor-sqlite-php72-docker is broken by AbuseFilter
 ResolvedUmherirrenderT259377 Migrate AbuseFilter to Abstract Schema
 ResolvedDaimonaT220791 afl_filter should be split in afl_filter_id and afl_global
 Resolved• MarosteguiT234052 Add abuse_filter_log.afl_filter_id and afl_global columns
 Resolved• BstormT234615 Wikireplicas changes for abuse_filter_log including two new columns
 ResolvedDaimonaT269712 Migrate afl_filter to afl_filter_id and afl_global
 Resolved• UrbanecmT269713 Run the MigrateAflFilter script for AbuseFilter
 Resolved• MarosteguiT291719 Remove abuse_filter_log.afl_filter column and adjust schema consequently from Wikimedia production
 ResolvedrookT291806 Remove afl_filter column from the views

Event Timeline

Daimona created this task.Jul 13 2018, 2:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2018, 2:51 PM
Daimona added projects: SQLite, PostgreSQL.Jul 13 2018, 2:51 PM
Daimona added subtasks: T62639: Database: SQLite and PG are missing columns, T42757: Joins on INTEGER and TEXT fail with PostgreSQL, T193068: Add support for SQLite and postgre when searching patterns, T199506: Investigate possible issues with PostgreSQL, T199507: Investigate possible issues with SQLite.
Daimona added a parent task: T191740: Bundle AbuseFilter extension with MediaWiki.
Daimona closed subtask T199506: Investigate possible issues with PostgreSQL as Resolved.Jul 16 2018, 10:07 PM
Daimona renamed this task from Make AbuseFilter work on PostgreSQL and SQLite to Make AbuseFilter work on PostgreSQL and SQLite (tracking).Sep 6 2018, 3:34 PM
Daimona triaged this task as Medium priority.
Daimona mentioned this in T62639: Database: SQLite and PG are missing columns.Oct 3 2018, 4:37 PM
Daimona closed subtask T62639: Database: SQLite and PG are missing columns as Resolved.
Daimona closed subtask T199507: Investigate possible issues with SQLite as Resolved.Mar 1 2019, 10:52 AM
Daimona closed subtask T42757: Joins on INTEGER and TEXT fail with PostgreSQL as Resolved.Apr 12 2019, 7:34 AM
matej_suchanek added a subtask: T221357: Read timeout reached while viewing AbuseLog.Apr 18 2019, 5:59 PM
Daimona added a subtask: T220791: afl_filter should be split in afl_filter_id and afl_global.Sep 13 2019, 5:38 PM
Daimona closed subtask T221357: Read timeout reached while viewing AbuseLog as Resolved.
Daimona closed subtask T193068: Add support for SQLite and postgre when searching patterns as Resolved.Nov 1 2019, 10:40 AM
Jdforrester-WMF renamed this task from Make AbuseFilter work on PostgreSQL and SQLite (tracking) to Make AbuseFilter work on PostgreSQL and SQLite (epic).Feb 24 2020, 10:33 PM
hashar mentioned this in T251967: quibble-vendor-sqlite-php72-docker is broken by AbuseFilter.May 6 2020, 12:07 PM
Reedy added a subtask: T251967: quibble-vendor-sqlite-php72-docker is broken by AbuseFilter.May 6 2020, 1:34 PM
Reedy mentioned this in T259374: Convert extensions to using abstract schema.Jul 31 2020, 5:11 PM
Reedy mentioned this in T259377: Migrate AbuseFilter to Abstract Schema.Jul 31 2020, 5:15 PM
Reedy added a subtask: T259377: Migrate AbuseFilter to Abstract Schema.
Reedy changed the task status from Open to Stalled.Jul 31 2020, 5:18 PM
Reedy subscribed.

Marking stalled due to subtask needing solving first

Daimona closed subtask T220791: afl_filter should be split in afl_filter_id and afl_global as Resolved.Dec 8 2020, 9:46 PM
Daimona reopened subtask T220791: afl_filter should be split in afl_filter_id and afl_global as Open.
Jdforrester-WMF closed subtask T251967: quibble-vendor-sqlite-php72-docker is broken by AbuseFilter as Resolved.Jan 1 2021, 6:24 PM
Jdforrester-WMF subscribed.

Well, that's half the work done, right? ;-)

Daimona added a comment.Jan 1 2021, 7:32 PM
In T199544#6716164, @Jdforrester-WMF wrote:

Well, that's half the work done, right? ;-)

Yay :-) Only T220791 is left to do now.

matej_suchanek added a project: Epic.Jan 2 2021, 10:23 AM
Daimona removed a parent task: T191740: Bundle AbuseFilter extension with MediaWiki.Apr 13 2021, 10:00 AM
Daimona changed the status of subtask T220791: afl_filter should be split in afl_filter_id and afl_global from Open to Stalled.Apr 13 2021, 12:27 PM
Jdforrester-WMF added a parent task: T191740: Bundle AbuseFilter extension with MediaWiki.Apr 13 2021, 2:42 PM
Jdforrester-WMF mentioned this in T191740: Bundle AbuseFilter extension with MediaWiki.Aug 25 2021, 5:53 PM
Daimona changed the status of subtask T220791: afl_filter should be split in afl_filter_id and afl_global from Stalled to Open.Sep 14 2021, 11:06 AM
Daimona closed this task as Resolved.Oct 26 2021, 8:40 PM
Daimona claimed this task.
Daimona closed subtask T220791: afl_filter should be split in afl_filter_id and afl_global as Resolved.

All subtasks done. While T259377 is still open, it doesn't prevent AF from working on postgres/SQLite

hashar mentioned this in T307990: Changes to cu_changes.sql causing jenkins tests failure.May 10 2022, 10:02 AM
hashar subscribed.

The CI change https://gerrit.wikimedia.org/r/c/integration/config/+/653121 enforces Sqlite for AbuseFilter but since CI inject other extensions they should be checked against Sqlite as well. T307990 is about dropping Sqlite support in CheckUser which ends up causing AbuseFilter CI to break.

Jdforrester-WMF closed subtask T259377: Migrate AbuseFilter to Abstract Schema as Resolved.Jul 13 2022, 5:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits