Page MenuHomePhabricator
Create Task
Maniphest T193068

Add support for SQLite and postgre when searching patterns
Closed, ResolvedPublic
Actions

Description

Currently we use RLIKE to allow users search with regular expressions. However, nor SQLite nor Postgre support RLIKE operator. Although we have bigger problems with those 2, we still need to make some changes to the search with regexps.

Details

SubjectRepoBranchLines +/-
Use PHP regexps instead of SQL to filter results on Special:AbuseFiltermediawiki/extensions/AbuseFiltermaster+135 -98
Use PHP regexps instead of SQL to filter on Special:AbuseFiltermediawiki/extensions/AbuseFiltermaster+164 -109
Make patterns searching compatible with Postgres and SQLitemediawiki/extensions/AbuseFiltermaster+4 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Daimona created this task.Apr 25 2018, 6:26 PM
Restricted Application added subscribers: • OldUser02, Aklapper. · View Herald TranscriptApr 25 2018, 6:26 PM
Daimona added a parent task: T191740: Bundle AbuseFilter extension with MediaWiki.Apr 25 2018, 6:31 PM
Aklapper added projects: SQLite, PostgreSQL.Apr 26 2018, 11:03 AM
Daimona triaged this task as Medium priority.Apr 26 2018, 11:20 AM

As I was saying, we have T62639 and T42757 which should be addressed first since they provide bigger unusability.

• Vvjjkkii renamed this task from Add support for SQLite and postgre when searching patterns to b8daaaaaaa.Jul 1 2018, 1:13 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed AbuseFilter.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
Mainframe98 renamed this task from b8daaaaaaa to Add support for SQLite and postgre when searching patterns.Jul 1 2018, 10:04 AM
Mainframe98 lowered the priority of this task from High to Medium.
Mainframe98 edited projects, added AbuseFilter; removed TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Mainframe98 updated the task description. (Show Details)
Mainframe98 added a subscriber: Aklapper.
Daimona added a parent task: T199544: Make AbuseFilter work on PostgreSQL and SQLite (epic).Jul 13 2018, 2:52 PM
Daimona removed a parent task: T191740: Bundle AbuseFilter extension with MediaWiki.
Daimona added a comment.Sep 27 2018, 8:27 AM

https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/460870/ should help with this.

Daimona added a comment.Oct 20 2018, 2:22 PM

I'm also wondering whether the cast to char needs to be rewritten to be DBMS-independent.

Daimona added a comment.EditedNov 16 2018, 1:11 PM
In T193068#4682559, @Daimona wrote:

I'm also wondering whether the cast to char needs to be rewritten to be DBMS-independent.

Yes, it does (for instance, on Postgres the CAST only returns the first character of the string). https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/474172/ for that part.

gerritbot added a comment.Apr 13 2019, 9:35 AM

Change 503562 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Make patterns searching compatible with Postgres and SQLite

https://gerrit.wikimedia.org/r/503562

gerritbot added a project: Patch-For-Review.Apr 13 2019, 9:35 AM
Daimona claimed this task.Apr 13 2019, 9:36 AM

Patch above + its dependencies and that's it.

Daimona mentioned this in T191740: Bundle AbuseFilter extension with MediaWiki.Sep 13 2019, 4:49 PM
CCicalese_WMF added a project: Platform Engineering.Sep 13 2019, 4:52 PM
CCicalese_WMF subscribed.

Adding to Platform Engineering for review of patches in clinic duty.

WDoranWMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Sep 13 2019, 7:14 PM
WDoranWMF moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
gerritbot added a comment.Sep 19 2019, 1:53 PM

Change 538026 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Use PHP regexps instead of SQL to filter results on Special:AbuseFilter

https://gerrit.wikimedia.org/r/538026

Daimona added a comment.Sep 19 2019, 1:55 PM
In T193068#5506281, @gerritbot wrote:

Change 538026 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Use PHP regexps instead of SQL to filter results on Special:AbuseFilter

https://gerrit.wikimedia.org/r/538026

@CPT I'd like to go with this one. The other AF patch should probably be abandoned, while I think the depends-on in core may still be valuable (I'm gonna open separate tasks for them if that's the case).

Anomie moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Sep 19 2019, 6:26 PM
gerritbot added a comment.Oct 30 2019, 12:38 PM

Change 547186 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Use PHP regexps instead of SQL to filter on Special:AbuseFilter

https://gerrit.wikimedia.org/r/547186

gerritbot added a comment.Nov 1 2019, 12:45 AM

Change 503562 abandoned by Jforrester:
Make patterns searching compatible with Postgres and SQLite

Reason:
Per the other one being merged.

https://gerrit.wikimedia.org/r/503562

gerritbot added a comment.Nov 1 2019, 12:52 AM

Change 547186 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Use PHP regexps instead of SQL to filter on Special:AbuseFilter

https://gerrit.wikimedia.org/r/547186

gerritbot added a comment.Nov 1 2019, 10:40 AM

Change 538026 abandoned by Daimona Eaytoy:
Use PHP regexps instead of SQL to filter results on Special:AbuseFilter

Reason:
Superseded by If6d8717795b6c1dcf619a23363eb6144902cfaed

https://gerrit.wikimedia.org/r/538026

Daimona closed this task as Resolved.Nov 1 2019, 10:40 AM
Daimona removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 1 2019, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits