Page MenuHomePhabricator
Create Task
Maniphest T259377

Migrate AbuseFilter to Abstract Schema
Open, LowPublic
Actions

Description

In support of T191231: RFC: Abstract schemas and schema changes, and to action T199544: Make AbuseFilter work on PostgreSQL and SQLite (epic), AbuseFilter should be migrated to using Abstract Schema

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/AbuseFiltermaster+680 -245Convert to abstract schema
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedDaimonaT199544 Make AbuseFilter work on PostgreSQL and SQLite (epic)
OpenNoneT261912 Convert WMF Deployed Extensions to Abstract Schema
OpenNoneT261911 Convert Bundled Extensions to Abstract Schema
OpenUmherirrenderT259377 Migrate AbuseFilter to Abstract Schema
ResolvedDaimonaT220791 afl_filter should be split in afl_filter_id and afl_global
· · ·

Event Timeline

Reedy created this task.Jul 31 2020, 5:15 PM
Reedy added a parent task: T199544: Make AbuseFilter work on PostgreSQL and SQLite (epic).
Reedy renamed this task from Convert AbuseFilter to Abstract Schema to Migrate AbuseFilter to Abstract Schema.Jul 31 2020, 5:27 PM
Reedy updated the task description. (Show Details)
Daimona added a project: User-Daimona.Aug 19 2020, 12:02 PM
Daimona added a subscriber: Daimona.

I think T220791 should be finished first but yes, this would be a huge improvement. Perhaps something to consider for the upcoming AF overhaul (depending on whether T220791 really is necessary, and if so, whether it makes it to prod in time).

Daimona moved this task from Backlog to Ideas for overhaul on the User-Daimona board.Aug 20 2020, 11:58 AM
Reedy added a parent task: T261912: Convert WMF Deployed Extensions to Abstract Schema.Sep 3 2020, 3:07 AM
Reedy removed a parent task: T259374: Convert extensions to using abstract schema.
Reedy mentioned this in T261912: Convert WMF Deployed Extensions to Abstract Schema.Sep 3 2020, 1:00 PM
Daimona edited projects, added AbuseFilter (Overhaul-2020); removed User-Daimona, AbuseFilter.Sep 16 2020, 3:19 PM
Daimona moved this task from Backlog to Stretch on the AbuseFilter (Overhaul-2020) board.Sep 16 2020, 3:21 PM
Daimona edited projects, added AbuseFilter; removed AbuseFilter (Overhaul-2020).Feb 5 2021, 3:32 PM
Daimona added a subtask: T220791: afl_filter should be split in afl_filter_id and afl_global.
Billinghurst added a subscriber: Billinghurst.Apr 5 2021, 12:37 AM

This is a very technical expression of a requirement, though not certain what it actually means, or the actual impact. A pointer to what is envisaged, or what change it would make to implementers, rather than hackers, would be great.

Jdforrester-WMF added a subscriber: Jdforrester-WMF.Apr 5 2021, 12:45 AM
In T259377#6971525, @Billinghurst wrote:

This is a very technical expression of a requirement,

Necessarily so, yes.

though not certain what it actually means, or the actual impact. A pointer to what is envisaged, or what change it would make to implementers, rather than hackers, would be great.

See the parent task, T261912: Convert WMF Deployed Extensions to Abstract Schema, and especially the grandparent task T191231: RFC: Abstract schemas and schema changes for the impact.

Daimona changed the status of subtask T220791: afl_filter should be split in afl_filter_id and afl_global from Open to Stalled.Apr 13 2021, 12:27 PM
Daimona changed the status of subtask T220791: afl_filter should be split in afl_filter_id and afl_global from Stalled to Open.Sep 14 2021, 11:06 AM
Daimona closed subtask T220791: afl_filter should be split in afl_filter_id and afl_global as Resolved.Oct 26 2021, 8:40 PM
Daimona mentioned this in T199544: Make AbuseFilter work on PostgreSQL and SQLite (epic).
taavi added a subscriber: taavi.Jan 4 2022, 6:10 PM

Anything left to do here?

Daimona added a comment.Jan 5 2022, 9:59 AM
In T259377#7596577, @Majavah wrote:

Anything left to do here?

Yeah, pretty much the whole thing :) However, given that T199544 was resolved, this should now be actionable.

gerritbot added a comment.Jan 28 2022, 9:57 PM

Change 757983 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] Convert to abstract schema

https://gerrit.wikimedia.org/r/757983

gerritbot added a project: Patch-For-Review.Jan 28 2022, 9:57 PM
Umherirrender mentioned this in T251613: Change the abusefilter database index definition.Jan 29 2022, 11:32 AM
Umherirrender claimed this task.Sat, Jun 11, 6:05 AM
Umherirrender triaged this task as Low priority.
Umherirrender added a project: Platform Team Initiatives (Abstract Schema).Sat, Jun 11, 6:18 AM
Umherirrender mentioned this in T261911: Convert Bundled Extensions to Abstract Schema.Wed, Jun 15, 6:58 PM
Umherirrender added a parent task: T261911: Convert Bundled Extensions to Abstract Schema.Fri, Jun 17, 8:46 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL