Page MenuHomePhabricator

Run the MigrateAflFilter script for AbuseFilter
Closed, ResolvedPublic

Description

What: Dry-run (on a single wiki, for sanity), then run the migrateAflFilter .php script for AbuseFilter
When: Whenever this patch reaches production.
Where: All wikis - beta cluster first, then production (should be next week).
Who: Whoever wants to do that. (@Daimona can do the Beta Cluster part).
How:

  1. First of all, the script should be checked with migrateAflFilter.php --dry-run on a random wiki for sanity (no errors expected)
  2. If everything is fine, it can be run for all wikis (gradually), without the need to dry-run it first.

Command to run

mwscript extensions/AbuseFilter/maintenance/MigrateAflFilter.php --wiki=… --batch-size=1000
  • Beta Cluster
  • Closed wikis
  • Test wikis
  • Group0 wikis
  • Group1 wikis
  • Group2 wikis

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
ResolvedDaimona
ResolvedUrbanecm

Event Timeline

OK, and it's now fully run (automatically) for Beta Cluster. Are we confident that there were no issues? If we're happy to proceed, does @Urbanecm want to run this AF update in prod, like they did the last one?

OK, and it's now fully run (automatically) for Beta Cluster. Are we confident that there were no issues? If we're happy to proceed, does @Urbanecm want to run this AF update in prod, like they did the last one?

I think we can be fairly confident. The config patch should be merged first (I forgot to follow-up 2 days ago), and if no issues arise, we can proceed as usual to see if we spot any error (which I think is quite unlikely at this point).

OK, and it's now fully run (automatically) for Beta Cluster. Are we confident that there were no issues? If we're happy to proceed, does @Urbanecm want to run this AF update in prod, like they did the last one?

I can do that :).

The config patch should be merged first (I forgot to follow-up 2 days ago)

Actually, discard that. The stage is already WRITE_BOTH as that's the default in AbuseFilter. You can start running the script whenever you please.

The config patch should be merged first (I forgot to follow-up 2 days ago)

Actually, discard that. The stage is already WRITE_BOTH as that's the default in AbuseFilter. You can start running the script whenever you please.

No, for safety we intentionally were extremely conservative in enabling the new write mode in production, so that it didn't potentially break the train or whatever. (But then it changed and I forgot. Oops.)

The config patch should be merged first (I forgot to follow-up 2 days ago)

Actually, discard that. The stage is already WRITE_BOTH as that's the default in AbuseFilter. You can start running the script whenever you please.

No, for safety we intentionally were extremely conservative in enabling the new write mode in production, so that it didn't potentially break the train or whatever. (But then it changed and I forgot. Oops.)

Ah right, it was set explicitly to OLD. Nevermind then.

Mentioned in SAL (#wikimedia-operations) [2021-01-19T15:15:44Z] <Urbanecm> Run foreachwikiindblist closed extensions/AbuseFilter/maintenance/MigrateAflFilter.php (T269713)

Mentioned in SAL (#wikimedia-operations) [2021-01-19T17:04:40Z] <Urbanecm> mwscript extensions/AbuseFilter/maintenance/MigrateAflFilter.php --wiki=testwiki --batch-size=1000 # T269713

Mentioned in SAL (#wikimedia-operations) [2021-01-19T17:06:20Z] <Urbanecm> mwscript extensions/AbuseFilter/maintenance/MigrateAflFilter.php --wiki=test2wiki --batch-size=1000 # T269713

Mentioned in SAL (#wikimedia-operations) [2021-01-19T17:08:48Z] <Urbanecm> Run extensions/AbuseFilter/maintenance/MigrateAflFilter.php for all group0 wikis (T269713)

Mentioned in SAL (#wikimedia-operations) [2021-01-19T17:30:09Z] <Urbanecm> Start of foreachwikiindblist group1 extensions/AbuseFilter/maintenance/MigrateAflFilter.php --batch-size=1000 (T269713)

Urbanecm updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2021-01-19T21:00:36Z] <Urbanecm> Start of foreachwikiindblist group2 extensions/AbuseFilter/maintenance/MigrateAflFilter.php --batch-size=1000 (T269713)