|operations/puppet||production||+3 -3||wikireplicas: add new columns for abuse_filter_log to wikireplicas|
|· · ·|
|Resolved||Marostegui||T234052 Add abuse_filter_log.afl_filter_id and afl_global columns|
|Resolved||Bstorm||T234615 Wikireplicas changes for abuse_filter_log including two new columns|
|· · ·|
Back when I grabbed this, I didn't realize this was actually not a "recreate views" but "expose new columns with any appropriate filters in place". The filter is fairly simple now, but I need to know how the schema is changing and what to key off to filter.
Are we only adding the new columns and not filtering them? @Daimona I don't know what the content is.
The existing config is:
abuse_filter_log: source: abuse_filter_log view: > select afl_id, afl_filter, afl_user, afl_user_text, NULL as afl_ip, afl_action, afl_actions, afl_var_dump, afl_timestamp, afl_namespace, afl_title, afl_wiki, afl_deleted, afl_patrolled_by, afl_rev_id where: afl_deleted=0
So is there any notion that afl_deleted might be changing, as a filter and can we expose these new columns with the same filtering? I'll put up a patch to discuss.
That is correct. These two columns contain the same data as afl_filter, the difference being that afl_filter is not atomic: its values can be global-<numeric ID> or <numeric ID>, whereas the new columns are used to split this information into 2 pieces (afl_global being a boolean-like, and afl_filter_id integer).