Page MenuHomePhabricator

Update StructuredDiscussions to support GlobalPreferences
Closed, InvalidPublic

Description

Hello. I added Structured Discussion email to GlobalPrefs three days ago. I do not get mails from cawiki about topic posts. I do get them from mediawiki.org, where this preference is local.
Here is hewiki Global Preferences page, where it was added.

Untitled1.png (821×807 px, 69 KB)

Here is catalanian Global Preferences page.
Untitled3.png (821×809 px, 62 KB)

Here is catalanian Preferences page.
Untitled5.png (821×807 px, 60 KB)

(From T189806)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
IKhitron renamed this task from Global Preferences problem with notification to Global Preferences problem with notifications.Jul 13 2018, 5:50 PM

I think I understand the problem. With GlobalPreferences, we have a new database table where the preference is stored but the StructuredDiscussions extension has not yet been updated so it still looks at the local preference and hence, it does not see the correct value. This should be fixed.

Relatedly, any other preferences which are added by other extensions will also have the same problem,. I am looking into them and will be filing tickets for them all.

Niharika renamed this task from Global Preferences problem with notifications to Update StructuredDiscussions to support GlobalPreferences.Jul 13 2018, 6:04 PM
In T199558#4423371, @Niharika wrote:> Relatedly, any other preferences which are added by other extensions will also have the same problem,. I am looking into them and will be filing tickets for them all.

About completely different ticket: If you do this, could you keep for me a list of extensions that use Global Preferences? Please?

In T199558#4423371, @Niharika wrote:> Relatedly, any other preferences which are added by other extensions will also have the same problem,. I am looking into them and will be filing tickets for them all.

About completely different ticket: If you do this, could you keep for me a list of extensions that use Global Preferences? Please?

See T199561. It's a work in progress.

@IKhitron Does this problem also occur with notifications or only for emails?

@IKhitron I haven't been able to reproduce it myself. Here is what I did:

  • Subscribed to a flow board on mediawiki.org where my preferences did not have emails from StructuredDiscussions enabled.
  • Went to testwiki and enabled emails from StructuredDiscussions globally.
  • Triggered some comments on the flow board on mediawiki.org from a test user account.

I got the emails and notifications as expected from the flow board post. Are the steps to reproduce correct?

@IKhitron Does this problem also occur with notifications or only for emails?

Emails only. I can't check notifications, because all global preferences except Structured discussions mail were set on my account a month ago.

@IKhitron I haven't been able to reproduce it myself. Here is what I did:
I got the emails and notifications as expected from the flow board post. Are the steps to reproduce correct?

Looks like this. Maybe something missing, because. I'm continuing not to get emails.

@IKhitron I haven't been able to reproduce it myself. Here is what I did:
I got the emails and notifications as expected from the flow board post. Are the steps to reproduce correct?

Looks like this. Maybe something missing, because. I'm continuing not to get emails.

Okay. As a basic check, maybe disable GlobalPreferences for that preference and enable it locally.
And then override it in GlobalPreferences again.

@IKhitron Does this problem still happen? I would close this task if you haven't had the problem since. It could have been a temporary caching issue or something.

I had no chance to check it, because there were no flow edits in my watchlist. When there will, be I'll inform you if it works.

Niharika moved this task from New & TBD Tickets to Archive on the Community-Tech board.

Okay, thanks @IKhitron. Please reopen this task if the feature continues to not work for you.