Page MenuHomePhabricator

No message gets rendered on Special:Log for thanks log
Closed, ResolvedPublic

Description

No message is rendered on Special:Log for the option to show the thanks log

Steps to reproduce:

  1. Set up a Ubuntu Bionic x64 virtual machine with at least 3.5 GB of RAM.
  2. Install the latest stable versions of Vagrant and Virtualbox
  3. Following the set up instructions here, install NFS server on your virtual machine and start the Vagrant box.
  4. Enable the Thanks role and run vagrant provision.
  5. Visit Special:Log when logged out
  6. Log in as the "Admin" user and visit Special:Log

Expected result: Thanks log is the first option shown on the "More Filters" section
Actual result: ⧼logeventslist-thanks-log⧽ is displayed.

See the screenshot below for details (error circled in blue pen):

Details

Related Gerrit Patches:
mediawiki/extensions/Thanks : masterAdd missing message for Special:Log filters

Event Timeline

Sau226 created this task.Jul 15 2018, 11:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2018, 11:01 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 15 2018, 11:01 AM

Same without Vagrant. I'm note sure how those new filters should work, but I guess it's just a missing i18n problem. Will probably need a patch to Thanks extension to add them.

Change 445857 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Thanks@master] Add missing message for Special:Log filters

https://gerrit.wikimedia.org/r/445857

Daimona claimed this task.Jul 15 2018, 11:41 AM

Change 445857 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Add missing message for Special:Log filters

https://gerrit.wikimedia.org/r/445857

matmarex closed this task as Resolved.Jul 17 2018, 8:36 PM
matmarex removed a project: Patch-For-Review.