Maniphest T199645

No message gets rendered on Special:Log for thanks log
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sau226
	Jul 15 2018, 11:01 AM

Description

No message is rendered on Special:Log for the option to show the thanks log

Steps to reproduce:

Set up a Ubuntu Bionic x64 virtual machine with at least 3.5 GB of RAM.
Install the latest stable versions of Vagrant and Virtualbox
Following the set up instructions here, install NFS server on your virtual machine and start the Vagrant box.
Enable the Thanks role and run vagrant provision.
Visit Special:Log when logged out
Log in as the "Admin" user and visit Special:Log

Expected result: Thanks log is the first option shown on the "More Filters" section
Actual result: ⧼logeventslist-thanks-log⧽ is displayed.

See the screenshot below for details (error circled in blue pen):

Details

	Subject	Repo	Branch	Lines +/-
	Add missing message for Special:Log filters	mediawiki/extensions/Thanks	master	+2 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Open	None	T100161 Convert all of MediaWiki core to OOUI PHP (tracking)
Open	None	T107037 Convert all MW core special pages to OOUI
Resolved	• Prtksxna	T117737 Convert Special:Log to OOUI
Resolved	• Prtksxna	T199657 Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
Resolved	Daimona	T199645 No message gets rendered on Special:Log for thanks log

Event Timeline

Sau226 created this task.Jul 15 2018, 11:01 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2018, 11:01 AM

Sau226 added a project: Thanks.Jul 15 2018, 11:01 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 15 2018, 11:01 AM

Same without Vagrant. I'm note sure how those new filters should work, but I guess it's just a missing i18n problem. Will probably need a patch to Thanks extension to add them.

Change 445857 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Thanks@master] Add missing message for Special:Log filters

https://gerrit.wikimedia.org/r/445857

gerritbot added a project: Patch-For-Review.Jul 15 2018, 11:41 AM

Daimona claimed this task.Jul 15 2018, 11:41 AM

matej_suchanek mentioned this in T117737: Convert Special:Log to OOUI.Jul 15 2018, 12:37 PM

• Prtksxna mentioned this in T199657: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.Jul 16 2018, 4:24 AM

• Prtksxna added a parent task: T199657: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.Jul 16 2018, 5:19 AM

Change 445857 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Add missing message for Special:Log filters

https://gerrit.wikimedia.org/r/445857

matmarex closed this task as Resolved.Jul 17 2018, 8:36 PM

matmarex removed a project: Patch-For-Review.