Page MenuHomePhabricator
Create Task
Maniphest T199657

Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
Closed, ResolvedPublic
Actions

Description

In converting Special:Log to HTMLForm the log-show-hide-{$type} messages were changed to logeventslist-{$type}-log. This needs to be updated in a bunch of places and old messages need to be removed. From @matej_suchanek in T117737#4425857.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/BlueSpicePageAssignmentsmaster+2 -0Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
mediawiki/extensions/BlueSpiceNamespaceManagermaster+3 -1Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
mediawiki/extensions/BlueSpicePageAccessmaster+2 -0Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
mediawiki/extensions/BlueSpicePermissionManagermaster+2 -0Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
mediawiki/extensions/BlueSpiceChecklistmaster+2 -0Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
mediawiki/extensions/BlueSpiceGroupManagermaster+2 -0Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
mediawiki/extensions/MediaWikiChatmaster+4 -0Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
mediawiki/extensions/Commentsmaster+2 -0Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
mediawiki/coremaster+8 -1LogEventsList: Add backwards-compatibility for log-show-hide messages
mediawiki/extensions/Thankswmf/1.32.0-wmf.13+2 -2Add missing message for Special:Log filters
mediawiki/extensions/FlaggedRevswmf/1.32.0-wmf.13+3 -3Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
mediawiki/extensions/FlaggedRevsmaster+3 -3Convert log-show-hide-{$type} messages to logeventslist-{$type}-log
mediawiki/extensions/Thanksmaster+2 -2Add missing message for Special:Log filters
mediawiki/coremaster+2 -6LogEventsList: Remove unused messages
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Prtksxna triaged this task as Medium priority.Jul 16 2018, 4:24 AM
Prtksxna created this task.

@Legoktm @Jdforrester-WMF Does this need to be documented in the release notes?

Prtksxna mentioned this in T117737: Convert Special:Log to OOUI.Jul 16 2018, 4:25 AM
gerritbot added a subscriber: gerritbot.Jul 16 2018, 4:32 AM

Change 445933 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] LogEventsList: Remove unused messages

https://gerrit.wikimedia.org/r/445933

gerritbot added a project: Patch-For-Review.Jul 16 2018, 4:32 AM
Prtksxna updated the task description. (Show Details)Jul 16 2018, 4:40 AM
gerritbot added a comment.Jul 16 2018, 4:52 AM

Change 445934 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/FlaggedRevs@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445934

Prtksxna updated the task description. (Show Details)Jul 16 2018, 4:52 AM
Prtksxna updated the task description. (Show Details)Jul 16 2018, 5:13 AM
gerritbot added a comment.Jul 16 2018, 5:18 AM

Change 445935 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/Comments@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445935

Prtksxna updated the task description. (Show Details)Jul 16 2018, 5:19 AM
Prtksxna added a subtask: T199645: No message gets rendered on Special:Log for thanks log.
gerritbot added a comment.Jul 16 2018, 5:25 AM

Change 445936 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/MediaWikiChat@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445936

Prtksxna updated the task description. (Show Details)Jul 16 2018, 5:25 AM
Prtksxna updated the task description. (Show Details)Jul 16 2018, 5:31 AM
gerritbot added a comment.Jul 16 2018, 5:36 AM

Change 445938 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/BlueSpiceChecklist@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445938

Prtksxna updated the task description. (Show Details)Jul 16 2018, 5:37 AM
Prtksxna mentioned this in rEBTA1f674e28ef53: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.Jul 16 2018, 5:55 AM
gerritbot added a comment.Jul 16 2018, 6:39 AM

Change 445943 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/BlueSpiceNamespaceManager@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445943

Prtksxna updated the task description. (Show Details)Jul 16 2018, 6:39 AM
gerritbot added a comment.Jul 16 2018, 6:45 AM

Change 445944 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/BlueSpicePageAccess@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445944

Prtksxna updated the task description. (Show Details)Jul 16 2018, 6:45 AM
gerritbot added a comment.Jul 16 2018, 6:49 AM

Change 445946 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/BlueSpicePermissionManager@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445946

Prtksxna updated the task description. (Show Details)Jul 16 2018, 6:50 AM
gerritbot added a comment.Jul 16 2018, 6:53 AM

Change 445947 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/BlueSpiceGroupManager@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445947

gerritbot added a comment.Jul 16 2018, 6:56 AM

Change 445948 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/BlueSpicePageAssignments@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445948

Prtksxna updated the task description. (Show Details)Jul 16 2018, 6:57 AM
Prtksxna mentioned this in rEBSJeee556bf9980: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.Jul 16 2018, 6:59 AM
Prtksxna mentioned this in rEBSN116641a884a9: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.
Prtksxna mentioned this in rEBTQ738aeb1d31f0: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.Jul 16 2018, 7:02 AM
Prtksxna mentioned this in rEBTAc6abb148a408: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.Jul 16 2018, 7:06 AM
Prtksxna mentioned this in rEBSK8c3a0763e800: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.Jul 16 2018, 7:10 AM
Prtksxna added a subscriber: mwjames.Jul 16 2018, 10:04 AM
In SemanticMediaWiki/pull/3221 @mwjames said:

The old messages should remain since I suspect the current PR only
takes into account MW 1.32. The next release of SMW is still planned
to support MW 1.27 so removing those message will cause trouble for
non MW 1.32 environments.

Of course, if the new messages are also available for MW 1.27 then
there are no objections.

Would this be an issue for other extensions too? Should we be removing the old messages later?

matmarex added a comment.Jul 17 2018, 7:26 PM
This comment was removed by matmarex.
matmarex added a comment.Jul 17 2018, 7:32 PM
In T199657#4426776, @Prtksxna wrote:

Would this be an issue for other extensions too? Should we be removing the old messages later?

This depends on the maintainer.

  • Some extensions, in particular most of those maintained by WMF, are only compatible with the most recent master version of MediaWiki. If you're using an older release, you're supposed to use the matching older version of the extension, and occasionally critical patches are backported to them.
  • Some extensions, in particular Semantic MediaWiki extensions and those in MediaWiki Language Extension Bundle, remain compatible with previous MediaWiki releases.

See also https://www.mediawiki.org/wiki/Compatibility#MediaWiki_extensions for the same explanation.

Apparently (according to that page), the policy is sometimes documented in the infobox on MediaWiki.org. If it isn't, I suppose you'll have to wait for the maintainer to respond on your patch.

matmarex added a comment.Jul 17 2018, 7:45 PM
In T199657#4426273, @Prtksxna wrote:

@Legoktm @Jdforrester-WMF Does this need to be documented in the release notes?

Yeah, I think we should document this.

To avoid a breaking change, we could also add some backwards-compatibility hacks, like for the LogEventsListGetExtraInputs hook, to try to use the old messages if new ones are not defined.

We could replace the current code:

$options[ $this->msg( "logeventslist-{$type}-log" )->text() ] = $type;

With something like this: [plus maybe some deprecation warning]

$message = $this->msg( "logeventslist-{$type}-log" );
if ( !$message->exists() ) {
	$message = $this->msg( "log-show-hide-{$type}" )->params( $this->msg( 'show' )->text() );
}
$options[ $message->text() ] = $type;
gerritbot added a comment.Jul 17 2018, 7:49 PM

Change 445857 had a related patch set uploaded (by Bartosz Dziewoński; owner: Daimona Eaytoy):
[mediawiki/extensions/Thanks@master] Add missing message for Special:Log filters

https://gerrit.wikimedia.org/r/445857

matmarex added a comment.Jul 17 2018, 7:59 PM

For Thanks and FlaggedRevs, it is definitely fine to remove the old messages, so I will merge those patches.

These are also the only two affected extensions that are deployed to Wikimedia wikis. We will need to backport https://gerrit.wikimedia.org/r/445857 and https://gerrit.wikimedia.org/r/445934 to wmf.13, otherwise those messages will not show up when it is deployed to production wikis this week (you can see the thanks one is missing on https://www.mediawiki.org/wiki/Special:Log already).

image.png (600×1 px, 132 KB)

For other extensions I'll let their maintainers decide (but feel free to ping me if no one responds, and I'll merge stuff).

gerritbot added a comment.Jul 17 2018, 8:05 PM

Change 445933 merged by jenkins-bot:
[mediawiki/core@master] LogEventsList: Remove unused messages

https://gerrit.wikimedia.org/r/445933

gerritbot added a comment.Jul 17 2018, 8:17 PM

Change 445934 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445934

gerritbot added a comment.Jul 17 2018, 8:21 PM

Change 445857 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Add missing message for Special:Log filters

https://gerrit.wikimedia.org/r/445857

matmarex closed subtask T199645: No message gets rendered on Special:Log for thanks log as Resolved.Jul 17 2018, 8:36 PM
matmarex updated the task description. (Show Details)
gerritbot added a comment.Jul 17 2018, 8:42 PM

Change 446485 had a related patch set uploaded (by Bartosz Dziewoński; owner: Daimona Eaytoy):
[mediawiki/extensions/Thanks@wmf/1.32.0-wmf.13] Add missing message for Special:Log filters

https://gerrit.wikimedia.org/r/446485

gerritbot added a comment.Jul 17 2018, 8:42 PM

Change 446486 had a related patch set uploaded (by Bartosz Dziewoński; owner: Prtksxna):
[mediawiki/extensions/FlaggedRevs@wmf/1.32.0-wmf.13] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/446486

gerritbot added a comment.Jul 17 2018, 11:14 PM

Change 446486 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@wmf/1.32.0-wmf.13] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/446486

gerritbot added a comment.Jul 17 2018, 11:18 PM

Change 446485 merged by jenkins-bot:
[mediawiki/extensions/Thanks@wmf/1.32.0-wmf.13] Add missing message for Special:Log filters

https://gerrit.wikimedia.org/r/446485

Prtksxna updated the task description. (Show Details)Jul 18 2018, 2:50 AM
gerritbot added a comment.Jul 18 2018, 4:21 AM

Change 446522 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] LogEventsList: Add backwards-compatibility for log-show-hide messages

https://gerrit.wikimedia.org/r/446522

Prtksxna updated the task description. (Show Details)Jul 18 2018, 4:22 AM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 18 2018, 5:01 AM
Kghbln updated the task description. (Show Details)Jul 18 2018, 5:53 AM
gerritbot added a comment.Jul 18 2018, 9:04 PM

Change 446522 merged by jenkins-bot:
[mediawiki/core@master] LogEventsList: Add backwards-compatibility for log-show-hide messages

https://gerrit.wikimedia.org/r/446522

gerritbot added a comment.Jul 19 2018, 4:59 PM

Change 445935 merged by jenkins-bot:
[mediawiki/extensions/Comments@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445935

gerritbot added a comment.Jul 19 2018, 4:59 PM

Change 445936 merged by jenkins-bot:
[mediawiki/extensions/MediaWikiChat@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445936

Prtksxna updated the task description. (Show Details)Jul 20 2018, 1:36 AM
Prtksxna mentioned this in rEBSN5871c15943b7: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.Jul 24 2018, 9:23 AM
Prtksxna mentioned this in rEBSK4dbd5baa30c9: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.Jul 24 2018, 9:39 AM
Prtksxna mentioned this in rEBTQb38b870db505: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.
Prtksxna mentioned this in rEBTA35f5a5a1d4e4: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.
Prtksxna mentioned this in rEBSJe4951e74a172: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.Jul 24 2018, 9:57 AM
gerritbot added a comment.Jul 27 2018, 11:26 AM

Change 445947 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceGroupManager@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445947

gerritbot added a comment.Jul 27 2018, 11:28 AM

Change 445938 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceChecklist@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445938

Prtksxna updated the task description. (Show Details)Jul 27 2018, 11:34 AM
gerritbot added a comment.Jul 27 2018, 12:56 PM

Change 445946 merged by Robert Vogel:
[mediawiki/extensions/BlueSpicePermissionManager@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445946

gerritbot added a comment.Jul 27 2018, 12:56 PM

Change 445944 merged by Robert Vogel:
[mediawiki/extensions/BlueSpicePageAccess@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445944

gerritbot added a comment.Jul 27 2018, 12:57 PM

Change 445943 merged by Robert Vogel:
[mediawiki/extensions/BlueSpiceNamespaceManager@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445943

gerritbot added a comment.Jul 27 2018, 12:58 PM

Change 445948 merged by Robert Vogel:
[mediawiki/extensions/BlueSpicePageAssignments@master] Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

https://gerrit.wikimedia.org/r/445948

Prtksxna closed this task as Resolved.Jul 30 2018, 1:40 AM
Prtksxna claimed this task.
Prtksxna removed a project: Patch-For-Review.
Prtksxna updated the task description. (Show Details)
Prtksxna mentioned this in T200657: Remove old log-show-hide-[type] messages in extensions (after 1.31 LTS is over - June 2021).
matej_suchanek removed a subscriber: matej_suchanek.Sep 14 2018, 9:40 AM
Daimona mentioned this in T256171: Unescaped message used in HTML within LogEventsList (CVE-2020-25815).Jun 24 2020, 9:14 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL