Page MenuHomePhabricator

Clean up the UI for adding a new sense
Closed, ResolvedPublic

Event Timeline

Ladsgroup removed the point value for this task.
Ladsgroup moved this task from To Do to Doing on the Wikidata-Senses-Iteration1 board.

Change 446403 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseLexeme@master] Show id of newly saved Senses

https://gerrit.wikimedia.org/r/446403

hoo added a subscriber: hoo.Jul 20 2018, 11:13 AM

@Ladsgroup Can you please clarify the scope of this task? Is this just about the IDs (I presume no)?

I would say that similar to the “ID GOES HERE”, resolved by the above patch, we should also get rid of the “STATEMENTS GO HERE”. (The server already sends a functioning statements section, but the client doesn’t yet.)

Change 446403 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Show id of newly saved Senses

https://gerrit.wikimedia.org/r/446403

Change 447398 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Render statements section for senses on client

https://gerrit.wikimedia.org/r/447398

Ladsgroup updated the task description. (Show Details)Jul 24 2018, 12:51 PM
Ladsgroup moved this task from Peer Review to Done on the Wikidata-Senses-Iteration2 board.

Change 447398 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Render statements section for senses on client

https://gerrit.wikimedia.org/r/447398

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 24 2018, 4:46 PM

Since the scope of this issue wasn’t clear, I’ll go ahead and close it. Please open additional tasks for anything that still remains to be done. (Product review can be part of the parent task IMHO.)