List insertion by typing # or * is broken. The typed text disappears, but a list number/bullet does not appear in its place.
(Technically, it does appear, but it has a slug inside, so it acts weird.)
[23:39] <wikibugs_> (CR) Esanders: "Oops, this breaks the behaviour of the list generators: '* ' & '1. ' ('# ' in MW)." [VisualEditor/VisualEditor] - https://gerrit.wikimedia.org/r/448068 (https://phabricator.wikimedia.org/T199925) (owner: DLynch) [23:39] <edsanders> Kemayo: ^ [23:40] <Kemayo> edsanders: yeah, I’d just noticed that as well. The change to containsContent, maybe. I’ll take a closer look. [23:44] <edsanders> Kemayo: blame said it was just that patch [23:45] <Kemayo> edsanders: I meant the change in that patch at the last minute to use containsContent rather than narrowly scoping it to paragraphs. I was sure I’d checked out some of the list before that. (But might be wrong.) [23:45] <Kemayo> *the list sequences [23:46] <edsanders> right [23:46] <edsanders> well list/listItem aren't contains content, but they do generate wrapper paragraphs inside [23:47] <Kemayo> I’m casting aspersions at my own testing procedures in response to feedback, mostly. [23:51] <edsanders> did someone say unit tests? [23:54] <edsanders> also I think you want .remove not .delete, the latter is for when you want the cursor to end up in a sane place, but this is a noAutoSelect fragment? [00:04] <edsanders> I think you may have to add another config param to the sequence, any attempt to guess what to do might just be too hacky [00:18] <MatmaRex> edsanders: Kemayo: my bad, i should have noticed it as well… shall we revert https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/448068 then, and backport that, or do you want to work on a fix now?