Yeah, that's an unavoidable consequence of our iframe flow. The part of the page that we host, including all the personal info, is totally unaware of events in the iframe hosted by the processor. If we're not going to change to a multi-page 'full redirect' flow, we could mark all the personal info fields as disabled / not editable after opening the iframe.

@Ejegg that seems like a good fix! ^

Thanks, @Ejegg If donors need to edit their personal info after opening the iframe, restarting the donation is now the way to go? I think this will be better in the long run, as people will be more aware of what email address we've gathered from the form.

@MBeat33 yes, if we disable the fields a page reload will be the only way to change anything. Currently, you could change stuff then click on the card type buttons to get a fresh iframe (you might even need to click on a different type then back to the one you originally selected), but that's totally non-intuitive.

When a donor clicks the card button, we should remember whatever info they've entered and redisplay that on page reload, so they won't have to enter everything fresh. We only forget their info after they come back from the processor, we get an error that means we can't continue, or we fail them for fraud.

Note on 'disable the fields' idea: should do something to make sure the fields are enabled on return to the form via back button.

Change 455062 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Disable personal info fields after submit

https://gerrit.wikimedia.org/r/455062

Change 455062 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Disable personal info fields when opening iframes

https://gerrit.wikimedia.org/r/455062