Page MenuHomePhabricator
Create Task
Maniphest T202105

Separate pagelib CSS from base CSS
Closed, ResolvedPublic
Actions

Description

Based on the discussion in T201384 we want to keep the pagelib CSS separate from the base CSS.

This will probably happen in three stages:

  • Add pagelib CSS endpoint to MCS
  • Expose pagelib CSS in RESTBase
  • Remove pagelib CSS from base CSS and add request to it from the mobile-html endpoint.

Details

SubjectRepoBranchLines +/-
CSS: remove pagelib CSS from base CSSmediawiki/services/mobileappsmaster+1 -6
mobile-html: also request pagelib CSSmediawiki/services/mobileappsmaster+6 -3
Add pagelib CSS endpointmediawiki/services/mobileappsmaster+43 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bearND claimed this task.Aug 16 2018, 11:13 PM
• bearND triaged this task as Medium priority.
• bearND created this task.
• bearND moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
• bearND updated the task description. (Show Details)Aug 16 2018, 11:16 PM
• bearND updated the task description. (Show Details)
gerritbot subscribed.Aug 17 2018, 4:07 AM

Change 453319 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Add pagelib CSS endpoint

https://gerrit.wikimedia.org/r/453319

gerritbot added a project: Patch-For-Review.Aug 17 2018, 4:07 AM
gerritbot added a comment.Aug 17 2018, 4:54 PM

Change 453319 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Add pagelib CSS endpoint

https://gerrit.wikimedia.org/r/453319

Jdforrester-WMF subscribed.Aug 20 2018, 4:53 PM
Stashbot subscribed.Aug 20 2018, 8:16 PM

Mentioned in SAL (#wikimedia-releng) [2018-08-20T20:16:19Z] <mateusbs17> (beta): Update mobileapps to 95e976d (T202105)

Stashbot added a comment.Aug 20 2018, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2018-08-20T20:29:15Z] <mbsantos@deploy1001> Started deploy [mobileapps/deploy@cae24fe]: Update mobileapps to 95e976d (T202105)

Stashbot added a comment.Aug 20 2018, 8:35 PM

Mentioned in SAL (#wikimedia-operations) [2018-08-20T20:35:35Z] <mbsantos@deploy1001> Finished deploy [mobileapps/deploy@cae24fe]: Update mobileapps to 95e976d (T202105) (duration: 06m 19s)

• bearND updated the task description. (Show Details)Aug 20 2018, 8:43 PM
• bearND moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 20 2018, 10:26 PM
• bearND added a project: Services.

RB PR: https://github.com/wikimedia/restbase/pull/1048

Jdforrester-WMF removed a project: Patch-For-Review.Aug 21 2018, 5:32 PM
Jdforrester-WMF updated the task description. (Show Details)
• bearND moved this task from Code Review to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 21 2018, 5:35 PM
• mobrovac edited projects, added Services (watching); removed Services.Aug 21 2018, 9:00 PM
• mobrovac subscribed.

RB PR to be deployed tomorrow.

• mobrovac added a project: RESTBase-API.Aug 21 2018, 9:01 PM
Stashbot added a comment.Aug 22 2018, 9:54 AM

Mentioned in SAL (#wikimedia-operations) [2018-08-22T09:54:33Z] <mobrovac@deploy1001> Started deploy [restbase/deploy@5d03f1c]: Expand CSS end points - T202105

Stashbot added a comment.Aug 22 2018, 10:08 AM

Mentioned in SAL (#wikimedia-operations) [2018-08-22T10:08:06Z] <mobrovac@deploy1001> Finished deploy [restbase/deploy@5d03f1c]: Expand CSS end points - T202105 (duration: 13m 33s)

gerritbot added a comment.Aug 22 2018, 3:00 PM

Change 454564 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] CSS: remove pagelib CSS from base CSS

https://gerrit.wikimedia.org/r/454564

gerritbot added a project: Patch-For-Review.Aug 22 2018, 3:00 PM

Change 454565 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] mobile-html: also request pagelib CSS

https://gerrit.wikimedia.org/r/454565

gerritbot added a comment.Aug 22 2018, 5:13 PM

Change 454565 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] mobile-html: also request pagelib CSS

https://gerrit.wikimedia.org/r/454565

gerritbot added a comment.Aug 22 2018, 5:13 PM

Change 454564 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] CSS: remove pagelib CSS from base CSS

https://gerrit.wikimedia.org/r/454564

Jdforrester-WMF removed a project: Patch-For-Review.Aug 22 2018, 5:19 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF moved this task from Doing to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
Stashbot added a comment.Aug 22 2018, 8:05 PM

Mentioned in SAL (#wikimedia-releng) [2018-08-22T20:05:05Z] <bearND> (beta): Update mobileapps to 141ff20 (T202105 T202237)

Stashbot mentioned this in T202237: Enable FA feed for sd.wikipedia in Android app.Aug 22 2018, 8:05 PM
Stashbot added a comment.Aug 22 2018, 8:28 PM

Mentioned in SAL (#wikimedia-operations) [2018-08-22T20:28:38Z] <bsitzmann@deploy1001> Started deploy [mobileapps/deploy@f7fa1df]: Update mobileapps to 141ff20 (T202105 T202237)

Stashbot added a comment.Aug 22 2018, 8:32 PM

Mentioned in SAL (#wikimedia-operations) [2018-08-22T20:32:20Z] <bsitzmann@deploy1001> Finished deploy [mobileapps/deploy@f7fa1df]: Update mobileapps to 141ff20 (T202105 T202237) (duration: 03m 43s)

• bearND moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 22 2018, 8:36 PM
• Jhernandez closed this task as Resolved.Aug 23 2018, 4:48 PM
• bearND added a parent task: T220044: PCS CSS improvements.Apr 3 2019, 9:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL