Page MenuHomePhabricator

CX2: All dialogs are opened in full screen, which breaks layouts
Closed, DeclinedPublic

Assigned To
None
Authored By
Esanders
Aug 17 2018, 6:51 PM
Referenced Files
F26632231: Screen Shot 2018-10-19 at 11.56.23.png
Oct 19 2018, 10:04 AM
F26632234: Screen Shot 2018-10-19 at 11.56.34.png
Oct 19 2018, 10:04 AM
F25069656: image.png
Aug 17 2018, 6:51 PM
F25069701: image.png
Aug 17 2018, 6:51 PM

Description

For example, the media dialog is not designed to be this large:

image.png (878×1 px, 59 KB)

and the template dialog has far too much whitespace:

image.png (928×1 px, 30 KB)

Event Timeline

Does "full screen" means that dialog really covers entire viewport?
By design in T198390, dialogs are meant to cover the entire content. Since you added Regression, I wonder if something is broken with positioning.
Just checked on cx2-testing using Chrome 68 and dialog is sized as expected.

Pginer-WMF subscribed.

The underlying issue does not seem to be specific to Content translation. I included below the same layout issues happening on the mobile version of visual editor. Once the form elements are improved with responsive support on the mobile editor to better support mobile devices such as tablets, those improvements will benefit Content translation too.

So I'm closing the ticket from our side.

Screen Shot 2018-10-19 at 11.56.34.png (764×1 px, 95 KB)

Screen Shot 2018-10-19 at 11.56.23.png (767×1 px, 71 KB)