Page MenuHomePhabricator
Create Task
Maniphest T202287

Implement new File page design using OOUI (multi-lingual captions only)
Closed, ResolvedPublic
Actions

Description

Update the first attempt at a SDoC File page with the new multi-lingual captions design (which implies OOUI-ifying the interface)

Details

SubjectRepoBranchLines +/-
Inject multi-lingual captions into the File pagemediawiki/extensions/WikibaseMediaInfomaster+1 K -121
Add ULS to requirements for WikibaseMediainfointegration/configmaster+1 -1
New addTemplates() method in TemplateFactorymediawiki/extensions/Wikibasemaster+32 -5
Introduce EntityDocumentView interfacemediawiki/extensions/Wikibasemaster+37 -2
Removed re-declaration of private member variables from parent classmediawiki/extensions/WikibaseMediaInfomaster+0 -10
Access modifier changes to make views more extensiblemediawiki/extensions/Wikibasemaster+6 -6
New addTemplates() method in TemplateFactorymediawiki/extensions/Wikibasemaster+38 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Cparle claimed this task.Aug 20 2018, 2:17 PM
Cparle created this task.
Cparle moved this task from To Do to Doing on the Multimedia-Team-Working-Board board.
Cparle added a subscriber: MarkTraceur.
Addshore moved this task from incoming to monitoring on the Wikidata board.Aug 20 2018, 3:21 PM
gerritbot subscribed.Aug 24 2018, 5:01 PM

Change 455204 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Work in progress

https://gerrit.wikimedia.org/r/455204

gerritbot added a project: Patch-For-Review.Aug 24 2018, 5:01 PM
Cparle mentioned this in rEWBIea6a67a8f7bf: Work in progress.Aug 24 2018, 5:05 PM
gerritbot added a comment.Aug 24 2018, 5:10 PM

Change 455206 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/Wikibase@master] Work in progress

https://gerrit.wikimedia.org/r/455206

Cparle mentioned this in rEWBIae0893f8f9bd: Work in progress.Aug 24 2018, 5:17 PM
Cparle mentioned this in rEWBI6616be8ff14c: Work in progress.Aug 27 2018, 9:07 AM
Cparle mentioned this in rEWBIb063cbb68fed: Work in progress.Aug 27 2018, 10:54 AM
gerritbot added a comment.Aug 27 2018, 11:02 AM

Change 455206 abandoned by Cparle:
New addTemplates() method in TemplateFactory

Reason:
Splitting into 2 patches so access modifier changes can be merged separately

https://gerrit.wikimedia.org/r/455206

gerritbot added a comment.Aug 27 2018, 11:04 AM

Change 455538 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/Wikibase@master] Access modifier changes to make views more extensible

https://gerrit.wikimedia.org/r/455538

gerritbot added a comment.Aug 27 2018, 11:06 AM

Change 455539 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/Wikibase@master] New addTemplates() method in TemplateFactory

https://gerrit.wikimedia.org/r/455539

gerritbot added a comment.Aug 27 2018, 11:20 AM

Change 455541 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Removed re-declaration of private member variables from parent class

https://gerrit.wikimedia.org/r/455541

Cparle mentioned this in rEWBI61f908dd412a: Removed re-declaration of private member variables from parent class.Aug 27 2018, 11:20 AM
Cparle mentioned this in T202896: Display multi-lingual captions on File page using php.Aug 27 2018, 2:54 PM
Cparle mentioned this in rEWBIcf85dc0b0bcb: Removed re-declaration of private member variables from parent class.Aug 27 2018, 3:31 PM
Cparle mentioned this in rEWBIcad8574cfb77: Removed re-declaration of private member variables from parent class.Aug 27 2018, 3:45 PM
Cparle mentioned this in rEWBI3911bb80e01d: Removed re-declaration of private member variables from parent class.Aug 27 2018, 3:49 PM
Cparle added a comment.Aug 27 2018, 4:50 PM

Note that the captions are expected to appear first on the page, see https://www.dropbox.com/s/kuv5d2gu3y7x430/Display%20caption%20on%20File%20Page.png?dl=0

gerritbot added a comment.Aug 29 2018, 7:30 AM

Change 456082 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Introduce EntityDocumentView interface

https://gerrit.wikimedia.org/r/456082

gerritbot added a comment.Aug 29 2018, 3:56 PM

Change 455538 abandoned by Cparle:
Access modifier changes to make views more extensible

Reason:
Will use interfaces from https://gerrit.wikimedia.org/r/456082 instead

https://gerrit.wikimedia.org/r/455538

gerritbot added a comment.Aug 30 2018, 9:13 AM

Change 455541 abandoned by Cparle:
Removed re-declaration of private member variables from parent class

Reason:
Abandoning because of git fetch https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /456082/

https://gerrit.wikimedia.org/r/455541

gerritbot added a comment.Sep 4 2018, 3:05 PM

Change 456082 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce EntityDocumentView interface

https://gerrit.wikimedia.org/r/456082

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 4 2018, 4:00 PM
gerritbot added a comment.Sep 10 2018, 4:54 PM

Change 455539 abandoned by Cparle:
New addTemplates() method in TemplateFactory

Reason:
Using a new instance of TemplateFactory specifically for WikibaseMediaInfo

https://gerrit.wikimedia.org/r/455539

Cparle closed subtask T203107: Show/hide languages for multi-lingual captions on File page as Declined.Sep 11 2018, 2:43 PM
gerritbot added a comment.Sep 12 2018, 2:41 PM

Change 460025 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Inject multi-lingual captions into the File page

https://gerrit.wikimedia.org/r/460025

Cparle closed subtask T202896: Display multi-lingual captions on File page using php as Declined.Sep 12 2018, 2:41 PM
Cparle closed subtask T202897: Make multi-lingual captions on the File page editable using javascript as Declined.
Cparle mentioned this in rEWBI3e10927c23b5: Inject multi-lingual captions into the File page.Sep 12 2018, 2:45 PM
Cparle mentioned this in rEWBI53182ef0d13d: Inject multi-lingual captions into the File page.
Cparle mentioned this in rEWBIa54f77a2c472: Inject multi-lingual captions into the File page.Sep 12 2018, 2:48 PM
Cparle mentioned this in rEWBI8788a8633830: Inject multi-lingual captions into the File page.Sep 12 2018, 2:52 PM
Cparle mentioned this in rEWBI84ee0ee6e73f: Inject multi-lingual captions into the File page.Sep 12 2018, 3:25 PM
Cparle mentioned this in rEWBI733ee1dfd262: Inject multi-lingual captions into the File page.Sep 12 2018, 3:42 PM
Cparle mentioned this in rEWBI45ddab9f3b8c: Inject multi-lingual captions into the File page.
Cparle mentioned this in rEWBI114f4a572f2a: Inject multi-lingual captions into the File page.Sep 12 2018, 3:45 PM
matthiasmullie mentioned this in rEWBIb879203cd4c0: Inject multi-lingual captions into the File page.Sep 12 2018, 6:07 PM
Cparle mentioned this in rEWBI03c7657e97cd: Inject multi-lingual captions into the File page.Sep 13 2018, 8:32 AM
gerritbot added a comment.Sep 13 2018, 9:11 AM

Change 460285 had a related patch set uploaded (by Cparle; owner: Cparle):
[integration/config@master] Add ULS to requirements for WikibaseMediainfo

https://gerrit.wikimedia.org/r/460285

Cparle mentioned this in rEWBI5d78956ca8e4: Inject multi-lingual captions into the File page.Sep 13 2018, 9:42 AM
Cparle added a comment.Sep 13 2018, 9:46 AM

See here for the designs https://wikimedia.invisionapp.com/share/VZGT8KX93DG#/screens/290767778

gerritbot added a comment.Sep 13 2018, 2:53 PM

Change 460285 merged by jenkins-bot:
[integration/config@master] Add ULS to requirements for WikibaseMediainfo

https://gerrit.wikimedia.org/r/460285

Cparle mentioned this in rEWBI3aac5846f5a7: Inject multi-lingual captions into the File page.Sep 13 2018, 3:14 PM
Cparle mentioned this in rEWBI59bf259ab4c0: Inject multi-lingual captions into the File page.Sep 13 2018, 3:21 PM
Cparle mentioned this in rEWBIaceb27a0ab7f: Inject multi-lingual captions into the File page.Sep 13 2018, 3:27 PM
Cparle renamed this task from Implement new File page design using OOUI to Implement new File page design using OOUI *.Sep 13 2018, 4:56 PM
Cparle renamed this task from Implement new File page design using OOUI * to Implement new File page design using OOUI (multi-lingual captions only).
Cparle updated the task description. (Show Details)
Cparle mentioned this in T204264: "Depicts crawling": Add displaying/editing statements to File page.
Cparle moved this task from Doing to Code Review on the Multimedia-Team-Working-Board board.Sep 14 2018, 2:57 PM
• Ramsey-WMF moved this task from Backlog to CURRENT - Work in progress on the SDC General board.Sep 14 2018, 5:00 PM
• Ramsey-WMF triaged this task as High priority.Sep 14 2018, 5:04 PM
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.
• brooke subscribed.Sep 14 2018, 5:54 PM
Cparle mentioned this in rEWBIb72190fe58fc: Inject multi-lingual captions into the File page.Sep 18 2018, 10:06 AM
Cparle mentioned this in rEWBI9a6c4b20f028: Inject multi-lingual captions into the File page.
Cparle mentioned this in rEWBI0e549448f628: Inject multi-lingual captions into the File page.Sep 18 2018, 10:52 AM
Cparle mentioned this in rEWBIf17ab781f396: Inject multi-lingual captions into the File page.Sep 18 2018, 10:56 AM
Cparle mentioned this in rEWBI0fe6c08a251c: Inject multi-lingual captions into the File page.Sep 18 2018, 10:58 AM
Cparle mentioned this in rEWBIbb85c2acce54: Inject multi-lingual captions into the File page.Sep 18 2018, 11:27 AM
Cparle mentioned this in rEWBIdb9cd9be4076: Inject multi-lingual captions into the File page.Sep 18 2018, 11:33 AM
Cparle mentioned this in rEWBI6db9ac263cca: Inject multi-lingual captions into the File page.Sep 21 2018, 3:56 PM
matthiasmullie mentioned this in rEWBI4845b98719fc: Inject multi-lingual captions into the File page.Sep 24 2018, 12:55 PM
matthiasmullie mentioned this in rEWBIc50dc8294454: Inject multi-lingual captions into the File page.Sep 24 2018, 1:10 PM
gerritbot added a comment.Sep 24 2018, 4:32 PM

Change 460025 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Inject multi-lingual captions into the File page

https://gerrit.wikimedia.org/r/460025

Jdforrester-WMF moved this task from Code Review to Needs QA on the Multimedia-Team-Working-Board board.Sep 24 2018, 4:34 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF moved this task from CURRENT - Work in progress to Ready for testing on the SDC General board.Sep 25 2018, 5:29 PM
Jdforrester-WMF edited projects, added Structured Data Engineering; removed SDC General.Sep 27 2018, 9:15 PM
Jdforrester-WMF moved this task from To Do to Deployment/Config on the Structured Data Engineering board.
Jdforrester-WMF moved this task from Deployment/Config to Verify on Production on the Structured Data Engineering board.
Jdforrester-WMF mentioned this in T205732: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions).Sep 28 2018, 5:24 PM
Jdforrester-WMF added a parent task: T205732: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions).
Cparle moved this task from Needs QA to Ready for Production Testing on the Multimedia-Team-Working-Board board.Oct 17 2018, 4:20 PM
Jdforrester-WMF removed a project: Multimedia.Nov 8 2018, 6:12 PM
Jdforrester-WMF subscribed.

Engineering sign-off done. Now waiting for product sign-off. (Obviously, further design changes are expected.)

Restricted Application added a project: Multimedia. · View Herald TranscriptNov 8 2018, 6:12 PM
• Ramsey-WMF closed this task as Resolved.Dec 3 2018, 5:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits