Page MenuHomePhabricator
Create Task
Maniphest T202440

CX2: "Mark as missing" not working with undo
Closed, ResolvedPublic
Actions

Description

  1. Find some links which cannot be adapted and are displayed as gray (First paragraph of en:Ifakara has lots)
  2. Select the gray link and click on "Mark as missing" to make it a red link
  3. Click undo

Result: Nothing happens

Details

SubjectRepoBranchLines +/-
Clone annotation before modifyingmediawiki/extensions/ContentTranslationmaster+8 -6
Customize query in gerrit

Related Objects

Event Timeline

• Petar.petkovic created this task.Aug 21 2018, 7:16 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptAug 21 2018, 7:16 PM
Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald Transcript
• Esanders added a comment.Aug 26 2018, 7:21 PM

I'd guess the problem is in ve.ce.CXLinkAnnotation.prototype.styleAnchor

Pginer-WMF added a project: Language-2018-July-September.Aug 27 2018, 8:17 AM
• Esanders added a comment.Aug 27 2018, 1:32 PM

Looks like this is a shallow copy issue. In general when you have a problem with undo - make sure that you are not directly modifying objects in the linear data store without cloning them.

• Esanders added a comment.Aug 27 2018, 7:04 PM

(cf T119236)

gerritbot subscribed.Aug 27 2018, 9:49 PM

Change 455560 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] Clone annotation before modifying

https://gerrit.wikimedia.org/r/455560

gerritbot added a project: Patch-For-Review.Aug 27 2018, 9:49 PM
• Petar.petkovic assigned this task to • Esanders.Aug 27 2018, 10:00 PM
• Petar.petkovic moved this task from Needs Triage to CX2 on the ContentTranslation board.
• Petar.petkovic moved this task from Backlog to In Review on the Language-2018-July-September board.
• Deskana moved this task from To Triage to External and Administrivia on the VisualEditor board.Aug 28 2018, 6:56 PM
gerritbot added a comment.Aug 29 2018, 4:28 AM

Change 455560 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Clone annotation before modifying

https://gerrit.wikimedia.org/r/455560

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 29 2018, 5:00 AM
• Petar.petkovic removed a project: Patch-For-Review.Aug 29 2018, 6:52 AM
• Petar.petkovic moved this task from In Review to QA on the Language-2018-July-September board.
• Petar.petkovic removed a subscriber: gerritbot.
Pginer-WMF closed this task as Resolved.Sep 3 2018, 7:03 AM
Pginer-WMF moved this task from QA to Done on the Language-2018-July-September board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 3 2018, 7:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits