Maniphest T202442

CX2: Undoing "Add translation" breaks saving
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Petar.petkovic
	Aug 21 2018, 7:17 PM

Description

Start translating any page
Add one paragraph to the translation
Click undo
See the console

Uncaught TypeError: targetNode.getOriginalContentSource is not a function
    at VeInitMwCXTarget.ve.init.mw.CXTarget.saveSection (ve.init.mw.CXTarget.js?8bd30:628)
    at MwCxDmTranslation.oo.EventEmitter.emit (oojs.jquery.js?2c0b9:824)
    at VeDmCXSectionNode.ve.dm.CXSectionNode.emitSectionChange

Details

	Subject	Repo	Branch	Lines +/-
	Handle the transition from translated section to placeholder by 'undo'	mediawiki/extensions/ContentTranslation	master	+27 -3

Customize query in gerrit

Event Timeline

• Petar.petkovic created this task.Aug 21 2018, 7:17 PM

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptAug 21 2018, 7:17 PM

Change 455560 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] Clone annotation before modifying

https://gerrit.wikimedia.org/r/455560

gerritbot added a project: Patch-For-Review.Aug 27 2018, 1:32 PM

Ignore above patchset - was tagged against the wrong task.

• Petar.petkovic removed a project: Patch-For-Review.Aug 27 2018, 10:01 PM

• Petar.petkovic moved this task from Needs Triage to CX2 on the ContentTranslation board.

Pginer-WMF added a project: Language-2018-July-September.Aug 28 2018, 6:56 AM

santhosh claimed this task.Aug 29 2018, 9:29 AM

santhosh moved this task from Backlog to In Progress on the Language-2018-July-September board.

Change 456107 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] WIP: Handle the transition from translated section to placeholder by 'undo'

https://gerrit.wikimedia.org/r/456107

gerritbot added a project: Patch-For-Review.Aug 29 2018, 9:58 AM

• Petar.petkovic moved this task from In Progress to In Review on the Language-2018-July-September board.Aug 29 2018, 10:17 AM

• Petar.petkovic moved this task from In Review to In Progress on the Language-2018-July-September board.

santhosh moved this task from In Progress to In Review on the Language-2018-July-September board.Sep 3 2018, 8:23 AM

Change 456107 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Handle the transition from translated section to placeholder by 'undo'

https://gerrit.wikimedia.org/r/456107

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 5 2018, 8:00 AM

• Petar.petkovic removed a project: Patch-For-Review.Sep 5 2018, 8:03 AM

• Petar.petkovic moved this task from In Review to QA on the Language-2018-July-September board.

• Petar.petkovic removed a subscriber: gerritbot.

Etonkovidova closed this task as Resolved.Sep 6 2018, 10:39 PM

• Petar.petkovic moved this task from QA to Done on the Language-2018-July-September board.Sep 6 2018, 11:36 PM

CX2: Undoing "Add translation" breaks savingClosed, ResolvedPublicActions

Description

Details

Event Timeline

CX2: Undoing "Add translation" breaks saving
Closed, ResolvedPublic
Actions