Page MenuHomePhabricator

Integrate checkbox widget with TagItemWidget
Closed, ResolvedPublic8 Story Points

Description

Move generation of the namespaces pills from the filter box (where you can type) to under the presets (General, Discussion, etc.)
See mock

Acceptance Criteria:

Background: T202370

Event Timeline

gabriel-wmde renamed this task from Move position of namespace pills to Integrate checkbox widget with TagItemWidget.Aug 22 2018, 1:25 PM
gabriel-wmde updated the task description. (Show Details)
Tonina_Zhelyazkova_WMDE set the point value for this task to 8.Aug 22 2018, 1:41 PM

I found one more thing: When I select a namespace, it is highlighted in blue (yay!) but when the widget loses focus, it still stays blue (confusing :/ ). Should I create a new ticket for that or is this handled as part of this ticket?

Change 460048 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/AdvancedSearch@master] Update highlighting of the last created tag

https://gerrit.wikimedia.org/r/460048

Let's keep it part of this ticket, already uploaded a patch.

I just found another thing: The namespace names seem to never include spaces, but underscores instead. E.g:

Change 460048 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Update highlighting of the last created tag

https://gerrit.wikimedia.org/r/460048

@Lea_WMDE the previous problem with the highlighted tag is fixed. You can check on beta.
For the namespaces names I'd rather open a new ticket because it's not related to this story.

Change 460532 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/AdvancedSearch@master] Normalize namespace names

https://gerrit.wikimedia.org/r/460532

@Tonina_Zhelyazkova_WMDE will create a seperate ticket about the namespace title representation. The ticket is worth 2 points.