Fix search header overlapping the tooltips as seen in https://phabricator.wikimedia.org/T195713#4534020
See suggested fix in https://phabricator.wikimedia.org/T195713#4541348
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T72163 Edit conflicts (tracking) | |||
| Resolved | None | T139601 Better solutions to edit conflicts (#1) | |||
| Resolved | WMDE-Fisch | T195711 Make v2 of TwoColConflict: line based edit conflict handling | |||
| Resolved | Andrew-WMDE | T195713 Have an intro tour (No. 2) | |||
| Resolved | thiemowmde | T203066 Fix the header overlapping the tour window |
Event Timeline
Comment Actions
There are multiple suggestions. The problem could be alievated by making the popups wider, but ideally we want to fully remove the problem. One idea might be to look into the OOUI configurations.
Comment Actions
A little more investigation:
- OOUI supports dialog (a.k.a. window) sizes "small" (300px), "medium" (500px), "large" (600px), "larger" (900px), and "full" (100%). Currently our code for the tour dialogs sets "large", but this is apparently ignored or not set correctly because the popups end up being 300px. Apparently this is an actual bug we should fix!
- Using the $container option as described in https://www.mediawiki.org/wiki/OOUI/Widgets/Popups#containerExample sounds great. I will continue the investigation @jkroll started.
Comment Actions
Change 463086 had a related patch set uploaded (by Jkroll; owner: Jkroll):
[mediawiki/extensions/TwoColConflict@master] Making the popups a bit larger seems to fix this for most, if not all cases.
Comment Actions
Change 463086 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Making the popups a bit larger seems to fix this for most, if not all cases.