Maniphest T203085

TwoColConflict: Call to a member function getUser() on a non-object
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	Tgr
	Aug 29 2018, 1:46 PM

Project Tags

Referenced Files

None

Subscribers

Description

I got this on testwiki after creating a new page:

[W4ajOQpAMFcAALGJkFIAAABJ] /w/index.php?title=Test-xxx&action=submit BadMethodCallException from line 311 of /srv/mediawiki/php-1.32.0-wmf.19/extensions/TwoColConflict/includes/InlineTwoColConflict/InlineTwoColConflictHelper.php: Call to a member function getUser() on a non-object (null)

Backtrace:

#0 /srv/mediawiki/php-1.32.0-wmf.19/extensions/TwoColConflict/includes/InlineTwoColConflict/InlineTwoColConflictHelper.php(159): TwoColConflict\InlineTwoColConflict\InlineTwoColConflictHelper->buildEditSummary()
#1 /srv/mediawiki/php-1.32.0-wmf.19/extensions/TwoColConflict/includes/InlineTwoColConflict/InlineTwoColConflictHelper.php(115): TwoColConflict\InlineTwoColConflict\InlineTwoColConflictHelper->buildConflictPageChangesCol()
#2 /srv/mediawiki/php-1.32.0-wmf.19/includes/EditPage.php(2901): TwoColConflict\InlineTwoColConflict\InlineTwoColConflictHelper->getEditFormHtmlBeforeContent()
#3 /srv/mediawiki/php-1.32.0-wmf.19/includes/EditPage.php(702): EditPage->showEditForm()
#4 /srv/mediawiki/php-1.32.0-wmf.19/includes/actions/EditAction.php(60): EditPage->edit()
#5 /srv/mediawiki/php-1.32.0-wmf.19/includes/actions/SubmitAction.php(38): EditAction->show()
#6 /srv/mediawiki/php-1.32.0-wmf.19/includes/MediaWiki.php(501): SubmitAction->show()
#7 /srv/mediawiki/php-1.32.0-wmf.19/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.32.0-wmf.19/includes/MediaWiki.php(868): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.32.0-wmf.19/includes/MediaWiki.php(525): MediaWiki->main()
#10 /srv/mediawiki/php-1.32.0-wmf.19/index.php(42): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include(string)
#12 {main}

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Narrow HtmlSplitConflictHeader to not rely on it's (only) user	Thiemo Kreuz (WMDE)	mediawiki/extensions/TwoColConflict	master	+81 -57

Customize query in gerrit

Related Objects

Mentioned In: rESCC09a015b99fc1: Narrow HtmlSplitConflictHeader to not rely on it's (only) user
rESCC091d3b7a328f: Narrow HtmlSplitConflictHeader to not rely on it's (only) user
rESCC392e9331bbf6: Narrow HtmlSplitConflictHeader to not rely on it's (only) user
rESCC770503e7ab59: Narrow HtmlSplitConflictHeader to not rely on it's (only) user
rESCCc9ffcafa046e: Narrow HtmlSplitConflictHeader to not rely on it's (only) user

Event Timeline

Tgr created this task.Aug 29 2018, 1:46 PM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptAug 29 2018, 1:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The immediate cause is an unhandled null return in WikiPage::getRevision() - presumably the WikiPage is missing a loadPageData('fromdbmaster') call. The error is vaguely diff-related so could be caused by the recent MCR refactoring - maybe it changed loading order somehow.

The story points are meant as investigation points, acting as a timebox as well.

Notes: This might be related to a page with an invalid title. Maybe it is related to an attempt to get data from a not yet populated replica.

• Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Two-Column-Edit-Conflict-Merge board.Sep 4 2018, 12:36 PM

The title was definitely valid (but freshly created). Probably replica lag, yeah; I'm not sure why it did not occur before, though.

Change 458194 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Narrow HtmlSplitConflictHeader to not rely on it's (only) user

https://gerrit.wikimedia.org/r/458194

gerritbot added a project: Patch-For-Review.Sep 5 2018, 3:02 PM

thiemowmde mentioned this in rESCCc9ffcafa046e: Narrow HtmlSplitConflictHeader to not rely on it's (only) user.Sep 5 2018, 3:05 PM

thiemowmde mentioned this in rESCC770503e7ab59: Narrow HtmlSplitConflictHeader to not rely on it's (only) user.Sep 5 2018, 3:19 PM

WMDE-Fisch mentioned this in rESCC392e9331bbf6: Narrow HtmlSplitConflictHeader to not rely on it's (only) user.Sep 6 2018, 9:27 AM

Krinkle added a project: Wikimedia-production-error.Sep 12 2018, 4:38 PM

Krinkle moved this task from Untriaged to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.

thiemowmde mentioned this in rESCC091d3b7a328f: Narrow HtmlSplitConflictHeader to not rely on it's (only) user.Sep 12 2018, 5:36 PM