Page MenuHomePhabricator
Create Task
Maniphest T203085

TwoColConflict: Call to a member function getUser() on a non-object
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions

Description

I got this on testwiki after creating a new page:

[W4ajOQpAMFcAALGJkFIAAABJ] /w/index.php?title=Test-xxx&action=submit BadMethodCallException from line 311 of /srv/mediawiki/php-1.32.0-wmf.19/extensions/TwoColConflict/includes/InlineTwoColConflict/InlineTwoColConflictHelper.php: Call to a member function getUser() on a non-object (null)

Backtrace:

#0 /srv/mediawiki/php-1.32.0-wmf.19/extensions/TwoColConflict/includes/InlineTwoColConflict/InlineTwoColConflictHelper.php(159): TwoColConflict\InlineTwoColConflict\InlineTwoColConflictHelper->buildEditSummary()
#1 /srv/mediawiki/php-1.32.0-wmf.19/extensions/TwoColConflict/includes/InlineTwoColConflict/InlineTwoColConflictHelper.php(115): TwoColConflict\InlineTwoColConflict\InlineTwoColConflictHelper->buildConflictPageChangesCol()
#2 /srv/mediawiki/php-1.32.0-wmf.19/includes/EditPage.php(2901): TwoColConflict\InlineTwoColConflict\InlineTwoColConflictHelper->getEditFormHtmlBeforeContent()
#3 /srv/mediawiki/php-1.32.0-wmf.19/includes/EditPage.php(702): EditPage->showEditForm()
#4 /srv/mediawiki/php-1.32.0-wmf.19/includes/actions/EditAction.php(60): EditPage->edit()
#5 /srv/mediawiki/php-1.32.0-wmf.19/includes/actions/SubmitAction.php(38): EditAction->show()
#6 /srv/mediawiki/php-1.32.0-wmf.19/includes/MediaWiki.php(501): SubmitAction->show()
#7 /srv/mediawiki/php-1.32.0-wmf.19/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.32.0-wmf.19/includes/MediaWiki.php(868): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.32.0-wmf.19/includes/MediaWiki.php(525): MediaWiki->main()
#10 /srv/mediawiki/php-1.32.0-wmf.19/index.php(42): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include(string)
#12 {main}

Details

SubjectRepoBranchLines +/-
Narrow HtmlSplitConflictHeader to not rely on it's (only) usermediawiki/extensions/TwoColConflictmaster+81 -57
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Aug 29 2018, 1:46 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptAug 29 2018, 1:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr added a comment.Aug 29 2018, 1:52 PM

The immediate cause is an unhandled null return in WikiPage::getRevision() - presumably the WikiPage is missing a loadPageData('fromdbmaster') call. The error is vaguely diff-related so could be caused by the recent MCR refactoring - maybe it changed loading order somehow.

• Lea_WMDE set the point value for this task to 3.Sep 4 2018, 12:35 PM
• Lea_WMDE subscribed.

The story points are meant as investigation points, acting as a timebox as well.

Notes: This might be related to a page with an invalid title. Maybe it is related to an attempt to get data from a not yet populated replica.

• Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Two-Column-Edit-Conflict-Merge board.Sep 4 2018, 12:36 PM
Tgr added a comment.Sep 4 2018, 1:35 PM

The title was definitely valid (but freshly created). Probably replica lag, yeah; I'm not sure why it did not occur before, though.

gerritbot subscribed.Sep 5 2018, 3:02 PM

Change 458194 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Narrow HtmlSplitConflictHeader to not rely on it's (only) user

https://gerrit.wikimedia.org/r/458194

gerritbot added a project: Patch-For-Review.Sep 5 2018, 3:02 PM
thiemowmde mentioned this in rESCCc9ffcafa046e: Narrow HtmlSplitConflictHeader to not rely on it's (only) user.Sep 5 2018, 3:05 PM
thiemowmde mentioned this in rESCC770503e7ab59: Narrow HtmlSplitConflictHeader to not rely on it's (only) user.Sep 5 2018, 3:19 PM
WMDE-Fisch mentioned this in rESCC392e9331bbf6: Narrow HtmlSplitConflictHeader to not rely on it's (only) user.Sep 6 2018, 9:27 AM
Krinkle added a project: Wikimedia-production-error.Sep 12 2018, 4:38 PM
Krinkle moved this task from Untriaged to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.
thiemowmde mentioned this in rESCC091d3b7a328f: Narrow HtmlSplitConflictHeader to not rely on it's (only) user.Sep 12 2018, 5:36 PM
• Lea_WMDE changed the point value for this task from 3 to 1.Sep 13 2018, 3:06 PM
• Lea_WMDE added a project: WMDE-QWERTY-Sprint-2018-09-13.

@Tgr's suggestion probably solves the problem. So we will add it.

• Lea_WMDE moved this task from Tickets ready for pickup to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.Sep 13 2018, 3:07 PM
Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.Sep 19 2018, 12:58 AM
WMDE-Fisch mentioned this in rESCC09a015b99fc1: Narrow HtmlSplitConflictHeader to not rely on it's (only) user.Sep 25 2018, 9:25 AM
gerritbot added a comment.Sep 25 2018, 10:47 AM

Change 458194 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Narrow HtmlSplitConflictHeader to not rely on it's (only) user

https://gerrit.wikimedia.org/r/458194

WMDE-Fisch moved this task from Sprint Backlog to Done on the WMDE-QWERTY-Sprint-2018-09-13 board.Sep 25 2018, 10:52 AM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 25 2018, 11:00 AM
• Lea_WMDE closed this task as Resolved.Sep 25 2018, 12:54 PM
• Lea_WMDE triaged this task as Medium priority.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits