Page MenuHomePhabricator

Fix List Applications overlapping statistics for waitlisted partners with short description panels
Closed, ResolvedPublic

Description

Task

On some partner pages where the description and other partner metadata aren't extensive (e.g. https://wikipedialibrary.wmflabs.org/partners/71/), coordinators and superusers see boxes overlapping with each other. This problem won't be visible to most users of the site. When working on this task we recommend setting yourself to be a superuser and waitlisting a partner with a short description.

We should ensure that the Metrics boxes come below the lowest button on the right.

image.png (755×1 px, 115 KB)

Good first bug

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Event Timeline

Samwalton9 triaged this task as Lowest priority.Aug 30 2018, 2:17 PM
Samwalton9 moved this task from Incoming tasks to Open tasks on the Library-Card-Platform board.
Samwalton9 moved this task from Planned to Open tasks on the Library-Card-Platform board.
Samwalton9 added a project: good first task.
Samwalton9 added a subscriber: jsn.sherman.
AVasanth_WMF raised the priority of this task from Lowest to Medium.Nov 27 2019, 3:19 PM

With 357, this is going to happen more often.

Hello @Samwalton9 I'll like to work on this task. But I'm finding it a bit difficult figuring out the file that causes this behavior. I'll appreciate some help.

Thanks @AVasanth_WMF for the pointer. I'm trying to run docker-compose build && docker-compose up on my computer, but it comes up with errors and a very long traceback.

@HAKSOAT what version of Ubuntu are you running? Also, can you verify if your computer has a 64-bit AMD/Intel processor?

You can check your Ubuntu version by running lsb_release -a at the terminal

You can check the processor architecture by running uname -m at the terminal

Ubuntu 19.10

x86_64

Those are the values I got from those commands.

I want to know, does this task include rendering 'List applications' button for xs screen sizes as it is not showing currently?

image.png (982×867 px, 94 KB)

image.png (936×624 px, 67 KB)

Also, in the TWLight > static > css > local.css file, resource-label

.resource-label {
  #margin: 0px -10px 0px 0px;
  #color:#337ab7;
  #padding: .2em .6em .3em;
  padding: .2em 0 .2em .7em;
}

Were these properties with hashtags (margin, color, padding) meant to be commented?

I want to know, does this task include rendering 'List applications' button for xs screen sizes as it is not showing currently?

'List applications' is meant for coordinators and the page is not entirely useful on mobile screens. Also, following T236284 the page could be scrapped, so no, the button can be ignored for xs screens.

Were these properties with hashtags (margin, color, padding) meant to be commented?

Probably, the hashed properties add undesirable, albeit minor, changes to the span and is covered by parent classes. Blame shows the changes were incorporated by @jsn.sherman, and he should be able to explain why it's there.

Okay!
Can you please review this?!

image.png (965×1 px, 130 KB)

image.png (968×1 px, 119 KB)

image.png (969×1 px, 98 KB)

image.png (960×1 px, 73 KB)

This took some structural changes some what like this in the partner_detail.html:

<div class="float-container margin-bottom-2em">
    <div class="row">
          <div class="col-md-8 col-lg-8 col-sm-8">
                <ul class="timeline half-timeline"> ... </ul>
          </div>
          <div class="col-sm-4 col-md-4 col-sm-4 pull-right">
                <div class="hidden-xs alert alert-warning resource-label-warning"> ... </div>
          </div>
     </div>
</div>
Samwalton9 moved this task from Open tasks to Done on the Library-Card-Platform board.