Page MenuHomePhabricator
Create Task
Maniphest T203284

"Copyvio" link to CopyPatrol doesn't work for drafts, should drop Draft: namespace prefix
Closed, ResolvedPublic
Actions

Description

  1. Go to Special:NewPagesFeed on testwiki
  2. Switch to AFC mode and filter for copyvio articles only
  3. Click the "copyvio" link for an article (e.g. Draft:Australian Open 2019)
  4. Note that the CopyPatrol results page doesn't show any results

This is because the link goes to https://tools.wmflabs.org/copypatrol/en?filter=all&searchCriteria=page_exact&searchText=Draft%3AAustralian%20Open%202019&drafts=1 , but the correct link would be https://tools.wmflabs.org/copypatrol/en?filter=all&searchCriteria=page_exact&searchText=Australian%20Open%202019&drafts=1 . Apparently the searchText parameter expects a page title without a namespace prefix.

Details

SubjectRepoBranchLines +/-
Fix CopyPatrol links for draftsmediawiki/extensions/PageTriagewmf/1.32.0-wmf.20+3 -2
Fix CopyPatrol links for draftsmediawiki/extensions/PageTriagemaster+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Aug 31 2018, 9:42 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 31 2018, 9:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MMiller_WMF added a parent task: T199359: New Pages Feed: copyvio addition.Aug 31 2018, 9:44 PM
Catrope mentioned this in T203119: Copyvio: prepare Test Wiki for community testing.Aug 31 2018, 9:51 PM
gerritbot subscribed.Sep 3 2018, 8:29 PM

Change 457679 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/PageTriage@master] Fix CopyPatrol links for drafts

https://gerrit.wikimedia.org/r/457679

gerritbot added a project: Patch-For-Review.Sep 3 2018, 8:29 PM
Catrope claimed this task.Sep 3 2018, 8:30 PM
Catrope edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Catrope moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
SBisson moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 4 2018, 1:13 PM
gerritbot added a comment.Sep 4 2018, 1:34 PM

Change 457679 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Fix CopyPatrol links for drafts

https://gerrit.wikimedia.org/r/457679

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 4 2018, 2:00 PM
gerritbot added a comment.Sep 5 2018, 12:15 AM

Change 458085 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.20] Fix CopyPatrol links for drafts

https://gerrit.wikimedia.org/r/458085

gerritbot added a comment.Sep 5 2018, 4:23 PM

Change 458085 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.20] Fix CopyPatrol links for drafts

https://gerrit.wikimedia.org/r/458085

Stashbot subscribed.Sep 5 2018, 4:35 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-05T16:35:39Z] <thcipriani@deploy1001> Synchronized php-1.32.0-wmf.20/extensions/PageTriage/modules/ext.pageTriage.models/ext.pageTriage.article.js: SWAT: [[gerrit:458085|Fix CopyPatrol links for drafts]] T203284 (duration: 00m 57s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)); removed MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 5 2018, 5:00 PM
Etonkovidova added subscribers: MMiller_WMF, Etonkovidova.Sep 6 2018, 5:11 AM

Checked in testwiki (wmf.20) - the link is fixed, e.g. https://tools.wmflabs.org/copypatrol/en?filter=all&searchCriteria=page_exact&searchText=Australian%20Open%202019&drafts=1

@MMiller_WMF - is it ok to have in Search box the article name without 'Draft' but to list the full page title with 'Draft' namespace?

Screen Shot 2018-09-05 at 9.59.13 PM.png (356×1 px, 109 KB)

MMiller_WMF added a comment.Sep 6 2018, 4:25 PM

@Etonkovidova -- that is okay; it is a existing characteristic of CopyPatrol, and we're not planning on changing CopyPatrol. Did you find any other issues?

Etonkovidova closed this task as Resolved.Sep 6 2018, 5:09 PM

@MMiller_WMF - everything else seems to be fine - closing the ticket as Resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits