Page MenuHomePhabricator
Create Task
Maniphest T204864

[1.32.0-wmf.22] includes/GlobalPreferencesFactory.php: PHP Notice: Undefined index: section
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Exception id: W6J6LArAIDoAAIP8@ScAAABQ

Message: PHP Notice: Undefined index: section

#0 /srv/mediawiki/php-1.32.0-wmf.22/extensions/GlobalPreferences/includes/GlobalPreferencesFactory.php(172): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.22/extensions/GlobalPreferences/includes/GlobalPreferencesFactory.php(119): GlobalPreferences\GlobalPreferencesFactory->getPreferencesLocal(array, array, RequestContext)
#2 /srv/mediawiki/php-1.32.0-wmf.22/includes/preferences/DefaultPreferencesFactory.php(1496): GlobalPreferences\GlobalPreferencesFactory->getFormDescriptor(User, RequestContext)
#3 /srv/mediawiki/php-1.32.0-wmf.22/includes/specials/SpecialPreferences.php(173): MediaWiki\Preferences\DefaultPreferencesFactory->getForm(User, RequestContext, string)
#4 /srv/mediawiki/php-1.32.0-wmf.22/includes/specials/SpecialPreferences.php(112): SpecialPreferences->getFormObject(User, RequestContext)
#5 /srv/mediawiki/php-1.32.0-wmf.22/includes/specialpage/SpecialPage.php(569): SpecialPreferences->execute(NULL)
#6 /srv/mediawiki/php-1.32.0-wmf.22/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(NULL)
#7 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#8 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(868): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(525): MediaWiki->main()
#10 /srv/mediawiki/php-1.32.0-wmf.22/index.php(42): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include(string)
#12 {main}

Or via the API:

#0 /srv/mediawiki/php-1.32.0-wmf.22/extensions/GlobalPreferences/includes/GlobalPreferencesFactory.php(172): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.22/extensions/GlobalPreferences/includes/GlobalPreferencesFactory.php(119): GlobalPreferences\GlobalPreferencesFactory->getPreferencesLocal(array, array, DerivativeContext)
#2 /srv/mediawiki/php-1.32.0-wmf.22/includes/api/ApiOptions.php(149): GlobalPreferences\GlobalPreferencesFactory->getFormDescriptor(User, DerivativeContext)
#3 /srv/mediawiki/php-1.32.0-wmf.22/includes/api/ApiOptions.php(75): ApiOptions->getPreferences()
#4 /srv/mediawiki/php-1.32.0-wmf.22/includes/api/ApiMain.php(1587): ApiOptions->execute()
#5 /srv/mediawiki/php-1.32.0-wmf.22/includes/api/ApiMain.php(531): ApiMain->executeAction()
#6 /srv/mediawiki/php-1.32.0-wmf.22/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#7 /srv/mediawiki/php-1.32.0-wmf.22/api.php(87): ApiMain->execute()
#8 /srv/mediawiki/w/api.php(3): include(string)
#9 {main}

https://test.wikipedia.org/wiki/Special:Preferences

Details

SubjectRepoBranchLines +/-
Consider pref sections optionalmediawiki/extensions/GlobalPreferenceswmf/1.32.0-wmf.22+6 -3
Consider pref sections optionalmediawiki/extensions/GlobalPreferencesmaster+6 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Sep 19 2018, 7:00 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptSep 19 2018, 7:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper added a project: Wikimedia-production-error.Sep 19 2018, 9:45 PM
Krinkle moved this task from Untriaged to Nov2019/1.35.wmf.5+ on the Wikimedia-production-error board.Sep 19 2018, 10:26 PM
Krinkle moved this task from Nov2019/1.35.wmf.5+ to Mar 2021 on the Wikimedia-production-error board.Sep 19 2018, 10:54 PM
Krinkle subscribed.

Triaging as Meta/Low priority for the time being as I've not been able to reproduce this on a wiki besides test.wikipedia.org. It is still likely to be a real problem, but at least the particular circumstances required for it (e.g. a combination of two extensions registering certain preferences) is not being triggered elsewhere.

Krinkle moved this task from Mar 2021 to Nov2019/1.35.wmf.5+ on the Wikimedia-production-error board.EditedSep 19 2018, 10:56 PM

Belay that. I can reproduce it on ca.wikipedia.org now. Submitting the form at https://ca.wikipedia.org/wiki/Especial:Llista_de_seguiment consistently produces:

PHP Notice: Undefined index: section

#0 /srv/mediawiki/php-1.32.0-wmf.22/extensions/GlobalPreferences/includes/GlobalPreferencesFactory.php(166): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.22/extensions/GlobalPreferences/includes/GlobalPreferencesFactory.php(119): GlobalPreferences\GlobalPreferencesFactory->getPreferencesLocal(array, array, RequestContext)
#2 /srv/mediawiki/php-1.32.0-wmf.22/includes/preferences/DefaultPreferencesFactory.php(1496): GlobalPreferences\GlobalPreferencesFactory->getFormDescriptor(User, RequestContext)
#3 /srv/mediawiki/php-1.32.0-wmf.22/includes/specials/SpecialPreferences.php(173): MediaWiki\Preferences\DefaultPreferencesFactory->getForm(User, RequestContext, string)
#4 /srv/mediawiki/php-1.32.0-wmf.22/includes/specials/SpecialPreferences.php(112): SpecialPreferences->getFormObject(User, RequestContext)
#5 /srv/mediawiki/php-1.32.0-wmf.22/includes/specialpage/SpecialPage.php(569): SpecialPreferences->execute(NULL)
#6 /srv/mediawiki/php-1.32.0-wmf.22/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(NULL)
#7 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#8 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(868): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(525): MediaWiki->main()
#10 /srv/mediawiki/php-1.32.0-wmf.22/index.php(42): MediaWiki->run()

This error is not seen on earlier branches and not yet seen on group2 wikis (which run wmf.20). As such, marking as regression.

Krinkle added a parent task: T191068: 1.32.0-wmf.22 deployment blockers.Sep 19 2018, 10:58 PM
gerritbot subscribed.Sep 20 2018, 12:06 AM

Change 461499 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Consider pref sections optional

https://gerrit.wikimedia.org/r/461499

gerritbot added a project: Patch-For-Review.Sep 20 2018, 12:06 AM
gerritbot added a comment.Sep 20 2018, 12:29 AM

Change 461501 had a related patch set uploaded (by Krinkle; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@wmf/1.32.0-wmf.22] Consider pref sections optional

https://gerrit.wikimedia.org/r/461501

gerritbot added a comment.Sep 20 2018, 12:48 AM

Change 461499 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Consider pref sections optional

https://gerrit.wikimedia.org/r/461499

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 20 2018, 1:00 AM
gerritbot added a comment.Sep 20 2018, 1:02 AM

Change 461501 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@wmf/1.32.0-wmf.22] Consider pref sections optional

https://gerrit.wikimedia.org/r/461501

Stashbot subscribed.Sep 20 2018, 1:14 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-20T01:14:45Z] <krinkle@deploy1001> Synchronized php-1.32.0-wmf.22/extensions/GlobalPreferences/includes/GlobalPreferencesFactory.php: I52434a523f60e, T204864 (duration: 00m 58s)

Krinkle closed this task as Resolved.Sep 20 2018, 1:44 AM
Krinkle assigned this task to MaxSem.
Krinkle removed a project: Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)); removed MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 20 2018, 2:00 AM
Krinkle moved this task from Nov2019/1.35.wmf.5+ to Resolved on the Wikimedia-production-error board.Jan 24 2019, 5:33 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL