Maniphest T205864

Special:NewLexeme no longer supports passing lemma-language in the URL
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

For some languages, Special:NewLexeme requires entering the lemma language separately. Until a few weeks ago, it was possible to pass lemma-language as a URL parameter to Special:NewLexeme to prefill the form fields. Now the lemma-language parameter is ignored and the lexeme can't be added unless the user manually fills in that field. Other parameters still work.

Examples:

It would be useful for this to work again, because then people can create links/bookmarks for common combinations.

Details

	Subject	Repo	Branch	Lines +/-
	Stop clearing lemma language code on Special:NewLexeme load	mediawiki/extensions/WikibaseLexeme	master	+65 -5

Customize query in gerrit

Related Objects

Mentioned In: rEWLEa65c25479da6: Stop clearing lemma language code on Special:NewLexeme load
rEWLE522a352fee0b: Stop clearing lemma language code on Special:NewLexeme load
rEWLE3d8808d28a2a: Stop clearing lemma language code on Special:NewLexeme load
rEWLE76a0c6a62de7: Stop clearing lemma language code on Special:NewLexeme load

Event Timeline

Nikki created this task.Oct 1 2018, 1:50 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 1 2018, 1:50 PM

@Addshore Could you have a look?

Addshore added projects: Regression, Wikidata-Campsite, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Oct 2 2018, 1:35 PM

Addshore moved this task from Incoming to In Progress on the Wikidata-Campsite board.

Addshore set the point value for this task to 3.

Addshore moved this task from incoming to in progress on the Wikidata board.

Marking as high as it is a Regression

Ladsgroup claimed this task.Oct 2 2018, 2:38 PM

Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptOct 2 2018, 2:38 PM

This was happening before the refactorings (I used an old version) and it's a frontend issue. When you apply it, the input element has the value of the language but it gets overridden by the language selector widget. Probably @Jakob_WMDE is better suited to take a look here.

Since @Jakob_WMDE is now hiking on Termbox I'll pick this up and take a look. If I hit a wall I'll page him :)

Change 466942 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] Stop clearing lemma language code on Special:NewLexeme load

https://gerrit.wikimedia.org/r/466942

gerritbot added a project: Patch-For-Review.Oct 12 2018, 6:17 PM

Tarrow mentioned this in rEWLE76a0c6a62de7: Stop clearing lemma language code on Special:NewLexeme load.Oct 12 2018, 6:18 PM

Tarrow mentioned this in rEWLE3d8808d28a2a: Stop clearing lemma language code on Special:NewLexeme load.Oct 15 2018, 9:41 AM

Tarrow moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 15 2018, 9:43 AM

Addshore mentioned this in rEWLEa65c25479da6: Stop clearing lemma language code on Special:NewLexeme load.Oct 16 2018, 10:51 AM

Addshore mentioned this in rEWLE522a352fee0b: Stop clearing lemma language code on Special:NewLexeme load.

Change 466942 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Stop clearing lemma language code on Special:NewLexeme load

https://gerrit.wikimedia.org/r/466942

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 16 2018, 12:01 PM

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 16 2018, 4:31 PM